[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2020-03-10 Thread Christian Ehrhardt
** Changed in: ec2-instance-connect (Ubuntu) Assignee: (unassigned) => Matthias Klose (doko) -- You received this bug notification because you are a member of cloud- init Commiters, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1835114 Title: [MIR] ec2-instance-co

[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2020-02-10 Thread Christian Ehrhardt
** Bug watch added: github.com/aws/aws-ec2-instance-connect-config/issues #15 https://github.com/aws/aws-ec2-instance-connect-config/issues/15 -- You received this bug notification because you are a member of cloud- init Commiters, which is subscribed to the bug report. https://bugs.launchpad.

Re: [Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2020-02-10 Thread Christian Ehrhardt
On Wed, Feb 5, 2020 at 10:55 PM Balint Reczey wrote: > @paelzer I attempt to answer the review comments below > Thank you @Rbalint for picking this up and driving it. I'll skip sections that are ok now - thanks for adding/fixing all those! > > - an ack by the cloud-init Team that this does not

[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2020-02-04 Thread Christian Ehrhardt
Hi, this was waiting for updates/fixes to a bunch of things as identified in former reviews before being re-reviewed. The correct state of this is "incomplete" until all that was requested is provided. (And even then it just means to restart review without guarantees to pass cleanly). ** Chang

[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2019-07-03 Thread Christian Ehrhardt
Also while thinking about it, ~5-8 curl calls fro every SSH login can be quite expensive. I know it fortunately has an early exit but that still is 2 curl requests. If this is installed in any place without the endpoint at 169.254.169.254 being responsive and super fast this could lead to a very

[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2019-07-03 Thread Christian Ehrhardt
Since before we had a lot of text @cloud-nit team - please review and ack that this is no conflict with what/how cloud-init is/will provide. -- You received this bug notification because you are a member of cloud- init commiters, which is subscribed to the bug report. https://bugs.launchpad.net/b

[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2019-07-03 Thread Christian Ehrhardt
[Summary] It seems mostly to me packaging wise, but I think there are a bunch of things needed to be doen to complete this. We need: - an ack by the cloud-init Team that this does not conflict with our usual services provided through cloud init - I'm subscribing the cloud-init Team to give it a