Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:no-cheetah into cloud-init:master

2017-01-11 Thread Joshua Harlow
that could be a solution; i'd be ok with that, other option is to release cloud-init 1.0 and switch it then. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/308304 Your team cloud init development team is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:chop-bitly into cloud-init:master

2016-12-02 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:chop-bitly into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/312390 -- Your team cloud init development

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:error-output into cloud-init:master

2016-10-13 Thread Joshua Harlow
Diff comments: > diff --git a/tests/unittests/test_util.py b/tests/unittests/test_util.py > index fc6b9d4..f8d416c 100644 > --- a/tests/unittests/test_util.py > +++ b/tests/unittests/test_util.py > @@ -604,11 +604,70 @@ class TestSubp(helpers.TestCase): >

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:yaml-check-python into cloud-init:master

2016-10-07 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:yaml-check-python into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/307996 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:kill-brpm into cloud-init:master

2016-10-07 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:kill-brpm into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/307991 Suse may need additional work btw

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:tpl-cloud-cfg into cloud-init:master

2016-10-03 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:tpl-cloud-cfg into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/307485 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:ug_util into cloud-init:master

2016-09-30 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:ug_util into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/307373 -- Your team cloud init development

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-09-30 Thread Joshua Harlow
Oh, lol. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into cloud-init:master. ___ Mailing list:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix-py26 into cloud-init:master

2016-09-30 Thread Joshua Harlow
Looks fine to me, thanks scott :) -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/307363 Your team cloud init development team is requested to review the proposed merge of ~smoser/cloud-init:fix-py26 into cloud-init:master. ___

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:split-cloud-cfg into cloud-init:master

2016-09-29 Thread Joshua Harlow
So let me see how templating goes. You are right, we do have it. With templating I think we don't need setup.py to do the selection then. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/307100 Your team cloud init development team is requested to review the proposed

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-09-21 Thread Joshua Harlow
Ya, that makes sense to me, I can adjust this one. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into cloud-init:master.

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:local-before-nm into cloud-init:master

2016-09-20 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:local-before-nm into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/306283 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-09-15 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:sys-io-errors into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:fix-26 into cloud-init:master

2016-08-25 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:fix-26 into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/304001 -- Your team cloud init development team

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:newer-configobj into cloud-init:master

2016-08-10 Thread Joshua Harlow
Sure. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301728 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:newer-configobj into cloud-init:master. ___ Mailing list:

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:config-entrypoints into cloud-init:master

2016-08-10 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:config-entrypoints into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/302609 -- Your team cloud init

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master

2016-08-03 Thread Joshua Harlow
So https://review.openstack.org/#/c/350861 is the addition to pbr for the 'deb version' so this imho makes me lean towards using pbr vs this package, and using either over a custom hand rolled version calculation scheme. Because with a hand rolled scheme, I'll still need to be translating the

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master

2016-08-03 Thread Joshua Harlow
I guess the only thing that I can think about that makes using these tools useful is that they can provide a consistent way of getting that version (instead of yet another one-off way of getting it); pbr also has the nice ability to generate a debian version string and a redhat version string,

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:space into cloud-init:master

2016-08-01 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:space into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301731 -- Your team cloud init development team

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:newer-configobj into cloud-init:master

2016-08-01 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:newer-configobj into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301728 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:just-file-logs into cloud-init:master

2016-08-01 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:just-file-logs into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301729 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:fix-distro-tags into cloud-init:master

2016-08-01 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:fix-distro-tags into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301730 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:scm-version into cloud-init:master

2016-08-01 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:scm-version into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301727 -- Your team cloud init development

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:update-configobj into cloud-init:master

2016-07-29 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:update-configobj into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301541 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:spacewalk into cloud-init:master

2016-07-26 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:spacewalk into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301224 -- Your team cloud init development

Re: [Cloud-init-dev] [Merge] ~larsks/cloud-init:feature/move-to-git into cloud-init:master

2016-07-25 Thread Joshua Harlow
Diff comments: > diff --git a/README.rst b/README.rst > new file mode 100644 > index 000..e56e663 > --- /dev/null > +++ b/README.rst > @@ -0,0 +1,15 @@ > +Cloud-init > +== > + > +Cloud-init is the defacto multi-distribution package that handles > +early initialization of a cloud

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:skip-things into cloud-init:master

2016-07-25 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:skip-things into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301110 -- Your team cloud init development

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:update-configobj into cloud-init:master

2016-07-25 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:update-configobj into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301109 -- Your team cloud init

[Cloud-init-dev] [Merge] ~harlowja/cloud-init:distro-tags into cloud-init:master

2016-07-25 Thread Joshua Harlow
Joshua Harlow has proposed merging ~harlowja/cloud-init:distro-tags into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301108 -- Your team cloud init development

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-tag-distros into lp:cloud-init

2016-07-22 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-tag-distros into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-tag-distros/+merge/300840 -- Your team cloud

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-configobj-bound into lp:cloud-init

2016-07-21 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-fix-configobj-bound into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1603238 in cloud-init: "BOM error updating hostname on centos6.x" https://bugs.lau

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-dynamic-distro-check into lp:cloud-init

2016-07-21 Thread Joshua Harlow
Yup, I updated it to try that approach instead; seems like its better IMHO. -- https://code.launchpad.net/~harlowja/cloud-init/cloud-init-dynamic-distro-check/+merge/300805 Your team cloud init development team is requested to review the proposed merge of

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-dynamic-distro-check into lp:cloud-init

2016-07-21 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-dynamic-distro-check into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-dynamic-distro-check/+merge/300805

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-file-logging into lp:cloud-init

2016-07-21 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-file-logging into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-file-logging/+merge/300798 It's less

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-26 into lp:cloud-init

2016-07-12 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-fix-26 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-26/+merge/299891 Fixes a stray dict

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-dnf into lp:cloud-init

2016-07-06 Thread Joshua Harlow
Diff comments: > === modified file 'cloudinit/distros/rhel.py' > --- cloudinit/distros/rhel.py 2016-06-15 23:11:24 + > +++ cloudinit/distros/rhel.py 2016-07-01 00:07:56 + > @@ -201,14 +203,22 @@ > if pkgs is None: > pkgs = [] > > -cmd = ['yum'] > -

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-dnf into lp:cloud-init

2016-06-30 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-fix-dnf into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-dnf/+merge/298851 Enable usage of DNF

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-rpm-build into lp:cloud-init

2016-06-30 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-fix-rpm-build into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-rpm-build/+merge/298849 Fixes

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-enhanced-bootcmd into lp:cloud-init

2016-06-23 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-enhanced-bootcmd into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-enhanced-bootcmd/+merge/298254 Some

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.1532072 into lp:cloud-init

2016-06-21 Thread Joshua Harlow
Seems ok to me! -- https://code.launchpad.net/~smoser/cloud-init/trunk.1532072/+merge/298066 Your team cloud init development team is requested to review the proposed merge of lp:~smoser/cloud-init/trunk.1532072 into lp:cloud-init. ___ Mailing list:

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-dns-sysconfig into lp:cloud-init

2016-06-20 Thread Joshua Harlow
Ya, I had a hard time finding out how to make it so that each interface could have its own dns server and such configuration; it really seems like not many systems allow for doing this very well... -- https://code.launchpad.net/~harlowja/cloud-init/cloud-init-dns-sysconfig/+merge/297817 Your

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-dns-sysconfig into lp:cloud-init

2016-06-17 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-dns-sysconfig into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-dns-sysconfig/+merge/297817 It appears

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-up-cli into lp:cloud-init

2016-06-14 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-fix-up-cli into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-up-cli/+merge/297409 -- Your team cloud

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-net-sysconfig into lp:cloud-init

2016-06-14 Thread Joshua Harlow
Diff comments: > === modified file 'cloudinit/distros/rhel.py' > --- cloudinit/distros/rhel.py 2015-06-02 20:27:57 + > +++ cloudinit/distros/rhel.py 2016-06-14 17:59:09 + > @@ -59,10 +61,16 @@ > # should only happen say once per instance...) > self._runner =

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-net-sysconfig into lp:cloud-init

2016-06-10 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-net-sysconfig into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-net-sysconfig/+merge/297115 -- Your team

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init

2016-06-03 Thread Joshua Harlow
Can u add a part of the description around 'def rename_interfaces' so that people know why this is needed, be much appreciated :) -- https://code.launchpad.net/~smoser/cloud-init/trunk.fix-networking/+merge/296272 Your team cloud init development team is requested to review the proposed merge

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-test-times into lp:cloud-init

2016-05-24 Thread Joshua Harlow
The proposal to merge lp:~harlowja/cloud-init/cloud-init-fix-test-times into lp:cloud-init has been updated. Commit Message changed to: Fixes up tests taking forever due to retries and timeouts. Timing info: Fixed timing via `time nosetests`: real0m12.376s user0m6.797s sys 0m0.616s

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-net-moves into lp:cloud-init

2016-05-04 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-net-moves into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-net-moves/+merge/293807 Moves around

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-git-tarball-make into lp:cloud-init

2015-09-16 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/cloud-init-git-tarball-make into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/cloud-init-git-tarball-make/+merge/271394 Make

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-21 Thread Joshua Harlow
The proposal to merge lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812 -- Your team cloud init development team is

[Cloud-init-dev] [Merge] lp:~brak/cloud-init/centos-7-fixes into lp:cloud-init

2015-04-21 Thread Joshua Harlow
The proposal to merge lp:~brak/cloud-init/centos-7-fixes into lp:cloud-init has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~brak/cloud-init/centos-7-fixes/+merge/256340 -- Your team cloud init development team is requested to review the

[Cloud-init-dev] [Merge] lp:~gerhard-1/cloud-init/fixate-uid into lp:cloud-init

2015-04-21 Thread Joshua Harlow
The proposal to merge lp:~gerhard-1/cloud-init/fixate-uid into lp:cloud-init has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~gerhard-1/cloud-init/fixate-uid/+merge/256140 -- Your team cloud init development team is requested to review

Re: [Cloud-init-dev] [Merge] lp:~barry/cloud-init/py2-3 into lp:cloud-init

2015-01-27 Thread Joshua Harlow
Thanks, I'll address each of the comments separately. test-requirements.txt can probably go away. If you use tox, it won't be used any more. The tox.ini file specifies the test dependencies, but I'll leave removal of test-requirements.txt to you. (I also am not using the Makefile; season

Re: [Cloud-init-dev] [Merge] lp:~barry/cloud-init/py2-3 into lp:cloud-init

2015-01-23 Thread Joshua Harlow
Looks pretty good to me (seems like there is a new conflict against trunk/head); thanks for beating the tests into shape. -- https://code.launchpad.net/~barry/cloud-init/py2-3/+merge/247239 Your team cloud init development team is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] lp:~shraddha-pandhe/cloud-init/cloud-init-ipv6-support into lp:cloud-init

2014-11-21 Thread Joshua Harlow
Diff comments: === modified file 'cloudinit/distros/net_util.py' --- cloudinit/distros/net_util.py 2014-01-24 21:20:54 + +++ cloudinit/distros/net_util.py 2014-11-21 22:24:21 + @@ -113,6 +113,10 @@ for info in ifaces: if 'iface' not in info:

Re: [Cloud-init-dev] [Merge] lp:~nshrader/cloud-init/digitalocean-datasource into lp:cloud-init

2014-10-17 Thread Joshua Harlow
Diff comments: === added file 'cloudinit/sources/DataSourceDigitalOcean.py' --- cloudinit/sources/DataSourceDigitalOcean.py 1970-01-01 00:00:00 + +++ cloudinit/sources/DataSourceDigitalOcean.py 2014-10-17 22:04:47 + @@ -0,0 +1,105 @@ +# vi: ts=4 expandtab +# +#

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/better-chef-module into lp:cloud-init

2014-10-11 Thread Joshua Harlow
Diff comments: === modified file 'cloudinit/config/cc_chef.py' --- cloudinit/config/cc_chef.py 2014-08-26 18:50:11 + +++ cloudinit/config/cc_chef.py 2014-10-12 00:01:55 + @@ -18,6 +18,7 @@ #You should have received a copy of the GNU General Public License #

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/better-chef-module into lp:cloud-init

2014-10-10 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/better-chef-module into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/better-chef-module/+merge/238040 Increase the robustness

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/test-fixups into lp:cloud-init

2014-10-10 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/test-fixups into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/test-fixups/+merge/238042 Fix some of the erroring out test cases

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/os-caching into lp:cloud-init

2014-08-26 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/os-caching into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/os-caching/+merge/232303 Better caching of things that exist

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/smart-read into lp:cloud-init

2014-08-26 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/smart-read into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/smart-read/+merge/232316 -- https://code.launchpad.net/~harlowja

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/less-noise into lp:cloud-init

2014-07-15 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/less-noise into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/less-noise/+merge/226940 Less noisy logs. Removes some of the log

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/six-2-3-compat into lp:cloud-init

2014-06-29 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/six-2-3-compat into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/six-2-3-compat/+merge/224933 This starts along the path of dual

Re: [Cloud-init-dev] [Merge] lp:~rjschwei/cloud-init/initcmdGetter into lp:cloud-init

2014-06-29 Thread Joshua Harlow
I'm slightly confused here, why is this offering anything that classes couldn't already do by overriding the 'init_cmd' class variable with there own instance specific version. class A(object): ... b = 'c' ... class D(A): ... def __init__(self): ... self.b = 'd' ... a = A()

Re: [Cloud-init-dev] [Merge] lp:~kiril-vladimiroff/cloud-init/cloudsigma-vendordata into lp:cloud-init

2014-04-12 Thread Joshua Harlow
Seems all fixed up to me :) -- https://code.launchpad.net/~kiril-vladimiroff/cloud-init/cloudsigma-vendordata/+merge/214763 Your team cloud init development team is requested to review the proposed merge of lp:~kiril-vladimiroff/cloud-init/cloudsigma-vendordata into lp:cloud-init.

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/no-negative-max-wait into lp:cloud-init

2014-04-09 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/no-negative-max-wait into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/no-negative-max-wait/+merge/215020 Fix max_wait being

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/monotonic-compat into lp:cloud-init

2014-04-04 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/monotonic-compat into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1273255 in cloud-init: wait_for_url doesn't account for system clock being changed https://bugs.launchpad.net

Re: [Cloud-init-dev] [Merge] lp:~juergh/cloud-init/lp1298921 into lp:cloud-init

2014-04-04 Thread Joshua Harlow
Is there any reason the method in ec2_utils wouldn't work, that allows it to be a case-specific skipping of 404, instead of always skipping on 404. It seems like something like that which allows could be used to preemptively abort the retry (instead of the code below, which makes it very

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/local-before-net into lp:cloud-init

2014-03-19 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/local-before-net into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/local-before-net/+merge/211783 Since cloud-init-local

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/vd-helper-layer into lp:cloud-init

2014-03-01 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/vd-helper-layer into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/vd-helper-layer/+merge/208948 Do the vendor data namespace

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/strip-iid-newline into lp:cloud-init

2014-02-24 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/strip-iid-newline into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/strip-iid-newline/+merge/208028 -- https

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

2014-02-08 Thread Joshua Harlow
Seems ok, one change. resp = url_helper.readurl(url=url_map[mkey], headers=headers) Can u wrap this with a try: except IOError: block. Thanks -- https://code.launchpad.net/~jablonskis/cloud-init/add-gce-datasource/+merge/204464 Your team cloud init development team is requested to review the

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

2014-02-08 Thread Joshua Harlow
Thanks, Can we also have some tests :) U should be able to use httpretty to simulate the gce datasource like is being used in: https://code.launchpad.net/~harlowja/cloud-init/ds-openstack/+merge/204390 (search for 'test_openstack.py' and for '_register_uris' for the mocking part). --

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init

2014-02-07 Thread Joshua Harlow
The proposal to merge lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init has been updated. Description changed to: Add a openstack specific datasource Openstack has a unique derivative datasource that is gaining usage. Previously the config drive datasource provided part of this

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init

2014-02-07 Thread Joshua Harlow
The proposal to merge lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init has been updated. Description changed to: Add a openstack specific datasource Openstack has a unique derivative datasource that is gaining usage. Previously the config drive datasource provided part of this

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

2014-02-06 Thread Joshua Harlow
Instead of using requests directly can u use the nice helper we provide via url_helper. That should save you from recreating some of the same code. -- https://code.launchpad.net/~jablonskis/cloud-init/add-gce-datasource/+merge/204464 Your team cloud init development team is requested to review

Re: [Cloud-init-dev] [Merge] lp:~vlastimil-holer/cloud-init/fix-rpm-build into lp:cloud-init

2014-02-01 Thread Joshua Harlow
Just a quick question. My lack of sudo skills. +Cmnd_Alias CI = /bin/bash +root ALL=(nobody) NOPASSWD: CI This makes /bin/bash runnable with no password by anyone with (nobody) user??? -- https://code.launchpad.net/~vlastimil-holer/cloud-init/fix-rpm-build/+merge/204266 Your team cloud init

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/ec2-settings-fix into lp:cloud-init

2014-02-01 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/ec2-settings-fix into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/ec2-settings-fix/+merge/204385 Fix incorrect return

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init

2014-02-01 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/ds-openstack/+merge/204390 Add a openstack specific datasource

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init

2014-02-01 Thread Joshua Harlow
Pretty much complete. Needs a few more tests, otherwise ready to go. -- https://code.launchpad.net/~harlowja/cloud-init/ds-openstack/+merge/204390 Your team cloud init development team is requested to review the proposed merge of lp:~harlowja/cloud-init/ds-openstack into lp:cloud-init.

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/tox-venvs into lp:cloud-init

2014-01-25 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/tox-venvs into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/tox-venvs/+merge/203225 Use a venv for testing and for lint checking

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/ec2-ssl into lp:cloud-init

2014-01-24 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/ec2-ssl into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/ec2-ssl/+merge/203185 Allow ssl details to be passed through

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/freebsd-cleaning-part-duo into lp:cloud-init

2014-01-24 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/freebsd-cleaning-part-duo into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/freebsd-cleaning-part-duo/+merge/203196 Fix logexc

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/not-found-userdata into lp:cloud-init

2014-01-23 Thread Joshua Harlow
The proposal to merge lp:~harlowja/cloud-init/not-found-userdata into lp:cloud-init has been updated. Description changed to: Skip retry and continued fetch of userdata when NOT_FOUND When a 404 http code comes back from the fetching of ec2 data, instead of retrying immediately stop the

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/not-found-userdata into lp:cloud-init

2014-01-23 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/not-found-userdata into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/not-found-userdata/+merge/202963 Skip retry and continued

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/net-distro-util into lp:cloud-init

2014-01-22 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/net-distro-util into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/net-distro-util/+merge/202743 -- https://code.launchpad.net

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/requirement-tweaks into lp:cloud-init

2014-01-17 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/requirement-tweaks into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/requirement-tweaks/+merge/202191 -- https

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/boto-ec2-replace into lp:cloud-init

2014-01-10 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/boto-ec2-replace into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/boto-ec2-replace/+merge/201269 Not done yet!! -- https

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/boto-ec2-replace into lp:cloud-init

2014-01-10 Thread Joshua Harlow
The proposal to merge lp:~harlowja/cloud-init/boto-ec2-replace into lp:cloud-init has been updated. Description changed to: For more details, see: https://code.launchpad.net/~harlowja/cloud-init/boto-ec2-replace/+merge/201269 --

Re: [Cloud-init-dev] [Merge] lp:~james-slagle/cloud-init/lp-1260072 into lp:cloud-init

2013-12-15 Thread Joshua Harlow
Seems good to me, thx james! -- https://code.launchpad.net/~james-slagle/cloud-init/lp-1260072/+merge/198964 Your team cloud init development team is requested to review the proposed merge of lp:~james-slagle/cloud-init/lp-1260072 into lp:cloud-init.

Re: [Cloud-init-dev] [Merge] lp:~harm-o/cloud-init/freebsd into lp:cloud-init

2013-12-15 Thread Joshua Harlow
Agreed on uptime, I guess we can keep the current impl, although I do wonder what happens if ctypes fails to load the library, perhaps some exception handled is useful around that? -- https://code.launchpad.net/~harm-o/cloud-init/freebsd/+merge/198130 Your team cloud init development team is

Re: [Cloud-init-dev] [Merge] lp:~harm-o/cloud-init/freebsd into lp:cloud-init

2013-12-10 Thread Joshua Harlow
https://github.com/pellaeon/bsd-cloudinit This may have more features from which to merge as well. It doesn't do config-drive AFAIK, but it might be useful? That's a different version of cloudinit that isn't this version, but a derivative that the windows folks created instead of getting

Re: [Cloud-init-dev] [Merge] lp:~harm-o/cloud-init/freebsd into lp:cloud-init

2013-12-07 Thread Joshua Harlow
Great start! Some initial comments :-) givecmdline() - can this function be in the distro object itself?? - can we use signal.SIG_DFL instead of just 0 (using the constant makes it so people can lookup that on websites, and understand it a little easier) - sys.platform -

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/mtab-fix into lp:cloud-init

2013-11-15 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/mtab-fix into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1248625 in cloud-init: resizefs fails on linux kernel versions 2.6.26 with error : IOError: [Errno 2] No such file

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/log-import-fail into lp:cloud-init

2013-10-09 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/log-import-fail into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/log-import-fail/+merge/190225 Add a log message around import

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-seedy into lp:cloud-init

2013-09-03 Thread Joshua Harlow
Sounds good, also do u know if the file paths are right. The ones I found look right for ubunutu/rhel but second verification wouldn't hurt. -- https://code.launchpad.net/~harlowja/cloud-init/cloud-init-seedy/+merge/183571 Your team cloud init development team is requested to review the proposed

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/serial-dep into lp:cloud-init

2013-07-27 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/serial-dep into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1205720 in cloud-init: SmartOS requires pyserial https://bugs.launchpad.net/cloud-init/+bug/1205720 For more details

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/mime-gzip-test into lp:cloud-init

2013-07-24 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/mime-gzip-test into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/mime-gzip-test/+merge/176614 Test for mime gzipped segments

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/no-dup-tz-find into lp:cloud-init

2013-07-24 Thread Joshua Harlow
Joshua Harlow has proposed merging lp:~harlowja/cloud-init/no-dup-tz-find into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/no-dup-tz-find/+merge/176861 Remove duplicate tz file finding

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-jsonpatch into lp:cloud-init

2013-07-23 Thread Joshua Harlow
Ah, it could be that. I was just using the rfc content-type that is being recommended for jsonp. What do u think makes sense??? -- https://code.launchpad.net/~harlowja/cloud-init/cloud-jsonpatch/+merge/175964 Your team cloud init development team is requested to review the proposed merge of

  1   2   >