Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:d91194fb65daabbed97b5e6eccdc087669420993
https://jenkins.ubuntu.com/server/job/cloud-init-ci/122/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
I added Andrew to this merge specifically for his insight on knowing how to
determine if a metadata version is available .
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/328241
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/c
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:e77a177c07a628226055bf034f45f4cde5be1577
https://jenkins.ubuntu.com/server/job/cloud-init-ci/121/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
I have one fun comment in line.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 4ec9592..dd9199e 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -137,22 +157,27 @@ class DataSourceE
Review: Approve continuous-integration
PASSED: Continuous integration, rev:b43779d06d30ca0877ab320855a8975bb7fb4df7
https://jenkins.ubuntu.com/server/job/cloud-init-ci/120/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
All comments addressed, and we now handle backward compatibility for old
metadata versions.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -175,12 +175,10
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:1a01cae3f83a00cd57bdb9322f58c5b4bfc67686
https://jenkins.ubuntu.com/server/job/cloud-init-ci/119/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:d114d715a42a0b4ce7fa3435eb5bff342a2fbe04
https://jenkins.ubuntu.com/server/job/cloud-init-ci/118/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:137c2881ed2d330f9b2f26a267680bbe2f945149
https://jenkins.ubuntu.com/server/job/cloud-init-ci/116/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:a1268952438c26bb949b7799019b1a8fbb1fe6e6
https://jenkins.ubuntu.com/server/job/cloud-init-ci/114/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -233,15 +231,24 @@ def generate_fallback_config(blacklist_drivers=None,
> config_driver=None):
> if D
theres nothing huge in my comments.
thanks.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -175,12 +175,10 @@ def is_disabled_cfg(cfg):
> return cfg.
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:f08dc1ea917cbd86a5ee4ab9e343800a6d904104
https://jenkins.ubuntu.com/server/job/cloud-init-ci/113/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 4ec9592..ae0fe26 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -73,21 +77,25 @@ class DataSourceEc2(sources.DataSource):
>
Diff comments:
> diff --git a/cloudinit/net/dhcp.py b/cloudinit/net/dhcp.py
> new file mode 100644
> index 000..4d59bd0
> --- /dev/null
> +++ b/cloudinit/net/dhcp.py
> @@ -0,0 +1,118 @@
> +# Copyright (C) 2017 Canonical Ltd.
> +#
> +# Author: Chad Smith
> +#
> +# This file is part of cloud-
This looks really good. Just some questions and clarifications in inline
comments.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -233,15 +231,24 @@ def
Review: Approve continuous-integration
PASSED: Continuous integration, rev:3b17a848a888090f61a7087eb617e455c905123e
https://jenkins.ubuntu.com/server/job/cloud-init-ci/108/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~chad.smith/cloud-init:aws-local-dhcp into
cloud-init:master has been updated.
Commit Message changed to:
ec2: Allow Ec2 to run in init-local using dhclient in a sandbox.
This branch is a prerequisite for IPv6 support in AWS and allows Ec2 datasource
to query the metadata
Chad Smith has proposed merging ~chad.smith/cloud-init:aws-local-dhcp into
cloud-init:master with ~chad.smith/cloud-init:unittests-in-cloudinit-package as
a prerequisite.
Commit message:
ec2: Allow Ec2 to run in init-local using dhclient in a sandbox.
This branch is a prerequisite for IPv6 supp
19 matches
Mail list logo