Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:d91194fb65daabbed97b5e6eccdc087669420993 https://jenkins.ubuntu.com/server/job/cloud-init-ci/122/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

I added Andrew to this merge specifically for his insight on knowing how to determine if a metadata version is available . -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/328241 Your team cloud-init commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:e77a177c07a628226055bf034f45f4cde5be1577 https://jenkins.ubuntu.com/server/job/cloud-init-ci/121/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

I have one fun comment in line. Diff comments: > diff --git a/cloudinit/sources/DataSourceEc2.py > b/cloudinit/sources/DataSourceEc2.py > index 4ec9592..dd9199e 100644 > --- a/cloudinit/sources/DataSourceEc2.py > +++ b/cloudinit/sources/DataSourceEc2.py > @@ -137,22 +157,27 @@ class

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

All comments addressed, and we now handle backward compatibility for old metadata versions. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index 46cb9c8..d38ea8b 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -175,12

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:137c2881ed2d330f9b2f26a267680bbe2f945149 https://jenkins.ubuntu.com/server/job/cloud-init-ci/116/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:a1268952438c26bb949b7799019b1a8fbb1fe6e6 https://jenkins.ubuntu.com/server/job/cloud-init-ci/114/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index 46cb9c8..d38ea8b 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -233,15 +231,24 @@ def generate_fallback_config(blacklist_drivers=None, > config_driver=None): > if

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

theres nothing huge in my comments. thanks. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index 46cb9c8..d38ea8b 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -175,12 +175,10 @@ def is_disabled_cfg(cfg): > return

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:f08dc1ea917cbd86a5ee4ab9e343800a6d904104 https://jenkins.ubuntu.com/server/job/cloud-init-ci/113/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Diff comments: > diff --git a/cloudinit/sources/DataSourceEc2.py > b/cloudinit/sources/DataSourceEc2.py > index 4ec9592..ae0fe26 100644 > --- a/cloudinit/sources/DataSourceEc2.py > +++ b/cloudinit/sources/DataSourceEc2.py > @@ -73,21 +77,25 @@ class DataSourceEc2(sources.DataSource): >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Diff comments: > diff --git a/cloudinit/net/dhcp.py b/cloudinit/net/dhcp.py > new file mode 100644 > index 000..4d59bd0 > --- /dev/null > +++ b/cloudinit/net/dhcp.py > @@ -0,0 +1,118 @@ > +# Copyright (C) 2017 Canonical Ltd. > +# > +# Author: Chad Smith > +# > +#

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:3b17a848a888090f61a7087eb617e455c905123e https://jenkins.ubuntu.com/server/job/cloud-init-ci/108/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

The proposal to merge ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master has been updated. Commit Message changed to: ec2: Allow Ec2 to run in init-local using dhclient in a sandbox. This branch is a prerequisite for IPv6 support in AWS and allows Ec2 datasource to query the

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

Chad Smith has proposed merging ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master with ~chad.smith/cloud-init:unittests-in-cloudinit-package as a prerequisite. Commit message: ec2: Allow Ec2 to run in init-local using dhclient in a sandbox. This branch is a prerequisite for IPv6