The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Description changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can now ma
Review: Approve continuous-integration
PASSED: Continuous integration, rev:29d0bb1cffd00ec3df0c2effd4a649af07390911
https://jenkins.ubuntu.com/server/job/cloud-init-ci/388/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/388
SUCCESS:
htt
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:15a8bc4dbb75ff9968c344cda907e0fd6ed3a0fd
https://jenkins.ubuntu.com/server/job/cloud-init-ci/386/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/386/console
@scott Addressed your review comments thanks a lot. So unittest runtimes
1m30sec versus 2m20sec? Do we want to make the switch to have all CiTestCase
subclasses logged?
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
>
Review: Approve continuous-integration
PASSED: Continuous integration, rev:49c4eb85daa77cb20a027e3199a92e3dbc773f53
https://jenkins.ubuntu.com/server/job/cloud-init-ci/381/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/381
SUCCESS:
htt
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -69,18 +67,12 @@ def handle(name, cfg, cloud, log, _args):
> " but not a d
some comments in line.
I'm generally in agreement here.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -53,14 +53,12 @@ distros = ['centos', 'debian'
The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can now
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -53,14 +53,12 @@ distros = ['centos', 'debian', 'fedora', 'opensuse',
> 'ubuntu']
>
>
> def handl
Review: Approve continuous-integration
PASSED: Continuous integration, rev:e4f11545162dc97c8dc0abc3d03981e9e1b895d1
https://jenkins.ubuntu.com/server/job/cloud-init-ci/378/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/378
SUCCESS:
htt
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:5ededba3f222795dea69af9d7d7e187c3fdf8bba
https://jenkins.ubuntu.com/server/job/cloud-init-ci/377/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/377/console
The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can now
Chad Smith has proposed merging ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324450
cc_ntp: Restructure cc_ntp unit tests a
The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Description changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can now ma
14 matches
Mail list logo
