Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-03-29 Thread Chad Smith
Dan will be taking over this branch as I am working exclusively on UA client for the near term. Items to fix/consider: - drop sso_* keys as timing of install won't pass 2FA since the 2fa code will likely change before the machine is configured - add a 'config' key under ubuntu-advantage to a

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-03-06 Thread Dan Watkins
The proposal to merge ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/362161 -- Your team cloud-init commiters is requ

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-03-06 Thread Dan Watkins
Moving this to WIP for now. -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/362161 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master. __

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-02-05 Thread Ryan Harper
Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_advantage.py > b/cloudinit/config/cc_ubuntu_advantage.py > index 5e082bd..1a95766 100644 > --- a/cloudinit/config/cc_ubuntu_advantage.py > +++ b/cloudinit/config/cc_ubuntu_advantage.py > @@ -1,145 +1,170 @@ > -# Copyright (C) 2018 Canoni

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-01-31 Thread Joshua Powers
Inline comment around sso auth Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_advantage.py > b/cloudinit/config/cc_ubuntu_advantage.py > index 5e082bd..1a95766 100644 > --- a/cloudinit/config/cc_ubuntu_advantage.py > +++ b/cloudinit/config/cc_ubuntu_advantage.py > @@ -1,145 +1,170 @@ >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-01-23 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:790c79bb86abb1de2449b0161152919c8b509700 https://jenkins.ubuntu.com/server/job/cloud-init-ci/534/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-01-23 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master. Commit message: ubuntu_advantage: update UA cloud-config module schema for ver.18 ubuntu-advantage-tools version 18 has a different command line interface. Update cloud-init's config module to acce