Hi Andrea, this branch was migrated over to GitHub (along with the rest of
cloud-init's code hosting :) and was proposed here:
https://github.com/canonical/cloud-init/pull/114
It landed in March and was included in the 20.2 cloud-init release. It is
available in Ubuntu 20.04 (Focal Fossa), and
Up! Any news here? Which is the blocker here?
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
Your team cloud-init Commiters is requested to review the proposed merge of
~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master.
_
Inline comment asking for clarification on AWS DHCP lease contents,
requirements for routing traffic to IMDS, DNS, and off-box, as with Azure.
Let's document what's needed; we may need to add secondary ips with a metric.
See
https://github.com/aws/ec2-net-utils/blob/master/ec2net-functions
F
I think Chad meant after our next SRU[1], which will begin shortly. I'd expect
this come in the SRU after the current planned one.
1. https://wiki.ubuntu.com/StableReleaseUpdates
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
Your team cloud-init commiters is
> Waiting on this change of behavior until after 19.2 upstream release
cloud-init 19.2 was released 17 July. Does this unblock this change being
applied?
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
Your team cloud-init commiters is requested to review the p
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
--
Your team cloud-init commiters
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master.
Commit message:
ec2: render secondary IPs on primary nic when present in metadata
Parse local-ipv4s and subnet-ipv4-cidr-block on EC2 metadata version
2018-09-24 to obtain secondary nic priv
Waiting on this change of behavior until after 19.2 upstream release
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:mas
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792
--
Your team cloud-init commiters
Review: Approve continuous-integration
PASSED: Continuous integration, rev:2ae7c7c3b3ee6522f31a4efc6b993e43e82c5bb9
https://jenkins.ubuntu.com/server/job/cloud-init-ci/765/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..9a5ed43 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -536,24 +536,43 @@ def convert_ec2_metadata_network_config(network_
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:047a654e9b7ca8dd8115aab2467c55f25ba312ca
https://jenkins.ubuntu.com/server/job/cloud-init-ci/762/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into
cloud-init:master has been updated.
Commit message changed to:
ec2: render secondary IPs on primary nic when present in metadata
Parse local-ipv4s and subnet-ipv4-cidr-block on EC2 metadata version
2018-09-24 to obtain
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into
cloud-init:master has been updated.
Commit message changed to:
ec2: render secondary IPs on primary nic when present in metadata
Parse local-ipv4s and subnet-ipv4-cidr-block on EC2 metadata version
2018-09-24 to obtain
Review: Approve continuous-integration
PASSED: Continuous integration, rev:db953566a9e6df91b4eaeebb813e45726136316c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/761/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:f6b0d9eb283917f4c2a5a5f863ad07c048346199
https://jenkins.ubuntu.com/server/job/cloud-init-ci/759/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..9a5ed43 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -536,24 +536,43 @@ def convert_ec2_metadata_network_config(network_
Thanks! A couple of follow-ups, and a couple of nits I missed first time
around.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..9a5ed43 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSour
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..aef5d80 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -536,24 +536,35 @@ def convert_ec2_metadata_network_config(network_
Overall, this looks good, thanks! I have a few inline comments/questions, but
the overall structure/logic seems sound to me.
(Looks like the CI failures are due to linting.)
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:a16796ed79fc4d58710fa018571011d1adefc032
https://jenkins.ubuntu.com/server/job/cloud-init-ci/757/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into
cloud-init:master has been updated.
Commit message changed to:
ec2: render secondary IPs on primary nic when present in metadata
Parse local-ipv4s and subnet-ipv4-cidr-block on EC2 metadata version
2018-09-24 to obtain
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master.
Commit message:
ec2: render secondary IPs on primary nic when present in metadata
Parse local-ipv4s and subnet-ipv4-cidr-block on EC2 metadata version
2018-09-24 to obtain secondary nic priv
23 matches
Mail list logo
