Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master
I didn't know about the freshport patches until you mentioned that in your previous comment. I'm not that familiar with FreeBSD. Anyway, I haven't see any PR with these patches, but some of them are actually already covered by branches. -- https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/366333 Your team cloud-init commiters is requested to review the proposed merge of ~goneri/cloud-init:build-on-freebsd into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master
sorry i somehow missed your answer. can not subscribe to this thread somehow. can you subscribe me as branch owner? it is ok to have a vanilla way to install the software. it just needs to be maintained. and independent of this: we should bring the freshport patches somehow upstream and update to a newer version there. maybe you have contact with the port maintainer already? -- https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/366333 Your team cloud-init commiters is requested to review the proposed merge of ~goneri/cloud-init:build-on-freebsd into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master
I use the script to quickly set-up my environment without depending on the port. I understand that the port is definitely a better solution most of the time, but it's also good to have a vanilla way to install the software. -- https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/366333 Your team cloud-init commiters is requested to review the proposed merge of ~goneri/cloud-init:build-on-freebsd into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master
i wonder if tools/build-on-freebsd could not be dropped completely as there is an official freshport in the meanwhile: https://www.freshports.org/net/cloud-init/ the port is version 18.3 and includes just some FreeBSD specific patches out of which i know some are 100% obsolete in the meanwhile. see https://svnweb.freebsd.org/ports/head/net/cloud-init/files/ instead of having this script i would rather have a closer work together with the port maintainer to get these FreeBSD patches upstream if still needed. or is there any good reason to still keep and maintain this build-on-freebsd script? if so i think we should make the script python2 and python3 compatible until we can drop python2 sometime in 2020. just my 2 cents ;-) -- https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/366333 Your team cloud-init commiters is requested to review the proposed merge of ~goneri/cloud-init:build-on-freebsd into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master
I use the following script to prepare my FreeBSD images, my freebsd branch comes with all the patches from my different branches: https://github.com/virt-lightning/freebsd-cloud-images Python3 is on my TODO list, with a lower priority. If you open a bug, you can affect it to me. -- https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/366333 Your team cloud-init commiters is requested to review the proposed merge of ~goneri/cloud-init:build-on-freebsd into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master
This looks like a reasonable set of changes to me; is there any good way for me to test it? (Perhaps in a container/public cloud?) Also, do we need to open a bug for converting this script to Python 3 in preparation for dropping Python 2 support from cloud-init[0]? [0] https://lists.launchpad.net/cloud-init/msg00170.html -- https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/366333 Your team cloud-init commiters is requested to review the proposed merge of ~goneri/cloud-init:build-on-freebsd into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
[Cloud-init-dev] [Merge] ~goneri/cloud-init:build-on-freebsd into cloud-init:master
Gonéri Le Bouder has proposed merging ~goneri/cloud-init:build-on-freebsd into
cloud-init:master.
Commit message:
freebsd: add chpasswd pkg in the image
cc_set_passwords.py depends on chpasswd binary.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/366333
--
Your team cloud-init commiters is requested to review the proposed merge of
~goneri/cloud-init:build-on-freebsd into cloud-init:master.
diff --git a/tools/build-on-freebsd b/tools/build-on-freebsd
index d23fde2..dc3b974 100755
--- a/tools/build-on-freebsd
+++ b/tools/build-on-freebsd
@@ -9,6 +9,7 @@ fail() { echo "FAILED:" "$@" 1>&2; exit 1; }
depschecked=/tmp/c-i.dependencieschecked
pkgs="
bash
+ chpasswd
dmidecode
e2fsprogs
py27-Jinja2
@@ -17,6 +18,7 @@ pkgs="
py27-configobj
py27-jsonpatch
py27-jsonpointer
+ py27-jsonschema
py27-oauthlib
py27-requests
py27-serial
@@ -28,12 +30,9 @@ pkgs="
[ -f "$depschecked" ] || pkg install ${pkgs} || fail "install packages"
touch $depschecked
-# Required but unavailable port/pkg: py27-jsonpatch py27-jsonpointer
-# Luckily, the install step will take care of this by installing it from pypi...
-
# Build the code and install in /usr/local/:
-python setup.py build
-python setup.py install -O1 --skip-build --prefix /usr/local/ --init-system sysvinit_freebsd
+python2.7 setup.py build
+python2.7 setup.py install -O1 --skip-build --prefix /usr/local/ --init-system sysvinit_freebsd
# Enable cloud-init in /etc/rc.conf:
sed -i.bak -e "/cloudinit_enable=.*/d" /etc/rc.conf
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
