[Cloud-init-dev] [Merge] ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master

2019-04-24 Thread Dan Watkins 
The proposal to merge ~liaoishere/cloud-init:sysconfig-bond-options into 
cloud-init:master has been updated.

Commit message changed to:

sysconfig: support more bonding options

Currently, only a few bonding parameters can be configured on
sysconfig systems. This patch aims to support more parameters
documented on the docs site.

For more details, see:
https://code.launchpad.net/~liaoishere/cloud-init/+git/cloud-init/+merge/366377
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Cloud-init-dev] [Merge] ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master

2019-04-24 Thread Dan Watkins 
I've just kicked off a CI run, the results will be reported in here once 
complete.
-- 
https://code.launchpad.net/~liaoishere/cloud-init/+git/cloud-init/+merge/366377
Your team cloud-init commiters is requested to review the proposed merge of 
~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Cloud-init-dev] [Merge] ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master

2019-04-24 Thread Liao Penghui 
Hi Ryan, I've added unit test related to bond config. I found that I can't find 
where can I see the CI test result on launchpad. Is there any triggered test 
runnning on lauchpad Merge Request?
-- 
https://code.launchpad.net/~liaoishere/cloud-init/+git/cloud-init/+merge/366377
Your team cloud-init commiters is requested to review the proposed merge of 
~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Cloud-init-dev] [Merge] ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master

2019-04-23 Thread Ryan Harper 
Thanks for looking at extending these options.

Could you look at the existing unittests for sysconfig bond rendering in  
tests/unittests/test_net.py and extend that with some of the additional
values.



-- 
https://code.launchpad.net/~liaoishere/cloud-init/+git/cloud-init/+merge/366377
Your team cloud-init commiters is requested to review the proposed merge of 
~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master.

___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp

[Cloud-init-dev] [Merge] ~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master

2019-04-23 Thread Liao Penghui 
Liao Penghui has proposed merging ~liaoishere/cloud-init:sysconfig-bond-options 
into cloud-init:master.

Commit message:
Support more bonding options for sysconfig system.
Currently, only a few bonding parameters can be configured on
sysconfig systems. This patch aims to support more parameters
documented on the docs site.

Requested reviews:
  cloud-init commiters (cloud-init-dev)

For more details, see:
https://code.launchpad.net/~liaoishere/cloud-init/+git/cloud-init/+merge/366377
-- 
Your team cloud-init commiters is requested to review the proposed merge of 
~liaoishere/cloud-init:sysconfig-bond-options into cloud-init:master.
diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
index a47da0a..be5dede 100644
--- a/cloudinit/net/sysconfig.py
+++ b/cloudinit/net/sysconfig.py
@@ -284,6 +284,18 @@ class Renderer(renderer.Renderer):
 ('bond_mode', "mode=%s"),
 ('bond_xmit_hash_policy', "xmit_hash_policy=%s"),
 ('bond_miimon', "miimon=%s"),
+('bond_min_links', "min_links=%s"),
+('bond_arp_interval', "arp_interval=%s"),
+('bond_arp_ip_target', "arp_ip_target=%s"),
+('bond_arp_validate', "arp_validate=%s"),
+('bond_ad_select', "ad_select=%s"),
+('bond_num_grat_arp', "num_grat_arp=%s"),
+('bond_downdelay', "downdelay=%s"),
+('bond_updelay', "updelay=%s"),
+('bond_lacp_rate', "lacp_rate=%s"),
+('bond_fail_over_mac', "fail_over_mac=%s"),
+('bond_primary', "primary=%s"),
+('bond_primary_reselect', "primary_reselect=%s"),
 ])
 
 bridge_opts_keys = tuple([
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help   : https://help.launchpad.net/ListHelp