Markus Schade has proposed merging ~lp-markusschade/cloud-init:hetznercloud_ds
into cloud-init:master.
Commit message:
Add missing dsname for Hetzner Cloud datasource
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~lp-markusschade/cl
Scott,
we enforce from our side a valid hostname in API/frontend. So yes, it should
always be present, but not a full FQDN (host.example.com) as the domain part
(example.com) may be missing.
We have also added some unit tests
--
https://code.launchpad.net/~lp-markusschade/cloud-init/+git/clo
Markus,
Thanks.
You answered all my questions except the one about local-hostname.
| I'm curious if this is ever *not* set.
| Specifically because we are looking to have cloud-init set the hostname
earlier.
| (https://pad.lv/1746455)
|
https://code.launchpad.net/~chad.smith/cloud-init/+git/clou
Adjustments to make use of context manager.
Docs location currently only provides public API doc, but will be expanded to
cover more. We just wanted to provide the URL upfront.
If it is okay, we would prefer to keep the helper functions separate to keep
the code clean and straightforward.
As t
Some small comments.
Unit tests and a few fixes and we'll be good.
Thanks.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceHetzner.py
> b/cloudinit/sources/DataSourceHetzner.py
> new file mode 100644
> index 000..5d63d0d
> --- /dev/null
> +++ b/cloudinit/sources/DataSourceHetzner.
Hi Scott,
thank you for your review.
We have refactored it using EphemeralIPv4Network and are working to add some
unit tests for the DS as well.
Also most of your other comments (not decoding userdata, unifying the URL, etc)
are also addressed.
--
https://code.launchpad.net/~lp-markusschad
This looks pretty good, but we need some unit test on it.
some comments inline.
I know it can be annoying when someone says "you should refactor this".
We can help you, but we just added the EphemeralIPv4Network with this use case
in mind, so it'd be good to use it.
Diff comments:
> diff --git
Markus Schade has proposed merging ~lp-markusschade/cloud-init:hetznercloud_ds
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~lp-markusschade/cloud-init/+git/cloud-init/+merge/338439
Add Hetzner Cloud DataSou
8 matches
Mail list logo