The proposal to merge ~powersj/cloud-init:cii-restructure-ssh into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/342010
--
Your team cloud-init commiters is requested to
Review: Approve continuous-integration
PASSED: Continuous integration, rev:bfbc0ea14deffa7239b22d9c43f02c47d878fdfc
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1130/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:2825748072db0f1c03dba1db5a2995eeda8d2dc5
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1127/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
FAILED:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:1fdf14ea023a095f4de928e3662c655509fe3ced
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1126/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
FAILED:
Couple nits on this approach Josh, then I think it looks good.
Diff comments:
> diff --git a/tests/cloud_tests/platforms/instances.py
> b/tests/cloud_tests/platforms/instances.py
> index 3bad021..3b2fe1c 100644
> --- a/tests/cloud_tests/platforms/instances.py
> +++
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:85743a40c7763aa47002e0e9d1c22eff60be8645
https://jenkins.ubuntu.com/server/job/cloud-init-ci/950/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Diff comments:
> diff --git a/tests/cloud_tests/platforms/instances.py
> b/tests/cloud_tests/platforms/instances.py
> index 3bad021..fa392b7 100644
> --- a/tests/cloud_tests/platforms/instances.py
> +++ b/tests/cloud_tests/platforms/instances.py
> @@ -98,21 +103,21 @@ class
Diff comments:
> diff --git a/tests/cloud_tests/platforms/instances.py
> b/tests/cloud_tests/platforms/instances.py
> index 3bad021..fa392b7 100644
> --- a/tests/cloud_tests/platforms/instances.py
> +++ b/tests/cloud_tests/platforms/instances.py
> @@ -98,21 +103,21 @@ class
Diff comments:
> diff --git a/tests/cloud_tests/platforms/instances.py
> b/tests/cloud_tests/platforms/instances.py
> index 3bad021..fa392b7 100644
> --- a/tests/cloud_tests/platforms/instances.py
> +++ b/tests/cloud_tests/platforms/instances.py
> @@ -87,7 +87,12 @@ class Instance(TargetBase):
The proposal to merge ~powersj/cloud-init:cii-restructure-ssh into
cloud-init:master has been updated.
Commit Message changed to:
tests: restructure SSH and initial connections
The SSH function was retrying and waiting for SSH for over an
hour when an SSH connection was failing to be
Review: Approve continuous-integration
PASSED: Continuous integration, rev:7a6f7eaadb29b81a92a005a2652f3b160f64c2b1
https://jenkins.ubuntu.com/server/job/cloud-init-ci/923/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Joshua Powers has proposed merging ~powersj/cloud-init:cii-restructure-ssh into
cloud-init:master.
Commit message:
tests: restructure SSH and initial connections
The SSH function was retrying and waiting for SSH for over an
hour when an SSH connection was failing to be established. This
reduces
12 matches
Mail list logo