Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

2017-03-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:4990a439de95e2641c912d08b969b2c8dc848245 https://jenkins.ubuntu.com/server/job/cloud-init-ci/192/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/192 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

2017-03-30 Thread Scott Moser
Diff comments: > diff --git a/doc/rtd/topics/network-config-format-eni.rst > b/doc/rtd/topics/network-config-format-eni.rst > new file mode 100644 > index 000..e4bcbe7 > --- /dev/null > +++ b/doc/rtd/topics/network-config-format-eni.rst > @@ -0,0 +1,14 @@ > +.. _network_config_eni: > + >

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

2017-03-30 Thread Ryan Harper
Thanks for the input; I'll update. Diff comments: > diff --git a/doc/rtd/topics/network-config-format-eni.rst > b/doc/rtd/topics/network-config-format-eni.rst > new file mode 100644 > index 000..e4bcbe7 > --- /dev/null > +++ b/doc/rtd/topics/network-config-format-eni.rst > @@ -0,0 +1,14 @@

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

2017-03-30 Thread Scott Moser
Ryan, this looks really good. you did a lot of sleuthing! there are some comments inline, i read mostly around the 'cloud-init' parts, i very lightly skimmed the v1 and v2 doc sections. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321397 Your team cloud init

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

2017-03-30 Thread Scott Moser
Ryan, this looks really good. you did a lot of sleuthing! there are some comments inline, i read mostly around the 'cloud-init' parts, i very lightly skimmed the v1 and v2 doc sections. Diff comments: > diff --git a/doc/rtd/topics/network-config-format-eni.rst >

[Cloud-init-dev] [Merge] ~raharper/cloud-init:network-config-doc into cloud-init:master

2017-03-29 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:network-config-doc into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/321397 doc: document network