Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-18 Thread Chad Smith
Diff comments: > diff --git a/tests/unittests/test_datasource/test_ec2.py > b/tests/unittests/test_datasource/test_ec2.py > new file mode 100644 > index 000..d7362c1 > --- /dev/null > +++ b/tests/unittests/test_datasource/test_ec2.py > @@ -0,0 +1,202 @@ > +# This file is part of cloud-init.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-18 Thread Chad Smith
Diff comments: > diff --git a/tests/unittests/test_datasource/test_ec2.py > b/tests/unittests/test_datasource/test_ec2.py > new file mode 100644 > index 000..d7362c1 > --- /dev/null > +++ b/tests/unittests/test_datasource/test_ec2.py > @@ -0,0 +1,202 @@ > +# This file is part of cloud-init.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-18 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:7181d66d3693919615a884f4e9f43aa14b422244 https://jenkins.ubuntu.com/server/job/cloud-init-ci/49/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu L

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-18 Thread Scott Moser
i cleaned up that register_helper a bit, thanks for the review, Ryan. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327534 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master. _

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-17 Thread Scott Moser
Diff comments: > diff --git a/tests/unittests/test_datasource/test_ec2.py > b/tests/unittests/test_datasource/test_ec2.py > new file mode 100644 > index 000..a5485ff > --- /dev/null > +++ b/tests/unittests/test_datasource/test_ec2.py > @@ -0,0 +1,201 @@ > +# This file is part of cloud-init.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-17 Thread Ryan Harper
Inline comment below Diff comments: > diff --git a/tests/unittests/test_datasource/test_ec2.py > b/tests/unittests/test_datasource/test_ec2.py > new file mode 100644 > index 000..a5485ff > --- /dev/null > +++ b/tests/unittests/test_datasource/test_ec2.py > @@ -0,0 +1,201 @@ > +# This file is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:fe6f267f52e3532693df0e7684012cd8b58792cc https://jenkins.ubuntu.com/server/job/cloud-init-ci/43/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu L

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-17 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master. Commit message: tests: Add initial tests for EC2 and improve a docstring. EC2 was the original, but this adds some initial tests for that datasource. Also updates a docstring for an internal met

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master

2017-07-17 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master has been updated. Commit Message changed to: tests: Add initial tests for EC2 and improve a docstring. EC2 was the original, but this adds some initial tests for that datasource. Also updates a docstring f