The proposal to merge ~smoser/cloud-init:doc-boot-stages into cloud-init:master
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/310386
--
Your team cloud init development team is requested to review
I'm going to go ahead and merge this as I believe it is an important
improvement and we can make further improvements to it as we go.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/310386
Your team cloud init development team is requested to review the proposed merge
of
thanks for review comments. i've updated.
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..30df52e
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,124 @@
> +
> +Boot Stages
> +
> +In order
Thanks for adding this! I have some comments, questions, and typo fixes.
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..30df52e
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,124 @@
> +
> +Boot Stag
On Wed, 9 Nov 2016, Ryan Harper wrote:
>
>
> Diff comments:
>
> > diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
>
> Either lowercase Generator, or Upper case the rest?
Upper cased in both places (title and summary).
>
> > + * A file exists: ``/etc/cloud/cloud-init.disabled``
> >
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..51e4815
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,121 @@
> +
> +Boot Stages
> +
> +In order to be able to provide the functionality t
updated a bit.
tried to incorporate your suggestions.
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..693a091
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,109 @@
> +
> +Boot Stages
> +
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> new file mode 100644
> index 000..693a091
> --- /dev/null
> +++ b/doc/rtd/topics/boot.rst
> @@ -0,0 +1,109 @@
> +
> +Boot Stages
> +
> +In order to be able to provide the functionality t
Scott Moser has proposed merging ~smoser/cloud-init:doc-boot-stages into
cloud-init:master.
Commit message:
doc: Add documentation on stages of boot.
This adds long overdue documentation on stages that cloud-init
runs during boot.
Requested reviews:
cloud init development team (cloud-init-dev
The proposal to merge ~smoser/cloud-init:doc-boot-stages into cloud-init:master
has been updated.
Commit Message changed to:
doc: Add documentation on stages of boot.
This adds long overdue documentation on stages that cloud-init
runs during boot.
For more details, see:
https://code.launchpad.
10 matches
Mail list logo