The proposal to merge ~smoser/cloud-init:feature/ds-identify-test into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/323059
--
Your team cloud init development team is requested
Review: Approve continuous-integration
PASSED: Continuous integration, rev:8a0b5287cdb67505dfde5223d3a73df7723972df
https://jenkins.ubuntu.com/server/job/cloud-init-ci/319/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/319
SUCCESS:
htt
Review: Approve
+1 thanks for the rework + docstrings.
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..de645eb
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,295 @@
> +#
Review: Approve continuous-integration
PASSED: Continuous integration, rev:3dd81be5b30fd69a6bdc2ad4ddbfe1ca780b952e
https://jenkins.ubuntu.com/server/job/cloud-init-ci/318/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/318
SUCCESS:
htt
Review: Approve continuous-integration
PASSED: Continuous integration, rev:00487bb8a7c15a39cb3e1af19d7d947acc9b0535
https://jenkins.ubuntu.com/server/job/cloud-init-ci/317/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/317
SUCCESS:
htt
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:35f72db8276632e1f51ccb4ffecd33ef4dd9f6d2
https://jenkins.ubuntu.com/server/job/cloud-init-ci/316/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/316/console
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:0d1767007387838b5f80dec28673d8cc74206bf9
https://jenkins.ubuntu.com/server/job/cloud-init-ci/315/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/315/console
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:6e3efe9fd7af930acaaf402a1eefeedd02f426ad
https://jenkins.ubuntu.com/server/job/cloud-init-ci/314/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/314/console
Review: Approve continuous-integration
PASSED: Continuous integration, rev:d648260b81c3bb1d2567bd5b7a0f2aa6674e1e73
https://jenkins.ubuntu.com/server/job/cloud-init-ci/313/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/313
SUCCESS:
htt
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..00f91f3
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,275 @@
> +# This file is part of cloud-init. See LICENSE file for li
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..00f91f3
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,275 @@
> +# This file is part of cloud-init. See LICENSE file for li
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..00f91f3
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,275 @@
> +# This file is part of cloud-init. See LICENSE file for li
Initial comments added
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..00f91f3
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,275 @@
> +# This file is part of cloud-init. S
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:b78cc5e73241f31c18b2f599df953035f6cb8da2
https://jenkins.ubuntu.com/server/job/cloud-init-ci/312/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/312
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:7fe5047b2d8dc54fa9c24a2c55a92bcb778ab71d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/311/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/311/console
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/310/
Executed test runs:
ABORTED:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/310/console
ABORTED:
https://jenkins.ubuntu.com/ser
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:9ca73e761fcb069a86cc69534eeb88fd2c440389
https://jenkins.ubuntu.com/server/job/cloud-init-ci/309/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/309/console
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:df554469507e43d7fed6e9e9868f95d73d2b15fe
https://jenkins.ubuntu.com/server/job/cloud-init-ci/308/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/308
SUCCESS:
with respect to the infrastructure to test this being elsewhere... most of it
is specific to ds-identify, so I dont think it makes a lot of sense to hide it
all away from the testing of ds-identify.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/323059
Your team cloud i
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..00f91f3
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,275 @@
> +# This file is part of cloud-init. See LICENSE file for li
This looks really good.
Would you be opposed to putting the infrastructure in one of the helper files
and have only the inputs/unittests in the test_dsidentify class?
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100
The proposal to merge ~smoser/cloud-init:feature/ds-identify-test into
cloud-init:master has been updated.
Commit Message changed to:
Add unit tests for ds-identify, fix Ec2 bug found.
This adds several unit tests for ds-identify, and fixes a bug
in Ec2 detection that I found while writing thes
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:ee51740e55f20b87e3f295ddb3249e6b1dbac94a
No commit message was specified in the merge proposal. Click on the following
link and set the commit message (if you want a jenkins rebuild you need to
trigger it yourself):
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:9e2de035ab51831335f5c1c9b21058a6b5875c74
No commit message was specified in the merge proposal. Click on the following
link and set the commit message (if you want a jenkins rebuild you need to
trigger it yourself):
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:426d9c451b5b8fa5df77a7e49b39647df66f3096
No commit message was specified in the merge proposal. Click on the following
link and set the commit message (if you want a jenkins rebuild you need to
trigger it yourself):
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:c871fa26490bbd96faa596b2ce1638539a659764
No commit message was specified in the merge proposal. Click on the following
link and set the commit message (if you want a jenkins rebuild you need to
trigger it yourself):
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:cbe6651ab03566b4f1957d9d73841e3b37a0a6f1
No commit message was specified in the merge proposal. Click on the following
link and set the commit message (if you want a jenkins rebuild you need to
trigger it yourself):
Scott Moser has proposed merging ~smoser/cloud-init:feature/ds-identify-test
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/323059
--
Your team cloud init devel
28 matches
Mail list logo
