Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.
___
Mailing
The proposal to merge ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
--
Your team cloud-init commiters is requested to review the
The proposal to merge ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
--
Your team cloud-init commiters is requested to
Review: Approve continuous-integration
PASSED: Continuous integration, rev:8db9cd3f44c3848574a7e690a53bb3d8962fb9f6
https://jenkins.ubuntu.com/server/job/cloud-init-ci/428/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/428
SUCCESS:
Review: Approve
+1 thanks for the discussion.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.
Review: Approve continuous-integration
PASSED: Continuous integration, rev:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/427/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/427
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:3ae4ef707d48a9ba39a26a8d3dee2832ff671844
https://jenkins.ubuntu.com/server/job/cloud-init-ci/426/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/426/console
Thanks for the clarification and background on the datasource list ordering.
And I see your point on git log (as that's how I determined what the intent of
the var was in the first place).
+1 on the separate mocked unit test for _is_aliyun() to exercise the interface
we are actually
Review: Approve continuous-integration
PASSED: Continuous integration, rev:1f7e87c2996d6a3af23e0226cc5d64b0a9106584
https://jenkins.ubuntu.com/server/job/cloud-init-ci/425/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/425
SUCCESS:
OK, So i thought some more, and with regard to the order of the two
'datasource_lists'.
Some points to think about
a.) If EC2's 'strict_id' is set to "warn" or "false", then the Ec2 datasource
will poll and time out very annoyingly. "true" is the default setting in
trunk, but not yet in xenial.
Scott Moser has proposed merging ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master.
Commit message:
AliYun: Enable platform identification and enable by default.
AliYun cloud platform is now identifying themselves by setting the dmi
product id to the well known value "Alibaba
> Thanks for this good work approved pending your decision on the following
> comments.
>
> My comments will be made per the consolidated visual diff @
> http://paste.ubuntu.com/24716726/
>
> line 49 in the above diff:
> Since order of datasources matters to determine which datasource is
Review: Approve
Thanks for this good work approved pending your decision on the following
comments.
My comments will be made per the consolidated visual diff @
http://paste.ubuntu.com/24716726/
line 49 in the above diff:
Since order of datasources matters to determine which datasource is
Review: Approve
Hi,smoser
I review this code change at
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
that good ,and test it in our AliYun platform ,it's also work fine .thanks
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324625
Review: Approve continuous-integration
PASSED: Continuous integration, rev:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/419/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/419
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:2722a2f7d7f989826f3506ff135cfedbb45da8dc
https://jenkins.ubuntu.com/server/job/cloud-init-ci/415/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/415/console
Scott Moser has proposed merging ~smoser/cloud-init:feature/enable-aliyun into
cloud-init:master.
Commit message:
AliYun: Enable platform identification and enable by default.
AliYun cloud platform is now identifying themselves by setting the dmi
product id to the well known value "Alibaba
17 matches
Mail list logo
