The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
--
Your team cloud-init commiters is requested to review th
The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
--
Your team cloud-init commiters is requested to rev
+1 on that suggestion
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/freebsd-variant into cloud-init:master.
___
Mai
actually, on further thought, lets leve suse out right now.
there is a 'sles' distro (cloudinit/distros/sles.py) but per
https://github.com/hpcugent/easybuild/wiki/OS_flavor_name_version
we would see 'suse' as the dist.
not sure what the right change is.
i didn't *change* any behavior here i do
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index 415ca37..817d347 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -598,37 +598,29 @@ def get_cfg_option_int(yobj, key, default=0):
> def system_info():
> info = {
> 'platform': platform.plat
Looks pretty good, I'd like to see other unit tests specifically looking at
return vals from util.system_info() but that can come in a later branch. Minor
nits but code looks good.
I have no bsd system available otherwise I'd check it out with a couple of runs.
Diff comments:
> diff --git a/clo
Review: Approve continuous-integration
PASSED: Continuous integration, rev:c6af5b9a1648c208c82b3a2704668391abadd8ab
https://jenkins.ubuntu.com/server/job/cloud-init-ci/539/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/539
SUCCESS:
htt
The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Commit Message changed to:
freebsd: Make freebsd a variant, fix unittests and tools/build-on-freebsd.
- Simplify the logic of 'variant' in util.system_info
much of the data from
http
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:2151902fa7a5cba7e420a14f51c851ee06d83d30
https://jenkins.ubuntu.com/server/job/cloud-init-ci/538/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/538/console
this replaces some of the changes from
https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feat
Scott Moser has proposed merging ~smoser/cloud-init:feature/freebsd-variant
into cloud-init:master.
Commit message:
fixes for freebsd
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
--
11 matches
Mail list logo
