Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-25 Thread Scott Moser
please re-review. i think i've addressed all comments. Diff comments: > diff --git a/tests/unittests/test_distros/test_debian.py > b/tests/unittests/test_distros/test_debian.py > new file mode 100644 > index 000..bd7721c > --- /dev/null > +++ b/tests/unittests/test_distros/test_debian.py

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-21 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/pregen-locale into cloud-init:master has been updated. Commit Message changed to: locale: Do not re-run locale-gen if provided locale is system default. If the system configure default in /etc/default/locale is set to the same value that is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:9dd9bb47b48c80ea0b1f4a1bf78e44ee81c14c97 https://jenkins.ubuntu.com/server/job/cloud-init-ci/77/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev: https://jenkins.ubuntu.com/server/job/cloud-init-ci/75/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu LTS: Integration SUCCESS: CentOS 6 &

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-21 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2c7f87273d3f0ada0a22984067dae9e3ea6958e7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/74/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-21 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:8faec3079c58a4db6cbac5cf3ecd8e319fe5509b https://jenkins.ubuntu.com/server/job/cloud-init-ci/73/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-20 Thread Scott Moser
chad thanks for review. i'll get these fixes. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/pregen-locale into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-20 Thread Chad Smith
Diff comments: > diff --git a/tests/unittests/test_distros/test_debian.py > b/tests/unittests/test_distros/test_debian.py > new file mode 100644 > index 000..bd7721c > --- /dev/null > +++ b/tests/unittests/test_distros/test_debian.py > @@ -0,0 +1,70 @@ > +# This file is part of cloud-init.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-20 Thread Chad Smith
Diff comments: > diff --git a/tests/unittests/test_distros/test_debian.py > b/tests/unittests/test_distros/test_debian.py > new file mode 100644 > index 000..bd7721c > --- /dev/null > +++ b/tests/unittests/test_distros/test_debian.py > @@ -0,0 +1,70 @@ > +# This file is part of cloud-init.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-19 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8b220d36d04538e37de3e7a188dffce3ac67c55d https://jenkins.ubuntu.com/server/job/cloud-init-ci/56/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-18 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:724ef696e776e6937b8e75a41da35607bede7a6a https://jenkins.ubuntu.com/server/job/cloud-init-ci/50/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-18 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/pregen-locale into cloud-init:master has been updated. Commit Message changed to: locale: Do not re-run locale-gen if provided locale is system default. If the system configure default in /etc/default/locale is set to the same value that is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:2a44d6f5d36db7c322891f590752e38069b75b08 https://jenkins.ubuntu.com/server/job/cloud-init-ci/47/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-17 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:9a607ecd6efecd189a5dd3dd1b50aece02b6d281 https://jenkins.ubuntu.com/server/job/cloud-init-ci/42/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-17 Thread Scott Moser
This is a update to https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/325406 with the suggestions I had to that MP fixed (added unit tests) -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532 Your team cloud-init commiters is requested to review

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

2017-07-17 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:feature/pregen-locale into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532 -- Your team cloud-init commiters is