Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:0f39683b69929dff3edf6ee078af31b6424e0dff https://jenkins.ubuntu.com/server/job/cloud-init-ci/1139/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-16 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:e8df99682baa220cdba19e3b46fc06badcbe9c19 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1133/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev: https://jenkins.ubuntu.com/server/job/cloud-init-ci/1131/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu LTS: Integration SUCCESS: MAAS

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-16 Thread Scott Moser
i fixed the issue with the test. it was just a bug in tools/run-container. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345627 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/run-container into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-16 Thread Joshua Powers
I ran through a few runs with Debian and Fedora, looked good comments below. Thanks for making the deprecation message and existing script. Not sure why CI failed, but I'll look once it is up and running again. Diff comments: > diff --git a/tools/run-container b/tools/run-container > new file

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-15 Thread Joshua Powers
Before looking at this, one thing to note is that CI will obviously need to be updated before this is landed and unless someone rebases re-runs will fail -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345627 Your team cloud-init commiters is requested to review the

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:85ada88e35930d2ab2cbb9a7a436bcfd992f9a71 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1128/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-container into cloud-init:master

2018-05-15 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:feature/run-container into cloud-init:master. Commit message: tools/run-container: replace tools/run-centos with more generic. tools/run-container is like tools/run-centos, but currently supports the following images from lxc-images