[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-21 Thread Joshua Harlow
The proposal to merge lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812 -- Your team cloud init development team is

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-20 Thread Scott Moser
My only real comment is that I thikn i'd take 'get_metadata' out of 'get_data'. You can either move it to a stand alone method or a class method. either way, moving it out allows to easier patch it for testing. --