Hi Eduardo,
Looking at this again.
Could you please sign the contributors agreement please feel free to contact me
if you have any questions (freenode 'smoser')
http://www.ubuntu.com/legal/contributors
Second, i think the check for /run/oc-metadata.cache is probably ok, as long as
that is crea
To check if you are on scaleway:
$ test -f /run/oc-metadata.cache; echo $?
0
This file is populated when something fetches the api metadata.
Our initrd (https://github.com/scaleway/initrd/tree/master/Linux) will create
this file on each boots automatically.
--
https://code.launchpad.ne
two nitpicks. but this looks good other than failing tests.
b
Diff comments:
> === added file 'cloudinit/sources/DataSourceScaleway.py'
> --- cloudinit/sources/DataSourceScaleway.py 1970-01-01 00:00:00 +
> +++ cloudinit/sources/DataSourceScaleway.py 2015-10-28 09:51:17 +
> @@ -0,0 +1
Great, thanks :) Waiting for your review then.
--
https://code.launchpad.net/~edouardb/cloud-init/scaleway-datasource/+merge/274861
Your team cloud init development team is requested to review the proposed merge
of lp:~edouardb/cloud-init/scaleway-datasource into lp:cloud-init.
_
Julien,
Thanks.
for 'd', sure you can add vendor-data later.
if its not in the cloud provider anyway, not much use for cluod-init to support
it.
The big issue is just 'b'. We can't enable by default without solid way of
knowing that we should hit a http source that might hang indefinitely.
I'l
Hi,
a) Done
b) Done. Unfortunately, there's no way to ensure you're running on Scaleway
without hitting a network resource
c) Done
d) Indeed. Can we consider adding them later?
--
https://code.launchpad.net/~edouardb/cloud-init/scaleway-datasource/+merge/274861
Your team cloud init development t
Hey,
This looks well done, thanks.
A couple comments
a.) we'll need some unit tests to ensure we dont inadvertently break this.
b.) is there some way (anyway) we can detect if we're on scaleway? As it is
right now, it looks like we're just going to block and retry for the
availability of the M
Unlike other providers, the Scaleway user-data API is restricted to privileged
ports (< 1024) to prevent non-root users accessing to it.
We added a new parameter to readurl to specify the requests session object, to
bind on a specific port.
--
https://code.launchpad.net/~edouardb/cloud-init/sca
edouardb has proposed merging lp:~edouardb/cloud-init/scaleway-datasource into
lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~edouardb/cloud-init/scaleway-datasource/+merge/274861
Add Datasource for Scaleway's
9 matches
Mail list logo
