Agreed on uptime, I guess we can keep the current impl, although I do wonder
what happens if ctypes fails to load the library, perhaps some exception
handled is useful around that?
--
https://code.launchpad.net/~harm-o/cloud-init/freebsd/+merge/198130
Your team cloud init development team is req
> Great start!
Thanks :)
I've taken your comments plus some notes from #cloud-init and did some
additions and changes.
> - wow, didn't know uptime had to be done with ctypes, is there no other way?
> is the `uptime` command pretty standard? for the logexc(LOG, "Unable to read
> uptime") can we a
> having 2 projects (one for windows + bsd) and one
> for linux (or linux like, fedora, ubuntu, rhel...) doesn't seem to make sense.
+1
I haven't tried this patch yet, but as a private cloud operator with linux,
freebsd and windows running on it I'd like to strongly endorse having a single
code
> https://github.com/pellaeon/bsd-cloudinit
>
> This may have more features from which to merge as well. It doesn't do
> config-drive AFAIK, but it might be useful?
That's a different version of cloudinit that isn't this version, but a
derivative that the windows folks created instead of gettin
https://github.com/pellaeon/bsd-cloudinit
This may have more features from which to merge as well. It doesn't do
config-drive AFAIK, but it might be useful?
--
https://code.launchpad.net/~harm-o/cloud-init/freebsd/+merge/198130
Your team cloud init development team is requested to review the pr
- for disk selections, probably easier to parse "sysctl kern.disks" instead of
trolling around in /dev and assuming that disk names (even though this is
probably fine) will allways be virt-io device names. e.g. for disk in `sysctl
kern.disks`; do diskinfo $disk; done
--
https://code.launchp
Great start!
Some initial comments :-)
givecmdline()
- can this function be in the distro object itself??
- can we use signal.SIG_DFL instead of just 0 (using the constant makes it so
people can lookup that on websites, and understand it a little easier)
- sys.platform -> util.system_info(
Scott Moser has proposed merging lp:~harm-o/cloud-init/freebsd into
lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~harm-o/cloud-init/freebsd/+merge/198130
initial freebsd support.
--
https://code.launchpad.ne
8 matches
Mail list logo
