i added a test of the _write_network fallback in the fix for 1602373 (revno
1255 on trunk).
and pulled that in here.
going to merge this in now.
--
https://code.launchpad.net/~smoser/cloud-init/trunk.net-improve-lo-dns/+merge/298035
Your team cloud init development team is requested to review
Looks good. Could we add unittests for distro using apply_network, including
one without a _write_network so we can test that fallback logic?
Diff comments:
>
> === modified file 'tests/unittests/test_net.py'
> --- tests/unittests/test_net.py 2016-06-15 23:11:24 +
> +++
> - use arrays for each 'section' rather than content += . This allows better
> separation of the sections and also will perform better as long strings
> with += are slow.
+1 for better separation. I don't think there is significant difference:
For an 100-line eni (that's rather high for
passes tox and the 3 added tests now.
The tests are somewhat brittle as they expect exactly rendered ENI content for
the provided network yaml.
--
https://code.launchpad.net/~smoser/cloud-init/trunk.net-improve-lo-dns/+merge/298035
Your team cloud init development team is requested to review
The proposal to merge lp:~smoser/cloud-init/trunk.net-improve-lo-dns into
lp:cloud-init has been updated.
Commit Message changed to:
improvements to eni rendering
Some improvements here, and some bug fixes.
- bring curtin revno 394's change to support post-up for interface aliases.
- sort
The proposal to merge lp:~smoser/cloud-init/trunk.net-improve-lo-dns into
lp:cloud-init has been updated.
Commit Message changed to:
improvements to eni rendering
Some improvements here, and some bug fixes.
- bring curtin revno 394's change to support post-up for interface aliases.
- sort
The proposal to merge lp:~smoser/cloud-init/trunk.net-improve-lo-dns into
lp:cloud-init has been updated.
Commit Message changed to:
improvements to eni rendering
Some improvements here, and some bug fixes.
- bring curtin revno 394's change to support post-up for interface aliases.
- sort
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.net-improve-lo-dns
into lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/trunk.net-improve-lo-dns/+merge/298035
--
Your team cloud
8 matches
Mail list logo
