The proposal to merge ~smoser/cloud-init:cleanup/ec2-console-as-bytes into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336366
--
Your team cloud-init commiters is requested to
Review: Approve continuous-integration
PASSED: Continuous integration, rev:4bcbc7bd9dea686a62576b28bc8b854a992c3221
https://jenkins.ubuntu.com/server/job/cloud-init-ci/726/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~smoser/cloud-init:fix/subp-exception-with-bytes into
cloud-init:master has been updated.
Commit Message changed to:
subp: make ProcessExecutionError have expected types in stderr, stdout.
When subp raised a ProcessExecutionError, that exception's stderr and
stdout might
unittest? comment in line.
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index e42498d..779d2b2 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -1829,58 +1835,60 @@ def subp(args, data=None, rcs=None, env=None,
> capture=True, shell=False,
> env
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:153bf2f2f56ced694f00686e00059508abdac340
https://jenkins.ubuntu.com/server/job/cloud-init-ci/719/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:fc224195ce0ba56f3cc95981106e25510c7bce39
https://jenkins.ubuntu.com/server/job/cloud-init-ci/721/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Add a comment that you switched to using /bin/sh instead of bash in several
scripts. Some comments inline.
Diff comments:
> diff --git a/tests/cloud_tests/platforms/lxd/instance.py
> b/tests/cloud_tests/platforms/lxd/instance.py
> index 0d697c0..e9b76a6 100644
> ---
Florian Grignon has proposed merging ~floriangrignon/cloud-init:log-typo into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~floriangrignon/cloud-init/+git/cloud-init/+merge/336501
Fixed typo double word 'for'
The proposal to merge ~smoser/cloud-init:fix/ntp-test-no-dns into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336458
--
Your team cloud-init commiters is requested to review
Scott Moser has proposed merging
~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master.
Commit message:
subp: make ProcessExecutionError have expected types in stderr, stdout.
When subp raised a ProcessExecutionError, that exception's stderr and
stdout might end up being the
Scott Moser has proposed merging
~smoser/cloud-init:cleanup/test-more-files-collect into cloud-init:master.
Commit message:
tests: Collect script output as binary, collect systemd journal, fix lxd.
This adds collection a gzip compressed systemd journal on systemd systems.
The file can later be
added unit test, updated commit message.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336497
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master.
Review: Approve continuous-integration
PASSED: Continuous integration, rev:08639703c83e19242059c2d73df373a05e89746a
https://jenkins.ubuntu.com/server/job/cloud-init-ci/720/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve
LGTM simply removes the dns lookup as:
ubuntu@wind:~$ ntpq -p -w
remote refid st t when poll reach delay offset jitter
==
maas.maas 91.189.91.1573 u2 641
The proposal to merge ~smoser/cloud-init:fix/ntp-test-no-dns into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336458
--
Your team cloud-init commiters is requested to review the
Diff comments:
> diff --git a/tests/cloud_tests/platforms/lxd/instance.py
> b/tests/cloud_tests/platforms/lxd/instance.py
> index 0d697c0..e9b76a6 100644
> --- a/tests/cloud_tests/platforms/lxd/instance.py
> +++ b/tests/cloud_tests/platforms/lxd/instance.py
> @@ -29,6 +31,7 @@ class
Review: Approve continuous-integration
PASSED: Continuous integration, rev:1708c6f72fe09fe8cc3511b45889fe35bf4ac734
https://jenkins.ubuntu.com/server/job/cloud-init-ci/722/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~smoser/cloud-init:fix/ntp-test-no-dns into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336458
--
Your team cloud-init commiters is requested to review the
The proposal to merge ~smoser/cloud-init:cleanup/ec2-console-as-bytes into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336366
--
Your team cloud-init commiters is requested
Review: Approve continuous-integration
PASSED: Continuous integration, rev:b9a418a6795730bb7b88f1273d12ab5cafa29cc6
https://jenkins.ubuntu.com/server/job/cloud-init-ci/724/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~smoser/cloud-init:cleanup/test-more-files-collect into
cloud-init:master has been updated.
Commit Message changed to:
tests: Collect script output as binary, collect systemd journal, fix lxd.
This adds collection a gzip compressed systemd journal on systemd systems.
The
The proposal to merge ~smoser/cloud-init:fix/ntp-test-no-dns into
cloud-init:master has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336458
--
Your team cloud-init commiters is requested to review the
22 matches
Mail list logo
