The proposal to merge ~chad.smith/cloud-init:ubuntu/bionic into
cloud-init:ubuntu/bionic has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/356897
--
Your team cloud-init commiters is requested
thoughts?
Diff comments:
> diff --git a/debian/changelog b/debian/changelog
> index 2bb9520..d83e08b 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,10 @@
> +cloud-init (18.4-0ubuntu1~18.04.2) bionic-proposed; urgency=medium
can you change that to be 'bionic' not
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index 39391d0..11b4ba5 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -207,7 +207,9 @@ BUILTIN_DS_CONFIG = {
> },
>
The proposal to merge
~chad.smith/cloud-init:feature/azure-disable-imds-networking into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/356989
--
Your team cloud-init
The proposal to merge
~chad.smith/cloud-init:feature/azure-disable-imds-networking into
cloud-init:master has been updated.
Commit message changed to:
azure: Add apply_network_config option to disable network from IMDS
Azure generates network configuration from the IMDS service and removes
Chad Smith has proposed merging
~chad.smith/cloud-init:feature/azure-disable-imds-networking into
cloud-init:master.
Commit message:
azure: Add apply_network_config option to disable network from IMDS
Azure generates network configuration from the IMDS service and removes
any preexisting
Review: Approve continuous-integration
PASSED: Continuous integration, rev:c8efde583fa58b2b1d3f8f5e32d70110bc6df6d8
https://jenkins.ubuntu.com/server/job/cloud-init-ci/400/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge
~chad.smith/cloud-init:feature/azure-disable-imds-networking into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/356989
--
Your team cloud-init commiters
Rejecting as we'll really just fix cloud-init query to look fallback to the
original instance-data.json if instance-data-sensitive.json doesn't exist and
print a sensible warning message.
Diff comments:
> diff --git a/debian/cloud-init.postinst b/debian/cloud-init.postinst
> index
> Minor comment, but it isn't Xenial-only, but rather, Xenial and older; While
> we've not SRU'd to trusty I think it's worth updating to comment locations to
> indicate that this is relevant for Ubuntu releases which include ifupdown.
Thanks Ryan fixed.
--
Review: Approve continuous-integration
PASSED: Continuous integration, rev:928dab8e3f7fdea3f7b6e233ee67d9e581c4a71c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/401/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:15a75ea17652fe825cc365aa58f1a85135ec0dfe
https://jenkins.ubuntu.com/server/job/cloud-init-ci/402/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
inline comments.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index 39391d0..11b4ba5 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -207,7 +207,9 @@ BUILTIN_DS_CONFIG = {
>
Minor comment, but it isn't Xenial-only, but rather, Xenial and older; While
we've not SRU'd to trusty I think it's worth updating to comment locations to
indicate that this is relevant for Ubuntu releases which include ifupdown.
--
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index 39391d0..2a6d5b1 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -619,7 +622,14 @@ class
* State: Failed to build
* Recipe: cloud-init-dev/cloud-init-daily-xenial
* Archive: ~cloud-init-dev/ubuntu/daily
* Distroseries: xenial
* Duration: 2 minutes
* Build Log:
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/1973128/+files/buildlog.txt.gz
* Upload Log:
16 matches
Mail list logo
