Re: [Cloud-init-dev] [Merge] ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master

2019-02-28 Thread Ryan Harper
Hi, Thank you for contributing to cloud-init. To contribute, you must sign the Canonical Contributor License Agreement (CLA) [1]. If you have already signed it as an individual, your Launchpad user will be listed in the contributor-agreement-canonical launchpad group [2]. Unfortunately there is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/openssl-manager-no-cleanup into cloud-init:master

2019-02-28 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:827e39148ba52989eea3bad5568148bfdbe63474 https://jenkins.ubuntu.com/server/job/cloud-init-ci/605/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master

2019-02-28 Thread kstieger
Hi Ryan, I signed the Agreement a few minutes ago. Don't know how long it takes until I am listed on the contributor list. Thank you for testing and verifying my change. Greetings, Kurt On Thu, 28 Feb 2019 at 18:54 Ryan Harper wrote: > Hi, > Thank you for contributing to cloud-init. > > To

Re: [Cloud-init-dev] [Merge] ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master

2019-02-28 Thread Ryan Harper
Thanks. I've added a unittest for this scenario, if you'd like to apply that to your branch and update. http://paste.ubuntu.com/p/xGH5CgWFGM/ After you do, I'll have our CI run against this and if it checks out OK, and LP has updated your CLA status, we can accept. Thanks again for the

Re: [Cloud-init-dev] [Merge] ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master

2019-02-28 Thread kstieger
Thanks. Patch already applied and committed. /Kurt On Thu, 28 Feb 2019 at 21:04 Ryan Harper wrote: > Thanks. > > I've added a unittest for this scenario, if you'd like to apply that to > your branch and update. > > http://paste.ubuntu.com/p/xGH5CgWFGM/ > > After you do, I'll have our CI run

[Cloud-init-dev] [Merge] ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master

2019-02-28 Thread Ryan Harper
The proposal to merge ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master has been updated. Commit message changed to: net: append type:dhcp[46] only if dhcp[46] is True in v2 netconfig When providing

[Cloud-init-dev] [Merge] ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master

2019-02-28 Thread Ryan Harper
The proposal to merge ~kurt-easygo/cloud-init:fix-network-state-dhcp into cloud-init:master has been updated. Description changed to: For more details, see: https://code.launchpad.net/~kurt-easygo/cloud-init/+git/cloud-init/+merge/363732 -- Your team cloud-init commiters is requested to