Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Ryan Harper
One inline question. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index f3cec79..fa15b96 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -272,25 +273,30 @@ def generate_fallback_config(blacklist_drivers=None, >

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master has been updated. Commit message changed to: azure: provide fallback network config v2 for fallback nic To enable Azure to send network v2, net.generate_fallback_config now generates network config

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master has been updated. Commit message changed to: azure/net: generate_fallback_nic emits network v2 config instead of v1 To enable Azure to send network v2, net.generate_fallback_config now generates

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master has been updated. Commit message changed to: azure/net: generate_fallback_nic emits network v2 config instead of v1 The function generate_fallback_config is used by Azure by default when not

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master has been updated. Commit message changed to: azure/net: generate_fallback_config emits network config v2 To enable Azure to send network v2, net.generate_fallback_config now generates network config

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master

2019-08-06 Thread Ryan Harper
One question, otherwise happy to see the doc update. Diff comments: > diff --git a/cloudinit/config/cc_set_passwords.py > b/cloudinit/config/cc_set_passwords.py > index 4585e4d..10d68ea 100755 > --- a/cloudinit/config/cc_set_passwords.py > +++ b/cloudinit/config/cc_set_passwords.py > @@ -9,27

Re: [Cloud-init-dev] [Merge] ('~chad.smith/cloud-init', ':', 'feature/azure-to-network-v2') into ('cloud-init', ':', 'master')

2019-08-06 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:9af66a67ecc80685544fd0847884ab7ea6a5d644 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1028/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py > index 0ca576b..c0c415d 100644 > --- a/cloudinit/net/network_state.py > +++ b/cloudinit/net/network_state.py > @@ -596,6 +596,7 @@ class NetworkStateInterpreter(object): >eno1: >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index f3cec79..fa15b96 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -272,25 +273,30 @@ def generate_fallback_config(blacklist_drivers=None, > config_driver=None): >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-to-network-v2 into cloud-init:master

2019-08-06 Thread Ryan Harper
One debugging line needs removing and some questions inline. Diff comments: > diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py > index 0ca576b..c0c415d 100644 > --- a/cloudinit/net/network_state.py > +++ b/cloudinit/net/network_state.py > @@ -596,6 +596,7 @@ class

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master

2019-08-06 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792 -- Your team cloud-init commiters

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master

2019-08-06 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/370927 -- Your team cloud-init

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master

2019-08-06 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/config/cc_set_passwords.py > b/cloudinit/config/cc_set_passwords.py > index 4585e4d..10d68ea 100755 > --- a/cloudinit/config/cc_set_passwords.py > +++ b/cloudinit/config/cc_set_passwords.py > @@ -9,27 +9,38 @@ > """ > Set Passwords > - >

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master

2019-08-06 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:doc into cloud-init:master. Commit message: cc_set_passwords: rewrite documentation What we had previously was inaccurate in a few respects. LP: #1838794 Requested reviews: Server Team CI bot