[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2019-08-14 Thread Seth Arnold
** Attachment added: "shellcheck.txt" https://bugs.launchpad.net/ubuntu/+source/ec2-instance-connect/+bug/1835114/+attachment/5282470/+files/shellcheck.txt ** Changed in: ec2-instance-connect (Ubuntu) Assignee: Ubuntu Security Team (ubuntu-security) => (unassigned) -- You received this

[Cloud-init-dev] [Bug 1835114] Re: [MIR] ec2-instance-connect

2019-08-14 Thread Seth Arnold
At a high level I'm concerned about several parts of this tool's design: - First, it puts an incredibly high level of trust in the metadata service. This may make sense in the context of executing on the Amazon platform, but is positively dangerous outside the Amazon platform. It's

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master

2019-08-14 Thread Ryan Harper
I think Chad meant after our next SRU[1], which will begin shortly. I'd expect this come in the SRU after the current planned one. 1. https://wiki.ubuntu.com/StableReleaseUpdates -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/369792 Your team cloud-init commiters

Re: [Cloud-init-dev] [Merge] ~florian-mueller-v/cloud-init:docs-fix into cloud-init:master

2019-08-14 Thread Dan Watkins
Hey Florian, thanks for submitting this! It looks like you haven't signed the CLA; please check out the instructions at https://cloudinit.readthedocs.io/en/latest/topics/hacking.html for how to do so. Thanks! --

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master

2019-08-14 Thread Ryan Harper
Inline comment asking for clarification on AWS DHCP lease contents, requirements for routing traffic to IMDS, DNS, and off-box, as with Azure. Let's document what's needed; we may need to add secondary ips with a metric. See https://github.com/aws/ec2-net-utils/blob/master/ec2net-functions

[Cloud-init-dev] [Merge] ~florian-mueller-v/cloud-init:docs-fix into cloud-init:master

2019-08-14 Thread Florian Müller
Florian Müller has proposed merging ~florian-mueller-v/cloud-init:docs-fix into cloud-init:master. Commit message: Add missing #cloud-config comment on first example in documentation. Since this is the first code snippet some users might see, they could end up in the same situation like me