Thanks.
It's more clean to add ZStack in same way as BrightBox，and I changed it.
--
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
Your team cloud-init Commiters is requested to review the proposed merge of
~ruansx/cloud-init:add-zstack-datasource into cloud-init:mast
The proposal to merge ~ruansx/cloud-init:add-zstack-datasource into
cloud-init:master has been updated.
Commit message changed to:
Add datastore for ZStack platfrom
Zstack platform provides a AWS Ec2 metadata service, and
identifies their platform to the guest by setting the 'chassis asset tag'
Some comments inline. I also updated your commit message a bit.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..525121b 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -47
Also, this request is still relevant.
* Add doc/rtd/topics/datasources/zstack.rst and update
doc/rtd/topics/datasources.rst to reference it. See Exoscale for a recently
added datasource example.
--
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
Your team cloud-init
Opened
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/372622
to address the brightbox issue.
--
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
Your team cloud-init Commiters is requested to review the proposed merge of
~ruansx/cloud-init:add-zs
Scott Moser has proposed merging ~smoser/cloud-init:fix/brightbox-less-matchy
into cloud-init:master.
Commit message:
Brightbox: restrict detection to require full domain match .brightbox.com
The detection for brightbox in both ds-identify and in
identify_brightbox would incorrectly match the do
Just for reference, bug 1661693 has some real collected output that shows:
$ ( cd /sys/class/dmi/id && sudo grep -r . . ) 2>/dev/null
./product_serial:srv-fajvm.gb1.brightbox.com
./bios_vendor:Seabios
./product_version:RHEL 6.6.0 PC
./power/runtime_active_kids:0
./power/runtime_suspended_time:0
./
I happened to see this false positive when reviewing the add of zstack under
Bug 1841181.
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/372622
Your team cloud-init Commiters is requested to revi
Ryan Harper has proposed merging
~raharper/cloud-init:fix/centos-wait-network-manager into cloud-init:master.
Commit message:
cloud-init.service: on centos/fedora/redhat wait on NetworkManager.service
In Centos/RHEL 8, NetworkManager is installed as the networking service.
cloud-init.service
Joshua Powers has proposed merging ~powersj/cloud-init:docs/instancedata into
cloud-init:master.
Commit message:
docs: doc8 fixes for instancedata page
The huge table was scrolling off the page for me and it made more sense
to break this up and have sections for each item anyway.
Requested rev
Joshua Powers has proposed merging ~powersj/cloud-init:docs/faq into
cloud-init:master.
Commit message:
docs: start FAQ page
Takeover the moreinfo.rst page and update initially with pages
a user can use to learn about cloud-init. For now, other docs
and presentations about cloud-init.
Goal is t
Joshua Powers has proposed merging ~powersj/cloud-init:docs/cli into
cloud-init:master.
Commit message:
docs: create cli specific page
This is formerly the capabilities page.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/
Joshua Powers has proposed merging ~powersj/cloud-init:docs/datasource into
cloud-init:master.
Commit message:
docs: cleanup output & order of datasource page
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cl
Joshua Powers has proposed merging ~powersj/cloud-init:docs/analyze into
cloud-init:master.
Commit message:
docs: added output examples to analyze.rst
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init
Joshua Powers has proposed merging ~powersj/cloud-init:docs/boot into
cloud-init:master.
Commit message:
docs: clean up formatting, organize boot page
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init
Joshua Powers has proposed merging ~powersj/cloud-init:docs/availability into
cloud-init:master.
Commit message:
docs: more complete list of availability
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-i
Joshua Powers has proposed merging ~powersj/cloud-init:docs/toc_index_revamp
into cloud-init:master.
Commit message:
docs: organize TOC and update summary of project
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/
Review: Approve continuous-integration
PASSED: Continuous integration, rev:bc35e998985ad22df380720ac33554752859625c
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1124/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:f2d60b63e8e9702b22342cfc4df6966de5d231fd
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1125/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:95714fee571e5633ce5556c1c7daf39f25afaeba
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1126/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:e2ae923d1156f68f64e5bde17b0afd716b0b7baa
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1127/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:c62f96299293afcae0dab000a1888aaf1016d900
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1128/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:59c6911df9eec387113275f4b7771f579f30e606
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1129/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:1a24df1edad88a450d7b0c7c25cbf4ac4ddad9ab
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1130/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:e03f2081bb9547ad1fc19dd31f14aff31eb05730
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1131/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~ruansx/cloud-init:add-zstack-datasource into
cloud-init:master has been updated.
Commit message changed to:
Add datastore for ZStack platfrom
Zstack platform provides a AWS Ec2 metadata service, and
identifies their platform to the guest by setting the 'chassis asset tag'
Thanks, Scott.
All comments are fixed.
--
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
Your team cloud-init Commiters is requested to review the proposed merge of
~ruansx/cloud-init:add-zstack-datasource into cloud-init:master.
_
27 matches
Mail list logo
