[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/sysconfig-distro-variant into cloud-init:master

2019-09-26 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:fix/sysconfig-distro-variant into cloud-init:master. Commit message: sysconfig: use distro variant to check if available The sysconfig renderer used the distro name directly which mean some variants of distros were not considered supporte

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/ovf-reset-instance-id into cloud-init:master

2019-09-26 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:fix/ovf-reset-instance-id into cloud-init:master. Commit message: ovf: do not generate random instance-id for IMC customization path Cloud-init will not operate properly if the instance-id value changes on each boot. This is the source of a n

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/ovf-reset-instance-id into cloud-init:master

2019-09-26 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:39455743d881c39e9721968ae4de5dd1bcf350fc https://jenkins.ubuntu.com/server/job/cloud-init-ci/1183/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into cloud-init:master

2019-09-26 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into cloud-init:master. Commit message: util: json.dumps on python 2.7 will handle unicodedecodeerror on binary Since python 2.7 doesn't handle UnicodeDecodeErrors with the default handler LP: #180

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into cloud-init:master

2019-09-26 Thread Scott Moser
The proposal to merge ~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into cloud-init:master has been updated. Commit message changed to: util: json.dumps on python 2.7 will handle UnicodeDecodeError on binary Since python 2.7 doesn't handle UnicodeDecodeErrors with the defaul

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into cloud-init:master

2019-09-26 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:45e8ac7edc90bde12416380daf7284080204 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1184/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jen

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into cloud-init:master

2019-09-26 Thread Scott Moser
doing an import in an exception handling path doesn't seem right. other than that, good work. Diff comments: > diff --git a/cloudinit/util.py b/cloudinit/util.py > index aa23b3f..49433dc 100644 > --- a/cloudinit/util.py > +++ b/cloudinit/util.py > @@ -1599,10 +1599,36 @@ def json_serialize_defau

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into cloud-init:master

2019-09-26 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:4cdfdca07d8181d37d092d43c7d6806cec1e26b7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1185/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu