[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp-1311463 into lp:cloud-init

2015-03-18 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/lp-1311463 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1311463 in cloud-init: disk-setup unable to partition disks https://bugs.launchpad.net/cloud-init/+bug/1311463

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix-smartos into lp:cloud-init

2015-03-13 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/fix-smartos into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/fix-smartos/+merge/252874 We were hitting

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp-1437350 into lp:cloud-init

2015-03-30 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/lp-1437350 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1437350 in cloud-init: cirros uses exit status 0 when trying to login as root https://bugs.launchpad.net

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix-py26 into lp:cloud-init

2015-03-04 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/fix-py26 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/fix-py26/+merge/251784 -- Your team cloud init

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/smartos-v2-metadata into lp:cloud-init

2015-03-04 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/smartos-v2-metadata into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/smartos-v2-metadata/+merge/251775 Update

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix-dmi into lp:cloud-init

2015-03-04 Thread Dan Watkins
I've tested the code in this branch on Joyent, and it fixes the problem there. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/fix-dmi/+merge/251715 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/fix-dmi into

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/smartos-v2-metadata into lp:cloud-init

2015-03-04 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/smartos-v2-metadata into lp:cloud-init with lp:~daniel-thewatkins/cloud-init/fix-dmi as a prerequisite. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix-dmi into lp:cloud-init

2015-03-04 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/fix-dmi into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1427687 in cloud-init: Reading of DMI data is broken https://bugs.launchpad.net/cloud-init/+bug/1427687 For more

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix-py34-test-hang into lp:cloud-init

2015-03-04 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/fix-py34-test-hang into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/fix-py34-test-hang/+merge/251725 Fixes test

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-20 Thread Dan Watkins
I've tested this on a GCE instance, and it works as expected. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init.

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-20 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1403617 in cloud-init: gce datasource does not handle instance ssh keys https://bugs.launchpad.net/cloud-init

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/walinux-wip into lp:cloud-init

2015-05-07 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/walinux-wip into lp:cloud-init. Commit message: Remove the need for walinuxagent for basic booting. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/walinux-wip into lp:cloud-init

2015-05-08 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/walinux-wip into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/walinux-wip/+merge/258644 -- Your team cloud init

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1375252 into lp:cloud-init

2015-04-15 Thread Dan Watkins
Review appreciated, but probably shouldn't be merged until vivid is out the door. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1375252/+merge/256291 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/lp1375252

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1464253 into lp:cloud-init

2015-06-12 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/lp1464253 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1440263 in cloud-init: CloudStack reset password not working https://bugs.launchpad.net/cloud-init/+bug/1440263

Re: [Cloud-init-dev] [Merge] lp:~bbaude/cloud-init/rh_subscription into lp:cloud-init

2015-05-27 Thread Dan Watkins
A bit more detail on self.assertRaises. Diff comments: === added file 'cloudinit/config/cc_rh_subscription.py' --- cloudinit/config/cc_rh_subscription.py1970-01-01 00:00:00 + +++ cloudinit/config/cc_rh_subscription.py2015-05-21 18:38:12 + @@ -0,0 +1,402 @@ +# vi: ts=4

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init

2015-05-28 Thread Dan Watkins
Review: Approve LGTM. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks/+merge/260455 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init.

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init

2015-05-28 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1459604 in cloud-init: Some examples missing from readthedocs https://bugs.launchpad.net

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init

2015-05-28 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/openstack-vendor-data-doc into lp:cloud-init

2015-05-28 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/openstack-vendor-data-doc into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/openstack-vendor-data-doc/+merge

Re: [Cloud-init-dev] [Merge] lp:~bbaude/cloud-init/rh_subscription into lp:cloud-init

2015-05-26 Thread Dan Watkins
Diff comments: === added file 'cloudinit/config/cc_rh_subscription.py' --- cloudinit/config/cc_rh_subscription.py1970-01-01 00:00:00 + +++ cloudinit/config/cc_rh_subscription.py2015-05-21 18:38:12 + @@ -0,0 +1,402 @@ +# vi: ts=4 expandtab +# +#Copyright (C) Red Hat,

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix-gce-az into lp:cloud-init

2015-07-06 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/fix-gce-az into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/fix-gce-az/+merge/263907 GCE returns a string like

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.reporting into lp:cloud-init

2015-08-07 Thread Dan Watkins
One of my comments suggests changes to the reporting framework itself, so making those changes in 2.0 and re-backporting probably makes most sense. Diff comments: === modified file 'bin/cloud-init' --- bin/cloud-init2015-07-31 15:20:36 + +++ bin/cloud-init2015-08-07 05:57:11

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix-gce-az into lp:cloud-init

2015-07-22 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/fix-gce-az into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/fix-gce-az/+merge/265509 This makes the full data

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2015-10-19 Thread Dan Watkins
Diff comments: > === modified file 'cloudinit/config/cc_disk_setup.py' > --- cloudinit/config/cc_disk_setup.py 2015-07-22 19:14:33 + > +++ cloudinit/config/cc_disk_setup.py 2015-10-19 14:33:26 + > @@ -343,13 +345,16 @@ > > > def get_mbr_hdd_size(device): > -size_cmd =

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2015-10-19 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1460715 in cloud-init: "MBR disk setup fails in wily because sfdisk no longer accepts M as a valid unit&quo

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2015-10-20 Thread Dan Watkins
Right, I've updated the patch to use blockdev to find the size and sector size, which allows us to calculate the size of a disk in sectors. I've tested this on wily and trusty, and it worked in both cases. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1460715/+merge/274897 Your

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init

2015-10-09 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1488891 in cloud-init: "WALinuxAgentShim fails to handle escaped characters in dhclient.eth0.leases&quo

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init

2015-10-09 Thread Dan Watkins
Good suggestions, smoser. I've refactored that stuff in to a separate method. I've also refactored the tests to not dynamically create the packed/encoded strings but instead have them hard-coded. This reduces the complexity of the tests, and also means that you can see the strings that are

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init

2015-08-26 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/shim_fixes/+merge/269199 -- Your team cloud init

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/fix_mount_cb_symlink into lp:cloud-init

2015-09-01 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/fix_mount_cb_symlink into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/fix_mount_cb_symlink/+merge/269789

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/merging-doc-clarification into lp:cloud-init

2016-06-02 Thread Dan Watkins
The proposal to merge lp:~daniel-thewatkins/cloud-init/merging-doc-clarification into lp:cloud-init has been updated. Status: Work in progress => Approved For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/merging-doc-clarification/+merge/295822 -- Your team

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/merging-doc-clarification into lp:cloud-init

2016-05-26 Thread Dan Watkins
The proposal to merge lp:~daniel-thewatkins/cloud-init/merging-doc-clarification into lp:cloud-init has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/merging-doc-clarification/+merge/295822 -- Your

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/merging-doc-clarification into lp:cloud-init

2016-05-26 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/merging-doc-clarification into lp:cloud-init. Requested reviews: Patricia Gaughen (gaughen) cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/merging

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init

2016-04-04 Thread Dan Watkins
The proposal to merge lp:~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks into lp:cloud-init has been updated. Description changed to: X-CPC-Summary-Skip: 1 For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/rtd_examples_datasources_disks/+merge/260455

[Cloud-init-dev] [Merge] lp:~wido/cloud-init/cloudstack-dhcp into lp:cloud-init

2016-04-29 Thread Dan Watkins
Dan Watkins has proposed merging lp:~wido/cloud-init/cloudstack-dhcp into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1576273 in cloud-init: "CloudStack datasource fails to find DHCP lease if IPv6 present" https://bugs.lau

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2016-07-07 Thread Dan Watkins
The proposal to merge lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init has been updated. Commit Message changed to: [cc_disk_setup] Use sectors to resize MBR disks The version of sfdisk in wily (and onwards) only accepts sectors as a valid disk size. As such, this refactors the

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2016-07-07 Thread Dan Watkins
The proposal to merge lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init has been updated. Description changed to: X-CPC-Summary-Skip: 1 For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1460715/+merge/274897 -- Your team cloud init development team

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:httpretty-cleanup into cloud-init:master

2017-01-24 Thread Dan Watkins
Review: Needs Information Diff comments: > diff --git a/tests/unittests/test_datasource/test_gce.py > b/tests/unittests/test_datasource/test_gce.py > index a5cced0..8757cb8 100644 > --- a/tests/unittests/test_datasource/test_gce.py > +++ b/tests/unittests/test_datasource/test_gce.py > @@

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:master into cloud-init:master

2016-10-07 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:master into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1629797 in cloud-init: "resolve service in nsswitch.conf adds 25 seconds to failed lookups b

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1603222 into cloud-init:master

2016-11-09 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1603222 into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1603222 in cloud-init: "Azure: incorrect entry in fstab for ephemeral disk&quo

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lp1603222 into cloud-init:master

2016-11-10 Thread Dan Watkins
Yeah, this doesn't change the behaviour if there is no disk, but it does make it correct if there is one. (AIUI, there's always an ephemeral disk on Azure, so handling the no-disk situation is less important.) --

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:bug/lp1538522-azure-builtin-agent into cloud-init:master

2016-11-17 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:bug/lp1538522-azure-builtin-agent into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1538522 in cloud-init: "Calls "service walinuxagent start

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1379080-fix-xen-kernel-detection into cloud-init:ubuntu/devel

2017-01-12 Thread Dan Watkins
Review: Needs Fixing Diff comments: > diff --git a/debian/update-grub-legacy-ec2 b/debian/update-grub-legacy-ec2 > index 19648f6..c7a5687 100755 > --- a/debian/update-grub-legacy-ec2 > +++ b/debian/update-grub-legacy-ec2 > @@ -1398,9 +1398,19 @@ fi > > > if ! type is_xen_kernel >/dev/null

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/ds-identify-none-twice into cloud-init:master

2017-03-29 Thread Dan Watkins
Review: Approve -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321208 Your team cloud init development team is requested to review the proposed merge of ~smoser/cloud-init:bug/ds-identify-none-twice into cloud-init:master.

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:dsidentify_configdrive_latest into cloud-init:master

2017-04-14 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:dsidentify_configdrive_latest into cloud-init:master has been updated. Commit Message changed to: ds-identify: Check correct path for "latest" config drive We were checking /var/lib/cloud/openstack/latest/meta_data.json

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:dsidentify_configdrive_latest into cloud-init:master

2017-04-14 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:dsidentify_configdrive_latest into cloud-init:master. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1673637 in cloud-init: "cloud-init - Hosts in softlayer receiving wa

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/gce-ssh-key-attributes into cloud-init:master

2017-05-25 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/gce-ssh-key-attributes into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1693582 in cloud-init: "cloud-init uses a deprecated metadata path for

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/gce-ssh-key-attributes into cloud-init:master

2017-05-25 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/gce-ssh-key-attributes into cloud-init:master has been updated. Commit Message changed to: Update the attribute used to find SSH keys in GCE Per the documentation at

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1767131-snap-seeded into cloud-init:master

2018-05-10 Thread Dan Watkins
Review: Approve This LGTM. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345365 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/1767131-snap-seeded into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/cc-uaclient into cloud-init:master

2019-04-01 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_advantage.py > b/cloudinit/config/cc_ubuntu_advantage.py > index 5e082bd..9732ffa 100644 > --- a/cloudinit/config/cc_ubuntu_advantage.py > +++ b/cloudinit/config/cc_ubuntu_advantage.py > @@ -1,150 +1,125 @@ > -# Copyright (C) 2018

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/cc-uaclient into cloud-init:master

2019-04-01 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/cc-uaclient into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/365366

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/cc-uaclient into cloud-init:master

2019-04-01 Thread Dan Watkins
(Moving this to Needs Review, but please leave me to mark it Approved; it hasn't yet received any integration testing, and I would like to do some before it lands.) -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/365366 Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/cc-uaclient into cloud-init:master

2019-04-01 Thread Dan Watkins
This is a re-submission of Chad's branch (which was previously reviewed at https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/362161). I've addressed much of the review feedback there (generally in separate commits, so review my new commits to understand the changes I've

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:tests into cloud-init:master

2019-02-25 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:tests into cloud-init:master. Commit message: test_ds_identify: Don't mutate otherwise-static test data When running tests in a random order, this was causing failures due to breaking preconditions for other

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:string_types into cloud-init:master

2019-02-25 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:string_types into cloud-init:master. Commit message: util: don't determine string_types ourselves six already provides this for us, and we're already paying the cost to determine it there; no need to do it twice

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:triggerudev into cloud-init:master

2019-02-25 Thread Dan Watkins
Is this something that we could write a unittest for relatively easily? -- https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/363571 Your team cloud-init commiters is requested to review the proposed merge of ~rjschwei/cloud-init:triggerudev into cloud-init:master.

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:py26 into cloud-init:master

2019-02-25 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:py26 into cloud-init:master. Commit message: drop Python 2.6 support and our NIH version detection - Remove the last few places that use `if PY26` - Replace our Python version detection logic with six's (which we

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:triggerudev into cloud-init:master

2019-02-26 Thread Dan Watkins
This isn't a part of the code that I've touched at all, but I think you could do something in tests.unittests.test_net:TestOpenSuseSysConfigRendering; the Renderer class is being instantiated explicitly in the _get_renderer method, so that could be extended to allow passing netrules_path (or

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:apt-pipelining into cloud-init:master

2019-02-26 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:apt-pipelining into cloud-init:master. Commit message: cc_apt_pipelining: stop disabling pipelining by default This was introduced due to Ubuntu using S3 mirrors, and S3 having a buggy pipelining implementation

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:string_types into cloud-init:master

2019-02-26 Thread Dan Watkins
six.string_types has been available for at least 8 years (which is as far back as the GitHub repo commit info goes; it was imported from somewhere else before that), and has had the same values as we determine here since that time. --

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-21 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master. Commit message: helpers/openstack: Treat unknown link types as physical Some deployments of OpenStack expose link types to the guest which cloud-init doesn't recognise

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-21 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/363421 -- Your team

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1639263 in cloud-init: " cloud-init Unknown network_data link type: macvtap&quo

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master has been updated. Commit message changed to: helpers/openstack: Add macvlan to link types This enables the use of macvlan interfaces within older versions of OpenStack. LP: #1639263 For more

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:nested_set into cloud-init:master

2019-02-21 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:nested_set into cloud-init:master. Commit message: cc_rsyslog: Escape possible nested set Under Python 3.7, we are seeing `FutureWarning: Possible nested set at position 23`; escaping this bracket causes

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/driver-enablement into cloud-init:master

2019-03-06 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/driver-enablement into cloud-init:master. Commit message: Add ubuntu_drivers config module The ubuntu_drivers config module enables usage of the 'ubuntu-drivers' command. At this point it only serves

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/driver-enablement into cloud-init:master

2019-03-06 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/driver-enablement into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/363992 --

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-03-06 Thread Dan Watkins
Moving this to WIP for now. -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/362161 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master.

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master

2019-03-06 Thread Dan Watkins
The proposal to merge ~chad.smith/cloud-init:feature/cc-uaclient into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/362161 -- Your team cloud-init commiters is

[Cloud-init-dev] [Merge] ~toabctl/cloud-init:opensuse-leap-15.0 into cloud-init:master

2019-02-25 Thread Dan Watkins
The proposal to merge ~toabctl/cloud-init:opensuse-leap-15.0 into cloud-init:master has been updated. Commit message changed to: tox: Update testenv for openSUSE Leap to 15.0 Use the requirements for the openSUSE Leap 15.0 release. For more details, see:

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/driver-enablement into cloud-init:master

2019-03-05 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/driver-enablement into cloud-init:master. Commit message: Add ubuntu_drivers config module The ubuntu_drivers config module enables usage of the 'ubuntu-drivers' command. At this point it only serves

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:feature/driver-enablement into cloud-init:master

2019-03-05 Thread Dan Watkins
I have tested this in a lxd container (without NVIDIA hardware available) and in a GCE instance with an NVIDIA GPGPU attached, and it behaves as expected. (This doesn't include support for selecting versions, but I think it adds enough value without that to be worth landing by itself.) One

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:clean into cloud-init:master

2019-03-04 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:clean into cloud-init:master. Commit message: clean: correctly determine the path for excluding seed directory Previously, init.paths.cloud_dir has a trailing slash, which meant that "/var/lib/cloud/

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ds_update_events into cloud-init:master

2019-03-14 Thread Dan Watkins
I aborted that CI run as I was pushing up more changes; the next trigger run should start a run for the new commit. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/364464 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ds_update_events into cloud-init:master

2019-03-14 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:ds_update_events into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1819913 in cloud-init: "cloud-init on xenial may generate network config on every

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/ds_update_events into cloud-init:master

2019-03-14 Thread Dan Watkins
Rejecting as I'm picking up this bug in my own branch (MP at https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/364464). -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/364403 Your team cloud-init commiters is requested to review the

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/ds_update_events into cloud-init:master

2019-03-14 Thread Dan Watkins
The proposal to merge ~raharper/cloud-init:fix/ds_update_events into cloud-init:master has been updated. Status: Work in progress => Rejected For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/364403 -- Your team cloud-init commiters is requested

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel

2019-03-08 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/364162

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel

2019-03-07 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel. Requested reviews: Server Team CI bot (server-team-bot): continuous-integration cloud-init commiters (cloud-init-dev) Related bugs: Bug #1639263 in cloud-init: "

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/bionic into cloud-init:ubuntu/bionic

2019-03-07 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/bionic into cloud-init:ubuntu/bionic. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1813667 in cloud-init (Ubuntu): "Update netplan dependency package&quo

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/cosmic into cloud-init:ubuntu/cosmic

2019-03-07 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/cosmic into cloud-init:ubuntu/cosmic. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1813667 in cloud-init (Ubuntu): "Update netplan dependency package&quo

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/xenial into cloud-init:ubuntu/xenial

2019-03-07 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:ubuntu/xenial into cloud-init:ubuntu/xenial. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1639263 in cloud-init: " cloud-init Unknown network_data link type: macvtap&quo

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:pylint into cloud-init:master

2019-03-18 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:pylint into cloud-init:master. Commit message: tox: bump pylint version to latest (2.3.1) The previous version was emitting errors due to an incompatibility with one of its dependencies. (We could have pinned

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/netplan-nameserver-alias into cloud-init:master

2019-02-07 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/util.py b/cloudinit/util.py > index a8a232b..446b7b9 100644 > --- a/cloudinit/util.py > +++ b/cloudinit/util.py > @@ -1596,14 +1596,22 @@ def json_dumps(data): >separators=(',', ': '), default=json_serialize_default) > > >

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/release_blocker into cloud-init:master

2019-03-11 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:bugfix/release_blocker into cloud-init:master. Commit message: DataSourceEc2: update RELEASE_BLOCKER to be more accurate Our previous understanding of the upgrade issue was incomplete; it turns out the only

Re: [Cloud-init-dev] [Merge] ~pzakha/cloud-init:userdata into cloud-init:master

2019-05-28 Thread Dan Watkins
Hi Pavel, thanks for the contribution to cloud-init! I'm flitting between meetings, so I'm not able to assess whether these changes are broadly appropriate. That said, I do have an inline comment on how the changes could be expressed a little more concisely. I'll revisit this later today for

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:docs into cloud-init:master

2019-06-25 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:docs into cloud-init:master. Commit message: doc: indicate that netplan is default in Ubuntu now Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~daniel

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:docs into cloud-init:master

2019-06-25 Thread Dan Watkins
On Tue, Jun 25, 2019 at 07:54:20PM -, Ryan Harper wrote: > Nice. Let's add a link to netplan.io in there. Done. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/369312 Your team cloud-init commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~med/cloud-init:typo_verbatim into cloud-init:master

2019-05-22 Thread Dan Watkins
Review: Needs Information Hey David, Thanks for the fix! To contribute to cloud-init, you must sign the Canonical Contributor License Agreement (CLA) [1]. If you have already signed it as an individual, your Launchpad user will be listed in the contributor-agreement-canonical launchpad group

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:warn into cloud-init:master

2019-05-07 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:warn into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1508442 in cloud-init: "LOG.warn is deprecated" https://bugs.launchpad.net/cloud-init/+b

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lintian into cloud-init:master

2019-04-18 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:lintian into cloud-init:master. Commit message: setup.py: install bash completion script in new location Per lintian, this is the path at which bash completion scripts should now be installed. Requested reviews

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lintian into cloud-init:master

2019-04-19 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:lintian into cloud-init:master. Commit message: packages: update rpm specs for new bash completion path LP: #1825444 Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1825444 in cloud

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:lintian into cloud-init:master

2019-04-19 Thread Dan Watkins
I've tested that this (a) fixes the package build on CentOS, and (b) bash completion still works from the installed package. (I attempted to build the package on SuSE too, but I ran in to issues that I believe are unrelated to this change.) --

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master

2019-05-03 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/net/network_state.py b/cloudinit/net/network_state.py > index 4d19f56..91046b5 100644 > --- a/cloudinit/net/network_state.py > +++ b/cloudinit/net/network_state.py > @@ -707,6 +707,13 @@ class NetworkStateInterpreter(object): > item_params =

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/add-netplan-fixed-grat-arp-spelling into cloud-init:master

2019-05-03 Thread Dan Watkins
Do we need to handle older versions of netplan that _don't_ understand the new key? -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/366935 Your team cloud-init commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:snap into cloud-init:master

2019-04-26 Thread Dan Watkins
This is what I've done in terms of testing: ``` lxc launch ubuntu:b c1 lxc file push *.snap c1/tmp/ lxc exec c1 /bin/bash snap install /tmp/*.snap /snap/bin/cloud-init clean --logs /snap/bin/cloud-init init --local /snap/bin/cloud-init init ``` http://paste.ubuntu.com/p/TXrh2n4mpk/ is

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:networking into cloud-init:master

2019-07-05 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:networking into cloud-init:master. Commit message: stages: allow data sources to override network config source order Currently, if a platform provides any network configuration via the "cmdline" method (i.

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:coverity into cloud-init:master

2019-07-10 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:coverity into cloud-init:master. Commit message: Fix a couple of issues raised by a coverity scan * cc_lxd: fix copy/paste error in debug logging * DataSourceCloudSigma: remove unreachable code * This unreachable

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/ec2-secondary-nics into cloud-init:master

2019-07-08 Thread Dan Watkins
Thanks! A couple of follow-ups, and a couple of nits I missed first time around. Diff comments: > diff --git a/cloudinit/sources/DataSourceEc2.py > b/cloudinit/sources/DataSourceEc2.py > index 5c017bf..9a5ed43 100644 > --- a/cloudinit/sources/DataSourceEc2.py > +++

  1   2   >