Dimitri John Ledkov has proposed merging lp:~xnox/cloud-init/refactor-dev-root
into lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/refactor-dev-root/+merge/260165
refactor rootdev_from_cmdline
kernel takes last root= argument, as it does for all arguments.
I'm matching logic, to what kernel will do.
Some people misconfigure bootloader, yet cloud appends it's own things to the
end of cmdline hence last root= argument should win.
no need to bail inside container. it will not be on a /dev
On 26 May 2015 at 18:20, Scott Moser wrote:
> I dont think so.
> without something like lxcfs, the /proc/cmdline in the container is the
> host's /proc/cmdline.
> so that 'root=' (whether it be /dev/sda1 or LABEL=) is not destined for this
> container.
>
> with lxcfs, that might be different (ho
but this can only be fine, if /usr is mounted in the initramfs, or /usr is not
a separate mount point.
--
https://code.launchpad.net/~smoser/cloud-init/trunk.lp1543025/+merge/287682
Your team cloud init development team is requested to review the proposed merge
of lp:~smoser/cloud-init/trunk.lp1
Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/trunk.improve-wait/+merge/290243
Your team cloud init development team is requested to review the proposed merge
of lp:~smoser/cloud-init/trunk.improve-wait into lp:cloud-init.
___
Mail
Dimitri John Ledkov has proposed merging ~xnox/cloud-init:master into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1682871 in cloud-init: "attempts to rename vlans / vlans have
addr_assign_type of 0 on kernel 4.4&quo
The proposal to merge ~xnox/cloud-init:master into cloud-init:master has been
updated.
Commit Message changed to:
net: kernel lies about vlans not stealing mac addresses, when they do
Introduce is_vlan function and call that when building dictionary of
interfaces by mac address.
LP: #1682871
I did pass all the tests, and have set the commit message now.
I am unable to retrigger jenkins =(
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/322828
Your team cloud init development team is requested to review the proposed merge
of ~xnox/cloud-init:master into cloud-ini
It is called with whatever the config source provided.
It may be called with cidr, it could be an ipv6 netmask, or an ipv4 netmask.
Always return cidr.
I guess it would be better named any2cidr()
--
https://code.launchpad.net/~akaris/cloud-init/+git/cloud-init/+merge/322992
Your team cloud init
Dimitri John Ledkov has proposed merging ~xnox/cloud-init:cidr into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1689346 in cloud-init (Ubuntu): "cloud-init and nplan do not parse and
use OpenStack networking correctly with ne
Dimitri John Ledkov has proposed merging ~xnox/cloud-init:typeerror into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324012
--
Your team cloud init development
Dimitri John Ledkov has proposed merging ~xnox/cloud-init:dash_underscore into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1690480 in cloud-init (Ubuntu): "cloud-init / nplan - missing bond mode
miimon xmit_hash_policy&quo
The proposal to merge ~xnox/cloud-init:cidr into cloud-init:master has been
updated.
Commit Message changed to:
netplan: generate cidr routes and netmasks.
LP: #1689346
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324010
--
Your team cloud init dev
The proposal to merge ~xnox/cloud-init:dash_underscore into cloud-init:master
has been updated.
Commit Message changed to:
netplan: accept bond_ and bond- settings for mode/mii/xmit_hash_policy
It seems like the test-suite expects the internal v1 yaml to have
dashes, yet ConfigDrive network_dat
The proposal to merge ~xnox/cloud-init:typeerror into cloud-init:master has
been updated.
Commit Message changed to:
netplan: fix render_network_state arguments positions
tools/net-convert fails to output netplan config, because the
positional arguments of render_network_state are the wrong way
Dimitri John Ledkov has proposed merging ~xnox/cloud-init:vlan-macaddress into
cloud-init:master.
Commit message:
netplan: pass macaddress, when specified, for vlans
LP: #1690388
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1690388 in cloud-init
Dimitri John Ledkov has proposed merging
~xnox/cloud-init:nplan-ipv6-int-mask2cidr into cloud-init:master.
Commit message:
nplan: correctly generate ipv6 and ipv4 netmask addresses
It appears that the internal networking state parses netmask as
netmask for ipv4, yet as a cidr for ipv6
The proposal to merge ~xnox/cloud-init:nplan-ipv6-int-mask2cidr into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/324106
--
Your team cloud-init commiters is requested t
Dimitri John Ledkov has proposed merging ~xnox/cloud-init:devel into
cloud-init:ubuntu/devel.
Commit message:
Disable upstart support, as upstart is no longer shipped in artful.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~xnox
This is the last package from default container that ships upstart jobs.
Everything else is either fixed, stuck in proposed, or has a merge proposal
awaiting review.
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491
Your team cloud-init commiters is requested to review
In the default lxd container, this is now the last package shipping /etc/init/*
jobs.
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491
Your team cloud-init commiters is requested to review the proposed merge of
~xnox/cloud-init:devel into cloud-init:ubuntu/devel.
___
Review: Needs Information
Reading the bug report, and this merge proposal, I am slightly concerned and
would want to more information.
Ec2Local datasource is called "local" yet it clearly brings network up. Can you
explain a bit how it works? Does it discover something else behind dhcp and
cha
The proposal to merge ~xnox/cloud-init:networkd into cloud-init:master has been
updated.
Commit Message changed to:
azure: discover datasource from networkd lease files
LP: #1718029
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/331642
--
Your team c
The proposal to merge ~xnox/cloud-init:networkd into cloud-init:master has been
updated.
Description changed to:
azure: discover datasource from networkd lease files
LP: #1718029
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/331642
--
Your team clou
Dimitri John Ledkov has proposed merging ~xnox/cloud-init:networkd into
cloud-init:master.
Commit message:
azure: discover datasource from networkd lease files
LP: #1718029
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1718029 in cloud-init (Ubuntu
Testing seems all good. In-place test on Azure yields:
2017-10-02 08:06:31,894 - azure.py[DEBUG]: Finding Azure endpoint from
networkd...
2017-10-02 08:06:31,895 - util.py[DEBUG]: Reading from
/run/systemd/netif/leases/2 (quiet=False)
2017-10-02 08:06:31,895 - util.py[DEBUG]: Read 410 bytes from
CloudStack portion is untested; please provide a cloudstack xenial instance
with ssh-import-id lp:xnox
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/331642
Your team cloud-init commiters is requested to review the proposed merge of
~xnox/cloud-init:networkd into cloud-ini
Review: Needs Fixing
os.listdir is not safe to call, if directory does not exist.
Diff comments:
> diff --git a/cloudinit/net/dhcp.py b/cloudinit/net/dhcp.py
> index 0535063..c1e5756 100644
> --- a/cloudinit/net/dhcp.py
> +++ b/cloudinit/net/dhcp.py
> @@ -118,4 +120,26 @@ def dhcp_discovery(dhcl
Also needs a test for no leases dir, or use glob.iglob in the implementation.
Diff comments:
> diff --git a/cloudinit/net/tests/test_dhcp.py
> b/cloudinit/net/tests/test_dhcp.py
> index a38edae..747b65b 100644
> --- a/cloudinit/net/tests/test_dhcp.py
> +++ b/cloudinit/net/tests/test_dhcp.py
> @@
Review: Resubmit
Superseeded by
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/331664
--
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/331642
Your team cloud-init commiters is requested to review the proposed merge of
~xnox/cloud-init:networkd into clo
The proposal to merge ~xnox/cloud-init:networkd into cloud-init:master has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/331642
--
Your team cloud-init commiters is requested to review the pro
I don't like this, as this will introduce a boot delay and total time to first
boot for everybody, even if not strickly needed.
E.g. cloud-init may have networking config disabled (like it is on some agent
managed clouds); clouds that don't do network things in cloud-init-local do not
neeed thi
"and total time to first..."
strictly
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/344198
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:fix/lp-1766287-run-after-udev-settle-service into
cloud-init:master.
Review: Needs Fixing
I am glad this was superseded by
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/344339
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/344198
Your team cloud-init commiters is requested to review the proposed merge of
~rahar
Dimitri John Ledkov has proposed merging
lp:~xnox/cloud-init/fix-systemd-install-paths into lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/fix-systemd-install-paths/+merge/227918
--
https
Dimitri John Ledkov has proposed merging lp:~xnox/cloud-init/fix-packaging into
lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~xnox/cloud-init/fix-packaging/+merge/227931
--
https://code.launchpad.net/~xnox
Right, in that case /lib/systemd/system should be the fallback, and the default
path shall be queried with pkg-config, which should always give us the right
install path.
--
https://code.launchpad.net/~xnox/cloud-init/fix-systemd-install-paths/+merge/227918
Your team cloud init development team
37 matches
Mail list logo
