Example tox run: https://paste.ubuntu.com/23356016/
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/308975
Your team cloud init development team is requested to review the proposed merge
of ~powersj/cloud-init:coverage into cloud-init:master.
___
Joshua Powers has proposed merging ~powersj/cloud-init:coverage into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/308975
Adds in coverage collections to cloud
Review: Approve
Can confirm this merge request fixes the issue that I was seeing. I can now
build as a non-root user as expected.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/309124
Your team cloud init development team is requested to review the proposed merge
of ~sm
The proposal to merge ~powersj/cloud-init:integration-testing into
cloud-init:master has been updated.
Description changed to:
* initial commit of integration test framework
* added tests.rst to Read the Docs and updated index.rst
* updated tox.ini to not run our integration unit test scripts wh
Review: Approve
LGTM with two comments:
1) Had to increase the timeout as 120 seconds was not enough. I bumped to 600.
2) the tox target "cittest_run" actually does a "tree_run" In order to not be
confused between run versus tree_run I think this should really be
"cittest_tree_run"
Tested by
Review: Approve
LGTM
Thanks for the changes! Ran the following successfully with no changes to
timeouts:
$ tox
$ tox -e citest_tree_run
$ tox -e citest -- tree_run -n zesty -t
tests/cloud_tests/configs/modules/write_files.yaml
$ python3 -m tests.cloud_tests tree_run -v -n zesty -t
tests/cloud
@wesley, per the commit message you enabled additional distros. It looks like
wheezy, jessie and centros66, and centos70. Do these require the newer version
of pylxd for running? Should they work as expected? Trying to understand how to
test these.
--
https://code.launchpad.net/~wesley-wiedenme
Review: Approve
LGTM, with two minor comments below. Reusing images has really sped up
execution and printing the cloud-init version is great. I ran through the
following tests:
$ tox
$ tox -e citest -- run -v -n zesty -t
tests/cloud_tests/configs/modules/write_files.yaml
$ tox -e citest_new_p
Joshua Powers has proposed merging ~powersj/cloud-init:make-tox-revamp into
cloud-init:master.
Commit message:
Remove style checking during build and add latest style checks to tox
- make check will no longer run the style checks
- created style-check make file target to continue to run pep8
Joshua Powers has proposed merging ~powersj/cloud-init:pycodestyle into
cloud-init:master.
Commit message:
pycodestyle cleanup
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/316042
Joshua Powers has proposed merging ~powersj/cloud-init:jlp into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/318152
~=~=~ DO NOT MERGE ~=~=~
--
Your team cloud
The proposal to merge ~powersj/cloud-init:update_cii_tox_docs into
cloud-init:master has been updated.
Commit Message changed to:
doc: add dependencies and tox instructions for integration tests
Add instructions on how to run the cii tests via tox as well
as the basic system dependencies for ru
Joshua Powers has proposed merging ~powersj/cloud-init:update_cii_tox_docs into
cloud-init:master.
Commit message:
doc: add dependencies and tox instructions for integration tests
Add instructions on how to run the cii tests via tox as well
as the basic system dependencies for running the cii
tox -e doc output:
https://paste.ubuntu.com/24153451/
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319617
Your team cloud init development team is requested to review the proposed merge
of ~powersj/cloud-init:update_cii_tox_docs into cloud-init:master.
__
I am fine with removing the dependency section, running via tox is much simpler
anyway. Update made, only have the run via tox method now.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319617
Your team cloud init development team is requested to review the proposed merg
The proposal to merge ~powersj/cloud-init:update_cii_tox_docs into
cloud-init:master has been updated.
Commit Message changed to:
doc: add running via tox instructions for integration tests
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319617
--
Y
Joshua Powers has proposed merging ~powersj/cloud-init:gitignore-tox-doc-html
into cloud-init:master.
Commit message:
gitignore: adding doc/rtd_html
When running tox -e doc it produces the complete read the docs
output and places it in doc/rtd_html. This is not ignored by git
and shows up as
Joshua Powers has proposed merging ~powersj/cloud-init:test_timezone into
cloud-init:master.
Commit message:
test: add daylight savings timezone as valid
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git
The proposal to merge ~powersj/cloud-init:test-set-password-list into
cloud-init:master has been updated.
Status: Work in progress => Superseded
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319877
--
Your team cloud init development team is re
Joshua Powers has proposed merging ~powersj/cloud-init:test-set-password-list
into cloud-init:master.
Commit message:
test: Add test for setting password as list
This adds an integration test for setting passwords when given
as a list, rather than a string. This also updates the docs and
tests
Pulled in smoser's changes from https://paste.ubuntu.com/24191229/ and applied
them to both set_password_list and set_password_list_string
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319878
Your team cloud init development team is requested to review the proposed merg
I added class/subclass method you proposed, which I like a lot. There is no
reason for duplicate code. My only concern is base.py filling up with a bunch
of code, but I think that is ok.
However, I had to modify the parameters slightly so nose actually realizes
there are tests to run and added
Joshua Powers has proposed merging ~powersj/cloud-init:1674317_fix_is_file into
cloud-init:master.
Commit message:
net: Fix incorrect call to isfile
Previous commit 5beecdf introduced a regression by calling
os.path.is_file, a non-existent function. This changes that call to use
os.path.isfile
After adding commit 9040e78, this ran integration tests successfully:
https://paste.ubuntu.com/24217659/
--
https://code.launchpad.net/~bbaude/cloud-init/+git/cloud-init/+merge/320411
Your team cloud init development team is requested to review the proposed merge
of ~bbaude/cloud-init:azure_boun
Review: Approve
Tested and working on torkoal. Thanks!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/320495
Your team cloud init development team is requested to review the proposed merge
of ~smoser/cloud-init:fix-test_netconfig into cloud-init:master.
Joshua Powers has proposed merging ~powersj/cloud-init:enable-pylint into
cloud-init:master.
Commit message:
test: enable pylint support in tox
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud
Joshua Powers has proposed merging ~powersj/cloud-init:enable-snap into
cloud-init:master.
Commit message:
snap: allows for creating cloud-init snap
Add a basic snapcraft.yaml file to allow the creation of cloud-init as
a snap. This will always pull down the latest source from master for
the
The proposal to merge ~powersj/cloud-init:enable-snap into cloud-init:master
has been updated.
Description changed to:
To test:
1. git clone -b enable-snap git+ssh://git.launchpad.net/~powersj/cloud-init
2. cd cloud-init
3. Because the required setup.py change is not in master, you need to edit
Joshua Powers has proposed merging ~powersj/cloud-init:change-pylint-style into
cloud-init:master.
Commit message:
pylint: update the output style to be easier to read
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj
The proposal to merge ~powersj/cloud-init:fix-log-warn into cloud-init:master
has been updated.
Status: Merged => Needs review
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/322137
--
Your team cloud init development team is requested to review
The proposal to merge ~powersj/cloud-init:fix-log-warn into cloud-init:master
has been updated.
Status: Work in progress => Merged
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/322137
--
Your team cloud init development team is requested to rev
Joshua Powers has proposed merging ~powersj/cloud-init:pylint-fix-backslash
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/322164
pylint: fix various
Joshua Powers has proposed merging ~powersj/cloud-init:pylint-warnings-cleanup
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/322163
Cleanup of various pylint
Joshua Powers has proposed merging ~powersj/cloud-init:add-rtd-examples into
cloud-init:master.
Commit message:
Doc: add additional RTD examples
Includes missing examples for RTD
LP: #1459604
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #159604 in
The proposal to merge ~powersj/cloud-init:fix-debian-backports into
cloud-init:master has been updated.
Commit Message changed to:
template: Update debian backports template
Debian backports are contains in the main repo and not somewhere
seperate. Thanks to Charles Plessy.
LP: #1627293
For m
Joshua Powers has proposed merging ~powersj/cloud-init:fix-debian-backports
into cloud-init:master.
Commit message:
template: Update debian backports template
Debian backports are contains in the main repo and not somewhere
seperate. Thanks to Charles Plessy.
LP: #1627293
Requested reviews
Joshua Powers has proposed merging ~powersj/cloud-init:fix-rsyslog into
cloud-init:master.
Commit message:
rsyslog: replace ~ with stop
The discard action (tilde character) has been replaced by the
“stop” RainerScript directive. It is considered more intuitive and
offers slightly better
Review: Approve
LGTM
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/322386
Your team cloud init development team is requested to review the proposed merge
of ~smoser/cloud-init:bug/1636531-altcloud-test-used-blkid into
cloud-init:master.
___
ok so what I can do is propose a new pylintrc that excludes all the other
warning numbers, except these two. And as I fix more warnings remove them from
the excludes list. Something like:
[MESSAGES CONTROL]
# Errors & warnings only
# W0223 - abstract-method
# W0511 - fixme
# W0612 - unused-vari
Diff comments:
> diff --git a/cloudinit/config/cc_apt_configure.py
> b/cloudinit/config/cc_apt_configure.py
> index 06804e8..a1ceb7c 100644
> --- a/cloudinit/config/cc_apt_configure.py
> +++ b/cloudinit/config/cc_apt_configure.py
> @@ -6,7 +6,7 @@
> #
> # This file is part of cloud-init. See
The proposal to merge ~powersj/cloud-init:pylint-warnings-cleanup into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/322163
--
Your team cloud init development team is
The proposal to merge ~powersj/cloud-init:pylint-fix-backslash into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/322164
--
Your team cloud init development team is re
Joshua Powers has proposed merging ~powersj/cloud-init:enable-artful-int into
cloud-init:master.
Commit message:
tests: enable Ubuntu 17.10 'artful' in integration tests.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.lau
Joshua Powers has proposed merging ~powersj/cloud-init:fix-centos-unittests
into cloud-init:master.
Commit message:
unittests: fix unittests run on centos.
Some unit tests were broken when running on centos.
This fixes the unit test, with a small re-work of apt_configure.
Also in 't
Joshua Powers has proposed merging ~powersj/cloud-init:integration-test-revamp
into cloud-init:master.
Commit message:
Integration Testing: tox env, pyxld 2.2.3, and revamp framework
Massive update to clean up and greatly enhance the integration
testing framework developed by Wesley Wiedenmeier
The proposal to merge ~powersj/cloud-init:integration-test-revamp into
cloud-init:master has been updated.
Description changed to:
Tests preformed:
$ tox
$ tox -e citest -- bddeb
$ tox -e citest -- bddeb --deb output.deb
$ tox -e citest -- run -v -n xenial
$ tox -e citest -- run -v -n zesty --de
@chad.smith: recall a tree_run will build your local tree. To do that it will
be default use a xenial container to build cloud-init, produce the deb, and
then use that deb on your artful test.
I'm sure if you look at the full output you will see a acquiring image for
artful and xenial.
--
htt
The proposal to merge ~powersj/cloud-init:integration-test-revamp into
cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/323588
--
Your team cloud-init commiters is requested to
Joshua Powers has proposed merging ~powersj/cloud-init:fix-test-mkfs into
cloud-init:master.
Commit message:
tests: fix hardcoded path to mkfs.ext4
A recent merge that added a mkfs.ext4 tests has a hard coded location
for the binary of mkfs.ext4. On CentOS 7 the test failed because the
command
Made Chad's spelling and doc string changes. Looked into the tmpdir changes and
agreed that it is useless so removed the function and updated the lxd calls to
call tempfile.mkdtemp directly.
Thanks for the review!
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136
Y
With mock method per smoser and tested on zesty and centos 7.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324201
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:fix-test-mkfs into cloud-init:master.
The proposal to merge ~powersj/cloud-init:integration-test-revamp into
cloud-init:master has been updated.
Commit Message changed to:
Integration Testing: tox env, pyxld 2.2.3, and revamp framework
Massive update to clean up and greatly enhance the integration testing
framework developed by We
I made an update to the commit message. That was a combination of the original
messages before we had pulled in that tox change earlier.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136
Your team cloud-init commiters is requested to review the proposed merge of
~po
Why are there systemd changes at all? I am probably the last person who should
comment on a merge request including more than what the change log says, but
why are those necessary?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324401
Your team cloud-init commiters is re
Review: Approve
LGTM
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324401
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master.
___
Joshua Powers has proposed merging ~powersj/cloud-init:fix-integration-ntp into
cloud-init:master.
Commit message:
tests: Fix ntp integration test regression
LP: #1692686
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj
The proposal to merge ~powersj/cloud-init:fix-integration-snappy into
cloud-init:master has been updated.
Commit Message changed to:
tests: Fix snapd test case for non-started service
Snapd does not start on artful or on the versions in proposed. This
changes the behavior of the test to confirm
Joshua Powers has proposed merging ~powersj/cloud-init:fix-integration-snappy
into cloud-init:master.
Commit message:
tests: Fix snapd test case for non-started service
Snapd does not start on artful or on the versions in proposed. This changes
the behavior of the test to confirm that snapd is
We could have a version-based check, however the version that breaks this,
2.26, is in proposed and about to migrate to all supported releases at any day.
I certainly expect this to be fixed unless someone tells me that what we are
doing (e.g. running snapd in a container) isn't allowed.
My ori
Joshua Powers has proposed merging ~powersj/cloud-init:fix-blank-line into
cloud-init:master.
Commit message:
tests: cleanup pycodestyle error of missing blank line
LP: #1692960
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1692960 in cloud-init: "
Review: Approve
LGTM thank you for updating the versions as well.
The tip commands all pass, tox passes, and the versions all look to be good to
go.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497
Your team cloud-init commiters is requested to review the proposed
Updated the test content to check that snapd is installed using dpkg output
rather than relying on --version output.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324430
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:fix
+1 passes CI, build test working again, all tox envs, except centos6, look
good. Thanks for doing this.
The tox centos6 env, tested on centos 6 lxd, fail with the following, and I can
get these cleaned up in a separate merge.
=
Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324541
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/package-build-no-stylechecks into cloud-init:master.
___
Joshua Powers has proposed merging ~powersj/cloud-init:create-centos-tests into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324982
Looking for a review on this. It
@smoser: thanks for the template!
@rharper: responses below two big points:
1) Knowning when network is up is a better solution than the sleep. May try to
see if cloud-init is finished if cloud-init is in the images or some other
solution.
2) Knowing when we need to use the proxy. When this is
Review: Approve
LGTM passes tox locally and in my centos6 container.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325024
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:skip-jsonschema-unittest-when-missing-deps in
The proposal to merge ~powersj/cloud-init:create-centos-tests into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324982
--
Your team cloud-init commiters is requested
Joshua Powers has proposed merging ~powersj/cloud-init:create-centos-tests into
cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git
The proposal to merge ~powersj/cloud-init:create-centos-tests into
cloud-init:master has been updated.
Description changed to:
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324982
--
Your team cloud-init commiters is requested to review the propo
The proposal to merge ~powersj/cloud-init:create-centos-tests into
cloud-init:master has been updated.
Commit Message changed to:
tools: add centos scripts to build and test
* Creates centos 6 or 7 lxd container
* Sets http_proxy variable for yum if set locally
* Creates centos user
* P
The proposal to merge ~powersj/cloud-init:create-centos-tests into
cloud-init:master has been updated.
Description changed to:
Read for review
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324982
--
Your team cloud-init commiters is requested to r
Joshua Powers has proposed merging ~powersj/cloud-init:style-fix into
cloud-init:master.
Commit message:
test: Fix lint check of unused import
The jsonschema package is used only when available, but the lint
check thinks the import is unused across pyflakes and flake8. In
order to avoid having
Joshua Powers has proposed merging ~powersj/cloud-init:snap-remove-pipe into
cloud-init:master.
Commit message:
snap: Removing snapcraft plug line
The snap is a classic snap and does not need to specify any plugs
because it is already unconfined.
LP: #1695333
Requested reviews:
cloud-init
The proposal to merge ~powersj/cloud-init:integration-test-revamp into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324136
--
Your team cloud-init commiters is requested to rev
Review: Approve
Only reviewed run-centos: clean up looks good and runs as expected locally.
Thanks for taking the time to convert over to using read-dependencies.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325679
Your team cloud-init commiters is requested to revi
The proposal to merge ~powersj/cloud-init:test-ci into cloud-init:master has
been updated.
Description changed to:
DO NOT MERGE
This is a test for the new CI system only!
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/325777
--
Your team cloud-init
Joshua Powers has proposed merging ~powersj/cloud-init:test-ci into
cloud-init:master.
Commit message:
doc: test
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/325777
DO NOT MERGE
This is
Hi Marc
Based on a quick look, it appears that in Python3 six.StringIO exists, but not
in Python2. As you have corrected, io.BytesIO exists in both. Also CI looks
good.
Can I get you to do the following:
1. Set a commit message with a few details:
Summary
More information
...
LP:
Joshua Powers has proposed merging ~powersj/cloud-init:fix_ntp_tests into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/326312
tests: update ntp tests after sntp added
The proposal to merge ~powersj/cloud-init:fix_ntp_tests into cloud-init:master
has been updated.
Commit Message changed to:
tests: update ntp tests after sntp added
A recent change to ntp in artful has added the sntp package
whenever ntp is installed. The tests, rather poorly, did a
`dpkg -l` i
The proposal to merge ~powersj/cloud-init:fix_ntp_tests into cloud-init:master
has been updated.
Description changed to:
Tested with:
* python3 -m tests.cloud_tests run --os-name artful --preserve-data --data-dir
results --verbose -t modules/ntp -t modules/ntp_servers -t modules/ntp_pools
-
Joshua Powers has proposed merging ~powersj/cloud-init:fix_ssh_import_id into
cloud-init:master.
Commit message:
Tests: Simplify the check on ssh-import-id
I want to be able to add additional SSH keys to my account, therefore I
should not be limiting these tests to look for one specific key
Joshua Powers has proposed merging ~powersj/cloud-init:fix-apt-keyserver into
cloud-init:master.
Commit message:
test: fix incorrect keyid
The test is currently importing the incorrect keyid. It specifies
the curtin developers ppa, rather than the cloud-init ppa. On
Artful this causes failures
The proposal to merge ~powersj/cloud-init:update-pylxd-version into
cloud-init:master has been updated.
Commit Message changed to:
tests: Update version of pylxd
With the upgrade to lxd 2.15, pylxd version 2.2.3 broke.
Upgrading to version 2.2.4 fixes issues with missing attributes.
For more d
Joshua Powers has proposed merging ~powersj/cloud-init:update-pylxd-version
into cloud-init:master.
Commit message:
tests: Update version of pylxd
With the upgrade to lxd 2.15, pylxd version 2.2.3 broke.
Upgrading to version 2.2.4 fixes issues with missing attributes.
Requested reviews
Review: Approve
LGTM thank you for the fix
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327344
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/1703697-python3.6-ubuntu into cloud-init:master.
_
Joshua Powers has proposed merging ~powersj/cloud-init:cii-kvm into
cloud-init:master.
Commit message:
test: Enable the KVM platform on integration tests
The KVM platform includes:
* Ubuntu images from daily stream
* Image setup via mount-image-callback
* Generation and injection
The proposal to merge ~powersj/cloud-init:cii-kvm into cloud-init:master has
been updated.
Description changed to:
Would like an initial review, please!
Example command:
$ python3 -m tests.cloud_tests run --verbose --platform kvm --os-name xenial -t
modules/locale
Note, not all existing tests
The proposal to merge ~powersj/cloud-init:cii-kvm into cloud-init:master has
been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327646
--
Your team cloud-init commiters is requested to review th
Joshua Powers has proposed merging ~powersj/cloud-init:fix-arch-hostname into
cloud-init:master.
Commit message:
archlinux: fix set hostname
cloud-init fails to set the hostname on Arch Linux becuase that
_write_hostname passes conf instead of str(conf) to util.write_file.
LP: #1705306
Joshua Powers has proposed merging ~powersj/cloud-init:fix-arch-dns into
cloud-init:master.
Commit message:
archlinux: Fix empty dns on writing network config
cloud-init fails when dns-nameservers is None.
LP: #1663045
Requested reviews:
Server Team CI bot (server-team-bot): continuous
Review: Approve
LGTM one comment below.
Diff comments:
> diff --git a/tests/cloud_tests/releases.yaml b/tests/cloud_tests/releases.yaml
> index 45deb58..c8dd142 100644
> --- a/tests/cloud_tests/releases.yaml
> +++ b/tests/cloud_tests/releases.yaml
> @@ -143,19 +143,6 @@ releases:
>
Dropping sounds good to me then.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328098
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/disable-yakkety-tests into cloud-init:master.
___
Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328095
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/locale-test-update into cloud-init:master.
___
Mailing l
Joshua Powers has proposed merging ~powersj/cloud-init:fix-cii-tree into
cloud-init:master.
Commit message:
tests: Fix build tree integration tests
The build deb command was no longer working because it had
assumed that you were in the root of the cloud-init directory.
This changes where the
Joshua Powers has proposed merging ~powersj/cloud-init:cii-kvm into
cloud-init:master.
Commit message:
test: Enable the KVM platform on integration tests
The KVM platform includes:
* Ubuntu images from daily stream
* Image setup via mount-image-callback
* Generation and injection
I have been leaving integration test requirements out of requirements-test.txt.
For example, pylxd is not in there either. I consider that file what is
required for unit tests only. Thoughts?
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327646
Your team cloud-init com
2 comments inline
Diff comments:
> diff --git a/tools/run-opensuse b/tools/run-opensuse
> new file mode 100755
> index 000..e974f8c
> --- /dev/null
> +++ b/tools/run-opensuse
> @@ -0,0 +1,273 @@
> +#!/bin/bash
> +# This file is part of cloud-init. See LICENSE file for license information.
> +
I think we should accept the comment diff change (i.e. python version change +
jsonpatch version change). This way we can keep it in the default environments
to continue to get coverage of those modules versions.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926
Your
1 - 100 of 207 matches
Mail list logo
