[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1693251 into cloud-init:master

2017-06-07 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1693251 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1693251 in cloud-init: "cloud-init should configure networkmanager to not manage /etc/resolv.conf" https://bugs.lau

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1693251 into cloud-init:master

2017-06-07 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1693251 into cloud-init:master. Commit message: net: Allow for NetworkManager configuration In cases where the config json specifies nameserver entries, if there are interfaces configured to use dhcp, NetworkManager, if enabled, will

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1693251 into cloud-init:master

2017-06-07 Thread Ryan McCabe
I submitted the form a few minutes ago. Let me know if there are any issues with it. Thanks, Ryan -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/325239 Your team cloud-init commiters is requested to review the proposed merge of ~rmccabe/cloud-init:bug1693251 into clo

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1693251-b into cloud-init:master

2017-06-08 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1693251-b into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1693251 in cloud-init: "cloud-init should configure networkmanager to not manage /etc/resolv.conf&quo

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1693251 into cloud-init:master

2017-06-08 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1693251 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1693251 in cloud-init: "cloud-init should configure networkmanager to not manage /etc/resolv.conf" https://bugs.lau

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:dns_redirect_detect into cloud-init:master

2017-08-10 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:dns_redirect_detect into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/328877 Add an option to disable DNS

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:dns_redirect_detect into cloud-init:master

2017-08-10 Thread Ryan McCabe
There is a Red Hat bugzilla regarding it at https://bugzilla.redhat.com/show_bug.cgi?id=1468192 Should I create one here? -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/328877 Your team cloud-init commiters is requested to review the proposed merge of ~rmccabe/cloud-in

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:dns_redirect_detect into cloud-init:master

2017-08-11 Thread Ryan McCabe
Thanks! -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/328877 Your team cloud-init commiters is requested to review the proposed merge of ~rmccabe/cloud-init:dns_redirect_detect into cloud-init:master. ___ Mailing list: https:

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804 into cloud-init:master

2017-11-13 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1705804 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1705804 in cloud-init: "sysconfig renderer should render DNSx= and GATEWAY= lines" https://bugs.launchpad.net/cloud

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master

2017-11-14 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1705804 in cloud-init: "sysconfig renderer should render DNSx= and GATEWAY= lines" https://bugs.launchpad.net/

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master

2017-11-14 Thread Ryan McCabe
Updated to handle dns_search when received as either a string or a list Updated per Ryan Harper's other comments on the previous iteration -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333722 Your team cloud-init commiters is requested to review the proposed merge of ~r

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master

2017-11-15 Thread Ryan McCabe
The proposal to merge ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333722 -- Your team cloud-init commiters is requested to review the

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master

2017-11-15 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Server Team CI bot (server-team-bot): continuous-integration For more details, see: https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master

2017-11-15 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Server Team CI bot (server-team-bot): continuous-integration Related bugs: Bug #1705804 in cloud-init: "sysconfig renderer should render

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master

2017-11-15 Thread Ryan McCabe
Updated per your last comments for merge after your fixes. -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333759 Your team cloud-init commiters is requested to review the proposed merge of ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master.

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master

2017-11-15 Thread Ryan McCabe
The proposal to merge ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333758 -- Your team cloud-init commiters is requested to review the

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master

2017-11-15 Thread Ryan McCabe
The unit tests will fail on this one until the patch you suggested is applied, btw, because of the dns search info being passed as a list. -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333758 Your team cloud-init commiters is requested to review the proposed merge of ~

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master

2017-11-16 Thread Ryan McCabe
Sure, no problem. I can stick it in there and resubmit. -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333759 Your team cloud-init commiters is requested to review the proposed merge of ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master. ___

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master

2017-11-16 Thread Ryan McCabe
Diff comments: > diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py > index f572796..6e11247 100644 > --- a/cloudinit/net/sysconfig.py > +++ b/cloudinit/net/sysconfig.py > @@ -347,6 +347,16 @@ class Renderer(renderer.Renderer): > else: >

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master

2017-11-16 Thread Ryan McCabe
Sorry, what I meant re: "dns-nameservers 69.9.160.191 69.9.191.4 10.0.0.1" is that the first two IPs were pulled from an ethX interface and don't belong there, given the yaml, not that there was a problem with the syntax. ACK, re: Scott's comment I'll resubmit a proposal that does only the list

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master

2017-11-16 Thread Ryan McCabe
The proposal to merge ~rmccabe/cloud-init:bug1705804-2 into cloud-init:master has been updated. Status: Superseded => Needs review For more details, see: https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333722 -- Your team cloud-init commiters is requested to review the

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master

2017-11-16 Thread Ryan McCabe
The proposal to merge ~rmccabe/cloud-init:bug1705804-3 into cloud-init:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333759 -- Your team cloud-init commiters is requested to review the

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-4 into cloud-init:master

2017-11-16 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1705804-4 into cloud-init:master. Commit message: sysconfig: Correctly render dns and dns search info. Currently when dns and dns search info is provided, it is not rendered when outputting to sysconfig format. This patch causes the DNS

Re: [Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1705804-4 into cloud-init:master

2017-11-20 Thread Ryan McCabe
Yeah, some combination of misclicks landed this in "needs review" from superseded, and I didn't see a way to put it back to there. -- https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333844 Your team cloud-init commiters is requested to review the proposed merge of ~rmccabe/

[Cloud-init-dev] [Merge] ~rmccabe/cloud-init:bug1734739 into cloud-init:master

2017-11-27 Thread Ryan McCabe
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1734739 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1734739 in cloud-init: "cloud-init mishandles dhcp6 subnets in network_data.json" https://bugs.launchpad.net/cloud