Re: [Cloud-init-dev] [Merge] lp:~therve/cloud-init/fix-landscape-config into lp:cloud-init

2012-09-05 Thread Scott Moser
Thomas, Doesn't this cause us to write /etc/default/landscape-client unless there is invalid provided in user-data ? If I understand the current code correctly, we basically no-op if there is no 'landscape' section in cloud-config. (it is a long-winded no-op, but the end result is nothing

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/query-tool-is-back into lp:cloud-init

2012-09-07 Thread Scott Moser
Scott Moser has proposed merging lp:~harlowja/cloud-init/query-tool-is-back into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harlowja/cloud-init/query-tool-is-back/+merge/123394 -- https

Re: [Cloud-init-dev] [Merge] lp:~gholms/cloud-init/fedora-distro into lp:cloud-init

2012-09-17 Thread Scott Moser
On Mon, 17 Sep 2012, Joshua Harlow wrote: H, distro_name as it exists currently doesn't seem to do anything. Not sure why thats in the ubuntu one. Let me investigate a little on that. Hmm... indeed. Well, I pulled this and pushed already. Should have looked more. --

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/url-ssl-fixings into lp:cloud-init

2012-10-18 Thread Scott Moser
a couple comments * how available is urllib3? could we do this with urllib2? * at one point I had the boto get_instance_metadata copied, and gholms had an issue wtih that. It was better to use boto, although it does add a strange dependency. --

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/filesem-check-canon into lp:cloud-init

2012-11-10 Thread Scott Moser
This was marked 'rejected' as we used the migrator module instead. -- https://code.launchpad.net/~smoser/cloud-init/filesem-check-canon/+merge/133294 Your team cloud init development team is requested to review the proposed merge of lp:~smoser/cloud-init/filesem-check-canon into lp:cloud-init.

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/finalcmd into lp:cloud-init

2012-11-12 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/finalcmd into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1064665 in cloud-init: should have some way to indicate shutdown or reboot https://bugs.launchpad.net/cloud-init/+bug

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/finalcmd into lp:cloud-init

2012-11-13 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/finalcmd into lp:cloud-init has been updated. Commit Message changed to: support 'power_state' cloud-config for specifying shutdown this adds 'power-state-change' config module that allows the user to specify in cloud-config syntax that a system

Re: [Cloud-init-dev] [Merge] lp:~gpadgett/cloud-init/ovirt into lp:cloud-init

2013-03-27 Thread Scott Moser
this looks fine to me, the only question i have is over 'blkid' usage and /dev/sr0. I have one concern. At one point I was just trying 'mount /dev/sr0' and expecting that to time out quickly, but it turned out that that was taking 18 seconds to time out in a VM with an empty cd-rom. (see

Re: [Cloud-init-dev] long option names for commands

2013-06-19 Thread Scott Moser
On Wed, 19 Jun 2013, Haefliger, Juerg wrote: Hi all, I'm about to add SLES support to cloud-init and I realized that SLES11 doesn't support long option names for certain commands (passwd, useradd, chpasswd, and probably more). Should I 'fix' cloud-init to use the short names or is that a

[Cloud-init-dev] [Merge] lp:~juergh/cloud-init/add-sles-support into lp:cloud-init

2013-06-25 Thread Scott Moser
(C) 2013 SUSE LLC # #Author: Scott Moser scott.mo...@canonical.com #Author: Juerg Haefliger juerg.haefli...@hp.com #Author: Joshua Harlow harlo...@yahoo-inc.com #Author: Ben Howard ben.how...@canonical.com +#Author: Robert Schweikert rjsch...@suse.com # #This program

Re: [Cloud-init-dev] [Merge] lp:~juergh/cloud-init/add-sles-support into lp:cloud-init

2013-06-25 Thread Scott Moser
Review: Needs Fixing A few comments / requested fixes: - using 'passwd -l' is ok globally I think (rather than copying that) just put a comment in the parent class that the long format is not supported on suse. 'chpasswd -e' is ok too. I do prefer the long command names (as just now I

Re: [Cloud-init-dev] [Merge] lp:~juergh/cloud-init/add-sles-support into lp:cloud-init

2013-06-26 Thread Scott Moser
- can we get packages/rpmb to work on suse? or should would it be better to do packages/suse-rpmb ? I can do that but who is going to use it? The package maintainer? Not sure if they are actually going to use it. Well, more than one person has asked me How can I build cloud-init for

Re: [Cloud-init-dev] [Merge] lp:~juergh/cloud-init/add-debian-init-scripts into lp:cloud-init

2013-07-16 Thread Scott Moser
Juerg, I am interested in having sysvinit scripts on debian in trunk, so thanks for your work here. The thing that I'm not so interested in is maintaining two sets of sysvinit scripts that really are the same. Just glancing, it seems that the ones ins sysvinit are largely more complete

Re: [Cloud-init-dev] [Merge] lp:~juergh/cloud-init/add-debian-init-scripts into lp:cloud-init

2013-07-17 Thread Scott Moser
Juerg, As for the last comment (sysvinit/something) mkdir sysvinit/redhat bzr add sysvinit/redhat bzr mv sysvinit/cloud-* sysvinit/redhat You'll also have to modify setup.py to make INITSYS_FILES['sysvinit'] read from sysvinit/redhat/* and then also to use sysvinit/debian/* for

Re: [Cloud-init-dev] [Merge] lp:~yufang521247/cloud-init/fix-setpassword-for-rhel5 into lp:cloud-init

2013-07-17 Thread Scott Moser
Hi, Sorry this has taken so long to get back to. I dont think your change is right. As what you're doing is changing the call to chpasswd to be 'chpasswd blob-of-stuff' rather than 'echo blob-of-stuff | chpasswd'. The right chnage I think is to do it like this: - ch_in =

Re: [Cloud-init-dev] [Merge] lp:~yufang521247/cloud-init/fix-setpassword-for-rhel5 into lp:cloud-init

2013-07-23 Thread Scott Moser
I just pushed to trunk the adding of a trailing '\n'. -- https://code.launchpad.net/~yufang521247/cloud-init/fix-setpassword-for-rhel5/+merge/168278 Your team cloud init development team is requested to review the proposed merge of lp:~yufang521247/cloud-init/fix-setpassword-for-rhel5 into

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/log_time into lp:cloud-init

2013-07-30 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/log_time into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/log_time/+merge/177666 add util.log_time helper The reason

[Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/smartos_base64 into lp:cloud-init

2013-07-30 Thread Scott Moser
You have been requested to review the proposed merge of lp:~utlemming/cloud-init/smartos_base64 into lp:cloud-init. For more details, see: https://code.launchpad.net/~utlemming/cloud-init/smartos_base64/+merge/177716 Added base64 support for parsing meta-data values. SmartOS CLI tools will

Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/smartos_base64 into lp:cloud-init

2013-08-05 Thread Scott Moser
for getting config out of sys_config, you need to get at sysconfig['datasource']['smartos']. if you've called DataSource's __init__, it will have set .ds_cfg for you. class DataSource(object): __metaclass__ = abc.ABCMeta def __init__(self, sys_cfg, distro, paths, ud_proc=None):

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-seedy into lp:cloud-init

2013-09-03 Thread Scott Moser
What about just a cc_dev_random_seed that read from datasource.random_seed() if available ? The only reason I'd lean that way is that azure also provides random seed data. We'd just want the cc_dev_random_seed to early in the init_modules. --

Re: [Cloud-init-dev] Modify the filesystem UUID

2013-09-04 Thread Scott Moser
On Wed, 4 Sep 2013, Haefliger, Juerg wrote: All, OpenStack supports a rescue feature that allows a user to try to fix a broken instance. The way it works is that if you engage it, a new instance (the rescue instance) is booted using the same Glance image as the 'broken' instance and the

Re: [Cloud-init-dev] [Merge] lp:~gholms/cloud-init/rsyslog-programname into lp:cloud-init

2013-09-25 Thread Scott Moser
So, I'm not terribly opposed to this. But I'd like to know what was wrong, and why we're changing it more than doesn't seem to be working. When it does work fine for many people. I did test that on ubuntu (saucy) the change seems to work. --

Re: [Cloud-init-dev] [Merge] lp:~nrdlngr/cloud-init/erics-branch into lp:cloud-init

2013-10-01 Thread Scott Moser
can you show output of failed 'make test' ? It works fine for me on trunk on saucy, and fine on precise (python 2.7.3) once I got python-jsonpatch and python-json-pointer from saucy. -- https://code.launchpad.net/~nrdlngr/cloud-init/erics-branch/+merge/188723 Your team cloud init development

Re: [Cloud-init-dev] [Merge] lp:~nrdlngr/cloud-init/erics-branch into lp:cloud-init

2013-10-01 Thread Scott Moser
actually i see what you meant. ./tools/run-pep8 fails on precise but passes on saucy. -- https://code.launchpad.net/~nrdlngr/cloud-init/erics-branch/+merge/188723 Your team cloud init development team is requested to review the proposed merge of lp:~nrdlngr/cloud-init/erics-branch into

Re: [Cloud-init-dev] [Merge] lp:~nrdlngr/cloud-init/erics-branch into lp:cloud-init

2013-10-01 Thread Scott Moser
would you be opposed to using : mkpasswd --method=SHA-512 --rounds=4096 In general wherever possible I prefer documentation using long format flags. -- https://code.launchpad.net/~nrdlngr/cloud-init/erics-branch/+merge/188723 Your team cloud init development team is requested to review the

Re: [Cloud-init-dev] growpart fails on Fedora

2013-10-08 Thread Scott Moser
On Tue, 8 Oct 2013, Haefliger, Juerg wrote: All, I have an issue with the growpart/growroot scripts on Fedora 20. The problem is that after growroot resized the root partition (in initramfs), systemd automatically re-mounts it and then growroot croaks because it can't remount root (again).

[Cloud-init-dev] [Merge] lp:~harm-o/cloud-init/freebsd into lp:cloud-init

2013-12-06 Thread Scott Moser
Scott Moser has proposed merging lp:~harm-o/cloud-init/freebsd into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harm-o/cloud-init/freebsd/+merge/198130 initial freebsd support. -- https

Re: [Cloud-init-dev] [Merge] lp:~pquerna/cloud-init/allow-configdrive-in-partitions into lp:cloud-init

2014-01-07 Thread Scott Moser
Is there a reason that you're wanting to look at partitions ? This datasource is explicitly written to work with the openstack config drive. To my knowledge, openstack will never attach a config drive as a partition. I can't seem to any reasonable documentation on config drive, but I know that

[Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/pep8-cleanup into lp:cloud-init

2014-01-23 Thread Scott Moser
The proposal to merge lp:~utlemming/cloud-init/pep8-cleanup into lp:cloud-init has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~utlemming/cloud-init/pep8-cleanup/+merge/186689 --

Re: [Cloud-init-dev] [Merge] lp:~vlastimil-holer/cloud-init/fix-rpm-build into lp:cloud-init

2014-02-10 Thread Scott Moser
Vlastimil, I'm confused as to what the 'sudo' file's purpose is. cloudinit/distros/__init__.py writes the file when necessary. the other stuff seems necessary. -- https://code.launchpad.net/~vlastimil-holer/cloud-init/fix-rpm-build/+merge/204266 Your team cloud init development team is

Re: [Cloud-init-dev] [Merge] lp:~vlastimil-holer/cloud-init/fix-rpm-build into lp:cloud-init

2014-02-10 Thread Scott Moser
Vlastimil, I went ahead and merged this into revno 937, but left out the sudo Please raise another proposal for that and better explain what your needs are there. Scott -- https://code.launchpad.net/~vlastimil-holer/cloud-init/fix-rpm-build/+merge/204266 Your team cloud init development

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

2014-02-10 Thread Scott Moser
Vaidas, Hi, and thanks for the merge proposal. Some things I see: * https://launchpad.net/bugs/1040200 raised that 'instance-data' in ec2 datasource, should be 'instance-data.' so that dns lookups cannot be affected by dns search path insertion attack. ie, we want:

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

2014-02-12 Thread Scott Moser
OK, for reference: === gce == $ host metadata. Host metadata. not found: 3(NXDOMAIN) $ host metadata metadata.google.internal has address 169.254.169.254 Host metadata.google.internal not found: 3(NXDOMAIN) Host metadata.google.internal not found: 3(NXDOMAIN) $ host metadata.google.internal.

Re: [Cloud-init-dev] [Merge] lp:~nathan-house-0/cloud-init/gentoo-arch into lp:cloud-init

2014-02-12 Thread Scott Moser
Hey, thanks. this looks great. I did a few cleanups and proposed a merge into this branch (https://code.launchpad.net/~smoser/cloud-init/gentoo-arch/+merge/206047). We already had something like your 'is_excluded' logic in reverse. The modules are able to declare 'distros' that they are verfied

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

2014-02-12 Thread Scott Moser
Vaidas, I just proposed a merge into this branch at https://code.launchpad.net/~smoser/cloud-init/add-gce-datasource/+merge/206070 . That seems reasonable to me on how to configure the metadata_url and get out early if there i sno datasource. So the 2 things we're waiting on are: a.) tests

Re: [Cloud-init-dev] [Merge] lp:~jablonskis/cloud-init/add-gce-datasource into lp:cloud-init

2014-02-13 Thread Scott Moser
OK. I just merged this into trunk. I did some little changes, hopefully not breaking anything. I still expect some tests on this, and any other clenaups you can do, but I wanted to get it pulled in. Just do additional changes as another merge proposal. Thank you very much Vaidas. --

Re: [Cloud-init-dev] [Merge] lp:~kotcauer/cloud-init/cloud-init into lp:cloud-init

2014-03-27 Thread Scott Moser
Hi, The idea of supporting user-data in base64 is fine, and common across many other datasources However, you can't just attempt to decode user-data as base64 and if that works assume the user wanted you to. There could be people providing base64 code to cloud-init that they intended to

Re: [Cloud-init-dev] [Merge] lp:~rjschwei/cloud-init/openSUSEsupport into lp:cloud-init

2014-03-27 Thread Scott Moser
This looks fine, sorry its taken me so long to look at it. Is there a specific rason for the hosts template? -- https://code.launchpad.net/~rjschwei/cloud-init/openSUSEsupport/+merge/210899 Your team cloud init development team is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] lp:~rjschwei/cloud-init/openSUSEsupport into lp:cloud-init

2014-03-27 Thread Scott Moser
please avoid hard coded paths and instead use 'util.which'. ie: - if os.path.exists('/usr/bin/hostnamectl'): + if util.which('hostnamectl'): -- https://code.launchpad.net/~rjschwei/cloud-init/openSUSEsupport/+merge/210899 Your team cloud init development team is requested to review the

[Cloud-init-dev] [Merge] lp:~kotcauer/cloud-init/cloud-init into lp:cloud-init

2014-03-27 Thread Scott Moser
The proposal to merge lp:~kotcauer/cloud-init/cloud-init into lp:cloud-init has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~kotcauer/cloud-init/cloud-init/+merge/211341 --

Re: [Cloud-init-dev] [Merge] lp:~rjschwei/cloud-init/openSUSEsupport into lp:cloud-init

2014-03-27 Thread Scott Moser
Hi, I fixed up a few things and proposed a branch for merging into this one. https://code.launchpad.net/~smoser/cloud-init/openSUSEsupport/+merge/213075 merge that in, please. Then, the remaining issue that I see is (_exists, contents) = self._read_conf(filename) there is no '_read_conf'

[Cloud-init-dev] cloud-init 0.7.5 released

2014-04-02 Thread Scott Moser
Hello all, I released 0.7.5 of cloud-init yesterday. Source tarball is available for download from https://launchpad.net/cloud-init/trunk/0.7.5 . Cloud-init 0.7.5 contains many improvements and bugfixes over 0.7.4 and contained source code contributions from 14 developers. Thanks to all those

Re: [Cloud-init-dev] [Merge] lp:~kiril-vladimiroff/cloud-init/cloudsigma-vendordata into lp:cloud-init

2014-04-11 Thread Scott Moser
My only comment is 'vendor_data' versus 'vendor-data'. The other key here is 'cloudinit-user-data' (using '-' rather than '_'). inconsistency seems non-ideal unless theres something i'm missing. -- https://code.launchpad.net/~kiril-vladimiroff/cloud-init/cloudsigma-vendordata/+merge/214763

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/monotonic-compat into lp:cloud-init

2014-06-03 Thread Scott Moser
bah. i can't easily use monotime in ubuntu, and given that i hope python2 cloud-init's life is short, i figure we might as well find another workaround. perhaps we can use a read of /proc/uptime, which is much less than ideal, but would probably work for the few places where we really need it.

Re: [Cloud-init-dev] [Merge] lp:~jordane/cloud-init/sshd-systemd-fix into lp:cloud-init

2014-07-14 Thread Scott Moser
Hi jordan, is this necessary? In Ubuntu, my experience is that sshd actually does the right thing. On each connection, it will check keys. Ie, you can start sshd whenever, and cloud-init will write the keys later, and ssh will deny connections until those keys are found. that is a bit

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/changeable-templates into lp:cloud-init

2014-07-16 Thread Scott Moser
Josh, Thank you. This looks great. The only thing I'd like to suggest is that we dont stack trace on failed import of jinja or cheetah, but rather fail to render loudly (possibly even with stack trace) if that engine is necessary. Ie, your code makes it so we only need cheetah if there

[Cloud-init-dev] [Merge] lp:~josephbajin/cloud-init/freebsd-configdrive into lp:cloud-init

2014-08-18 Thread Scott Moser
Scott Moser has proposed merging lp:~josephbajin/cloud-init/freebsd-configdrive into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~josephbajin/cloud-init/freebsd-configdrive/+merge/231214 -- https

Re: [Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-22 Thread Scott Moser
some comments: a.) please merge/pull the changes i have in my branch at lp:~smoser/cloud-init/freebsd-cleanups b.) test_simple_write_freebsd is failing for me on ubuntu I think that cloud.freebsd.cfg can't be put into config/ as I think it will be copied/installed/used on linux and screw things

Re: [Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-24 Thread Scott Moser
The test that fails is the one you added. it fails because I'm running it on linux, where there is no /etc/rc.conf. I stuffed a 'raise Exception(FOO)' in to show the stack trace. == ERROR: test_simple_write_freebsd

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/freebsd-configdrive into lp:cloud-init

2014-09-22 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/freebsd-configdrive into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/freebsd-configdrive/+merge/235512 support 'mtype' as a list

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/freebsd-configdrive into lp:cloud-init

2014-09-29 Thread Scott Moser
ok. - platform: FIXED this was suppose to be platform.system() which is not returned by 'system_info'. that should show either 'Linux' or 'Freebsd' - mountinfo / exc not defined : FIXED cleaned that up a bit. 'mtypes' will now get a [''] for the case that you hit where there is no

[Cloud-init-dev] cloud-init 0.7.6 released

2014-10-10 Thread Scott Moser
Hello all, I released 0.7.6 of cloud-init today. Source tarball is available for download from https://launchpad.net/cloud-init/trunk/0.7.6 Thanks to all that contributed. Cloud-init 0.7.6 contains bug fixes and improvements including: - much improved freebsd support, including support for

Re: [Cloud-init-dev] [Merge] lp:~nshrader/cloud-init/digitalocean-datasource into lp:cloud-init

2014-10-16 Thread Scott Moser
This generally looks fine. In reading, a couple thoughts. a.) i was able to use the metadata crawler code to crawl the metadata service. code: http://paste.ubuntu.com/8404509/ output: http://paste.ubuntu.com/8404520/ I kind of like the idea of re-using that since digital ocean went

Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/no_demidecode into lp:cloud-init

2015-01-16 Thread Scott Moser
sadly, i dont think this is as easy as we'd like. we were using dmidecode on freebsd also. so taking this would almost certainly break freebsd. -- https://code.launchpad.net/~utlemming/cloud-init/no_demidecode/+merge/246486 Your team cloud init development team is requested to review the

Re: [Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/lp1375252 into lp:cloud-init

2015-02-24 Thread Scott Moser
on shutdown/startup, the configured network interface is still brought up (by ubuntu). its just not cycled by cloud-init. that bringup will use the configured hostname as seen in /etc/hostname, which should have been updated. --

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-20 Thread Scott Moser
My only real comment is that I thikn i'd take 'get_metadata' out of 'get_data'. You can either move it to a stand alone method or a class method. either way, moving it out allows to easier patch it for testing. --

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/walinux-wip into lp:cloud-init

2015-05-14 Thread Scott Moser
Dan, this looks really nice. thank you. Can you put together a commit message and i'll pull. sm -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/walinux-wip/+merge/258644 Your team cloud init development team is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] lp:~brak/cloud-init/centos-7-fixes into lp:cloud-init

2015-05-14 Thread Scott Moser
Brian, Hi this looks fine. I need you to fill out the contributors agreement in order to accept. Sorry that it has taken so long for me to get to this. follow 'sign the contributor agreement' at http://www.ubuntu.com/legal/contributors --

Re: [Cloud-init-dev] [Merge] lp:~bbaude/cloud-init/rh_subscription into lp:cloud-init

2015-05-15 Thread Scott Moser
Brent, this looks good, thanks for submitting. a couple other minor things a.) please don't use 'log.info' more than once. that goes to the console or cloud-init's stdout. and i dont really want cloud-init to spam the console with everything looks good types of messages. a single

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1464253 into lp:cloud-init

2015-06-15 Thread Scott Moser
Changes are fine, but you have to fix the tests also. currently failing. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1464253/+merge/261849 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/lp1464253 into

Re: [Cloud-init-dev] [Merge] lp:~xnox/cloud-init/refactor-dev-root into lp:cloud-init

2015-05-26 Thread Scott Moser
curious, where do you see multiple root= ? is that a common thing? current code takes first root=, yours takes second. I'm guessing from you suggesting this that kernel picks the second if two root= are found. but just want to make sure. also, reading cmdline doesn't make sense in a container

Re: [Cloud-init-dev] [Merge] lp:~xnox/cloud-init/refactor-dev-root into lp:cloud-init

2015-05-26 Thread Scott Moser
I dont think so. without something like lxcfs, the /proc/cmdline in the container is the host's /proc/cmdline. so that 'root=' (whether it be /dev/sda1 or LABEL=) is not destined for this container. with lxcfs, that might be different (hopefully it will be). But /proc/mountinfo is namepsaced,

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.reporting into lp:cloud-init

2015-07-31 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.reporting into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/trunk.reporting/+merge/266578 This is a backport of the 2.0

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.reporting into lp:cloud-init

2015-07-31 Thread Scott Moser
thanks. addressed and pushing now. Diff comments: === added file 'cloudinit/reporting.py' --- cloudinit/reporting.py1970-01-01 00:00:00 + +++ cloudinit/reporting.py2015-07-31 14:49:49 + @@ -0,0 +1,201 @@ +# Copyright 2015 Canonical Ltd. +# This file is part of

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/fix-mock-tests into lp:cloud-init

2015-07-21 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/fix-mock-tests into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/fix-mock-tests/+merge/265410 -- Your team cloud init development team

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1411582 into lp:cloud-init

2015-07-17 Thread Scott Moser
mostly fine. how does the udev rule get installed? i guess i'd like packaging in trunk updated too. Diff comments: === modified file 'cloudinit/sources/DataSourceAzure.py' --- cloudinit/sources/DataSourceAzure.py 2015-05-22 16:28:17 + +++ cloudinit/sources/DataSourceAzure.py

Re: [Cloud-init-dev] [Merge] lp:~edouardb/cloud-init/scaleway-datasource into lp:cloud-init

2015-10-28 Thread Scott Moser
Julien, Thanks. for 'd', sure you can add vendor-data later. if its not in the cloud provider anyway, not much use for cluod-init to support it. The big issue is just 'b'. We can't enable by default without solid way of knowing that we should hit a http source that might hang indefinitely.

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2015-10-19 Thread Scott Moser
some comments inline. other thing.. it seems like it would make sense to partition assuming sectors of 4096 bytes. just to ensure alignment or to round all partition sizes to 1MB or even 4MB. if the user has just given us such course grained data as percentage, it seems we have some wiggle

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2015-10-19 Thread Scott Moser
Dan and I discussed some and both of us were not sure if sfdisk's sectors were physical or logical sectors. I did some testing with kvm and it turns out it uses logical sectors. That unit is the same you'd get back from 'blockdev --getss' that value can also be read from /sys/ see

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1460715 into lp:cloud-init

2015-10-20 Thread Scott Moser
I'd like to read /sys if we can. blockdev is fine, but that costs us 2 subprocesses for information that we could conceivably read. one last comment i should have added for reference later was that an example qemu command line where we provide all the sizes is like: qemu-system-x86_64

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.doc-seedrandom into lp:cloud-init

2015-10-20 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.doc-seedrandom into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/trunk.doc-seedrandom/+merge/275062 Doc: document random_seed

Re: [Cloud-init-dev] [Merge] lp:~edouardb/cloud-init/scaleway-datasource into lp:cloud-init

2015-10-20 Thread Scott Moser
Hey, This looks well done, thanks. A couple comments a.) we'll need some unit tests to ensure we dont inadvertently break this. b.) is there some way (anyway) we can detect if we're on scaleway? As it is right now, it looks like we're just going to block and retry for the availability of the

Re: [Cloud-init-dev] [Merge] lp:~edouardb/cloud-init/scaleway-datasource into lp:cloud-init

2015-11-13 Thread Scott Moser
two nitpicks. but this looks good other than failing tests. b Diff comments: > === added file 'cloudinit/sources/DataSourceScaleway.py' > --- cloudinit/sources/DataSourceScaleway.py 1970-01-01 00:00:00 + > +++ cloudinit/sources/DataSourceScaleway.py 2015-10-28 09:51:17 + > @@ -0,0

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/shim_fixes into lp:cloud-init

2015-09-24 Thread Scott Moser
Odd_Bloke, it seems maybe the part find_endpoint after 'No endpoint found in DHCP config.' could/should be its own method . and then some tests on it. maybe 'extract_value_from_leases_key' or something like that. other thing, is if you're just reading your two test cases that you added, its

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init

2016-06-02 Thread Scott Moser
Testing I've done. ### Joyent ### ## launched a wily instance on joyent # make login not run apt-update as painful slow sudo sed -i '/^[^#].*pam_motd/s/^/#/' /etc/pam.d/sshd # add new cloud-init to apt sudo sh -c 'apt-add-repository -y ppa:smoser/cloud-init-dev && sudo apt-get update && sudo

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init

2016-06-02 Thread Scott Moser
this is available at https://launchpad.net/~smoser/+archive/ubuntu/cloud-init-dev . -- https://code.launchpad.net/~smoser/cloud-init/trunk.fix-networking/+merge/296272 Your team cloud init development team is requested to review the proposed merge of lp:~smoser/cloud-init/trunk.fix-networking

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init

2016-06-02 Thread Scott Moser
the one change left here is i think to make openstack config drive datasource not use 'id' as the nic namne as those are arbitrary. -- https://code.launchpad.net/~smoser/cloud-init/trunk.fix-networking/+merge/296272 Your team cloud init development team is requested to review the proposed merge

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.1590104 into lp:cloud-init

2016-06-07 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.1590104 into lp:cloud-init has been updated. Commit Message changed to: make networking config provided in system config override datasource. while datasource provided networking is more dynamic in most cases, preference should still be given

Re: [Cloud-init-dev] [Merge] lp:~paelzer/cloud-init/bug-1589174-fix-tests-in-adt-env into lp:cloud-init

2016-06-07 Thread Scott Moser
mostly looks good. a couple comments. thank you. Diff comments: > > === modified file 'cloudinit/util.py' > --- cloudinit/util.py 2016-05-24 15:58:18 + > +++ cloudinit/util.py 2016-06-07 16:05:31 + > @@ -2234,3 +2234,41 @@ > if sys.version_info[:2] < (2, 7): > return

Re: [Cloud-init-dev] [Merge] lp:~ifeoktistov/cloud-init/remotedisk-setup into lp:cloud-init

2016-06-10 Thread Scott Moser
Hi, thanks for the merge proposal. sorry for the long lag in looking at it. This looks interesting, I'll try to take a more deep look at it next week. -- https://code.launchpad.net/~ifeoktistov/cloud-init/remotedisk-setup/+merge/294055 Your team cloud init development team is requested to review

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-net-refactor into lp:cloud-init

2016-06-10 Thread Scott Moser
Hey. Grab Hi. grab http://paste.ubuntu.com/17185178/ and please remove 'skip_first_boot' and then go ahead and merge into trunk. -- https://code.launchpad.net/~harlowja/cloud-init/cloud-init-net-refactor/+merge/293957 Your team cloud init development team is requested to review the proposed

[Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-net-refactor into lp:cloud-init

2016-06-10 Thread Scott Moser
The proposal to merge lp:~harlowja/cloud-init/cloud-init-net-refactor into lp:cloud-init has been updated. Commit Message changed to: Refactor a large part of the networking code. Splits off distro specific code into specific files so that other kinds of networking configuration can be written

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.1590104 into lp:cloud-init

2016-06-07 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.1590104 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1590104 in cloud-init: "network config from datasource overrides network config from system&quo

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.joyent-cleanup into lp:cloud-init

2016-05-27 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.joyent-cleanup into lp:cloud-init has been updated. Commit Message changed to: smartos: separate client out of datasource and support network config This does: * support reading 'sdc:nics' and converting it to internal 'network-config'

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.joyent-cleanup into lp:cloud-init

2016-05-27 Thread Scott Moser
note, this does depend on https://code.launchpad.net/~smoser/cloud-init/trunk.fix-networking/ in order to have the datasource sanely declare that it is 'local'. Otherwise user-data would be pulled and such at local point (without networking). --

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init

2016-06-01 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init has been updated. Description changed to: I'll improve this description later. DataSource Mode (dsmode) is present in many datasources in cloud-init. dsmode was originally added to cloud-init to specify

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init

2016-06-01 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init has been updated. Description changed to: I'll improve this description later.   DataSource Mode (dsmode) is present in many datasources in cloud-init.   dsmode was originally added to cloud-init to specify

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init

2016-06-01 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.fix-networking into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1577844 in ifupdown (Ubuntu): "Drop unnecessary blocking of all net udev rules" https://bugs.lau

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-net-sysconfig into lp:cloud-init

2016-06-15 Thread Scott Moser
links_prefix support would be ncie in the renderer. for persistent naming with systemd.link that might be shared with eni -- https://code.launchpad.net/~harlowja/cloud-init/cloud-init-net-sysconfig/+merge/297115 Your team cloud init development team is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-net-sysconfig into lp:cloud-init

2016-06-15 Thread Scott Moser
remove your print statements. i guess go ahead and fix the TODO that you added. running 'tox' fails for me, always good to fix that . the rest of it looks reasonable. Diff comments: > > === added file 'cloudinit/net/sysconfig.py' > --- cloudinit/net/sysconfig.py1970-01-01 00:00:00

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-06-21 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/trunk.net-improve-lo-dns/+merge/298035 -- Your team cloud

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-06-21 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init has been updated. Commit Message changed to: improvements to eni rendering Some improvements here, and some bug fixes.  - bring curtin revno 394's change to support post-up for interface aliases.  - sort

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-06-21 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init has been updated. Commit Message changed to: improvements to eni rendering Some improvements here, and some bug fixes. - bring curtin revno 394's change to support post-up for interface aliases. - sort

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-06-21 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init has been updated. Commit Message changed to: improvements to eni rendering Some improvements here, and some bug fixes.  - bring curtin revno 394's change to support post-up for interface aliases.  - sort

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-06-21 Thread Scott Moser
passes tox and the 3 added tests now. The tests are somewhat brittle as they expect exactly rendered ENI content for the provided network yaml. -- https://code.launchpad.net/~smoser/cloud-init/trunk.net-improve-lo-dns/+merge/298035 Your team cloud init development team is requested to review

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.1532072 into lp:cloud-init

2016-06-21 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.1532072 into lp:cloud-init has been updated. Commit Message changed to: user_data: fix error when user-data is not utf-8 decodable when user-data was not decodable, cloud-init would raise exception. This also changes the signature of

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.1532072 into lp:cloud-init

2016-06-21 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.1532072 into lp:cloud-init. Commit message: user_data: fix error when user-data is not utf-8 decodable when user-data was not decodable, cloud-init would raise exception. This also changes the signature of user_data.convert_string

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-up-cli into lp:cloud-init

2016-06-15 Thread Scott Moser
can you merge with trunk now ? there is one conflict, and what i think you end up needing is just http://paste.ubuntu.com/17386285/ -- https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-up-cli/+merge/297409 Your team cloud init development team is requested to review the proposed

Re: [Cloud-init-dev] [Merge] lp:~harlowja/cloud-init/cloud-init-fix-up-cli into lp:cloud-init

2016-06-15 Thread Scott Moser
oops. wrong mp -- https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-up-cli/+merge/297409 Your team cloud init development team is requested to review the proposed merge of lp:~harlowja/cloud-init/cloud-init-fix-up-cli into lp:cloud-init.

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.1592505 into lp:cloud-init

2016-06-15 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.1592505 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1592505 in cloud-init: "stack trace on reboot with NoCloud datasource on reboot" https://bugs.launchpad

  1   2   3   4   5   6   7   8   9   10   >