Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8527e3d86c150997407722aeccaaf894e9ada42b https://jenkins.ubuntu.com/server/job/cloud-init-ci/579/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-21 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master. Commit message: helpers/openstack: Treat unknown link types as physical Some deployments of OpenStack expose link types to the guest which cloud-init doesn't recognise. These will

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-21 Thread Ryan Harper
This looks good. You can see the existing openstack network_data.json samples in: tests/unittests/test_net.py line 426 of 4185 OS_SAMPLES That shows the general structure. Another one is in tests/unittests/test_datasource/test_configdrive.py --

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-21 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/363421 -- Your team

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Ryan Harper
If we're going to touch this, maybe we could get a wider list from whatever openstack has there now? https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/network/model.py -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/363421

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:5b041496005975cbaf63c1c996814901bb0d6894 https://jenkins.ubuntu.com/server/job/cloud-init-ci/568/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:e356bb117e48f6497d4e747c131c738c5d4a41ec https://jenkins.ubuntu.com/server/job/cloud-init-ci/567/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Dan Watkins
The proposal to merge ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master has been updated. Commit message changed to: helpers/openstack: Add macvlan to link types This enables the use of macvlan interfaces within older versions of OpenStack. LP: #1639263 For more

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:e356bb117e48f6497d4e747c131c738c5d4a41ec No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master

2019-02-20 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:macvtap into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1639263 in cloud-init: " cloud-init Unknown network_data link type: macvtap"