[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-16 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master. Commit message: DataSourceOracle: prefer DS network config over initramfs DataSourceOracle.network_config merges the initramfs configuration with configuration from OCI's IMDS, so

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-08 Thread Dan Watkins
Made some changes locally, still thinking about one other. (Not pushing them up until all comments are addressed, so I don't have to go digging to find the current set of comments.) Diff comments: > diff --git a/cloudinit/sources/DataSourceOracle.py > b/cloudinit/sources/DataSourceOracle.py

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-08 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/sources/DataSourceOracle.py > b/cloudinit/sources/DataSourceOracle.py > index 76cfa38..f18e5a0 100644 > --- a/cloudinit/sources/DataSourceOracle.py > +++ b/cloudinit/sources/DataSourceOracle.py > @@ -121,6 +190,14 @@ class

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-08 Thread Dan Watkins
Thanks for the reviews! Responses inline. Diff comments: > diff --git a/cloudinit/sources/DataSourceOracle.py > b/cloudinit/sources/DataSourceOracle.py > index 76cfa38..f18e5a0 100644 > --- a/cloudinit/sources/DataSourceOracle.py > +++ b/cloudinit/sources/DataSourceOracle.py > @@ -28,8 +28,70

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-08 Thread Ryan Harper
Looks good. A few in-line questions. Diff comments: > diff --git a/cloudinit/sources/DataSourceOracle.py > b/cloudinit/sources/DataSourceOracle.py > index 76cfa38..f18e5a0 100644 > --- a/cloudinit/sources/DataSourceOracle.py > +++ b/cloudinit/sources/DataSourceOracle.py > @@ -28,8 +28,70 @@

Re: [Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-08 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/sources/DataSourceOracle.py > b/cloudinit/sources/DataSourceOracle.py > index 76cfa38..f18e5a0 100644 > --- a/cloudinit/sources/DataSourceOracle.py > +++ b/cloudinit/sources/DataSourceOracle.py > @@ -28,8 +28,70 @@ import re > > LOG =

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-08 Thread Dan Watkins
You have been requested to review the proposed merge of ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master. For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/371053 -- Your team cloud-init commiters is requested

[Cloud-init-dev] [Merge] ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master

2019-08-07 Thread Dan Watkins
Dan Watkins has proposed merging ~daniel-thewatkins/cloud-init/+git/cloud-init:oci-vnic into cloud-init:master. Commit message: WIP: DataSourceOracle: configure secondary NICs on Virtual Machines Oracle Cloud Infrastructure's Instance Metadata Service provides network configuration