Re: [Cloud-init-dev] [Merge] ~harald-jensas/cloud-init:bug/1847517 into cloud-init:master

2019-10-11 Thread Harald Jensås
Oh, I noticed now I missed the comment in code. I will update this to check specifically for the values we expect and raise an error for other cases. -- https://code.launchpad.net/~harald-jensas/cloud-init/+git/cloud-init/+merge/373932 Your team cloud-init Commiters is requested to review the

Re: [Cloud-init-dev] [Merge] ~harald-jensas/cloud-init:bug/1847517 into cloud-init:master

2019-10-11 Thread Harald Jensås
> thanks for the well done bug report and merge proposal! > > Please add a test to the unfortunately long and difficult to follow > tests/unittests/test_net.py . > Thanks, I did'nt find these tests in my first iteration. I added tests in tests/unittests/test_datasource/test_configdrive.py and

Re: [Cloud-init-dev] [Merge] ~harald-jensas/cloud-init:bug/1847517 into cloud-init:master

2019-10-10 Thread Scott Moser
thanks for the well done bug report and merge proposal! Please add a test to the unfortunately long and difficult to follow tests/unittests/test_net.py . Also, as this is your first submission: To contribute, you must sign the Canonical Contributor License Agreement (CLA) [1]. If you have

[Cloud-init-dev] [Merge] ~harald-jensas/cloud-init:bug/1847517 into cloud-init:master

2019-10-09 Thread Harald Jensås
Harald Jensås has proposed merging ~harald-jensas/cloud-init:bug/1847517 into cloud-init:master. Requested reviews: cloud-init Commiters (cloud-init-dev) Related bugs: Bug #1847517 in cloud-init: "cloudinit/net/sysconfig.py write incorrect config for dhcp-stateless openstack subnets"