Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-06 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:7375eec73e00b622f149527afd93a812dac7be68 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1105/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-04 Thread Scott Moser
Diff comments: > diff --git a/doc/rtd/topics/docs.rst b/doc/rtd/topics/docs.rst > new file mode 100644 > index 000..890f2f5 > --- /dev/null > +++ b/doc/rtd/topics/docs.rst > @@ -0,0 +1,83 @@ > +.. _docs: > + > +Docs > + > + > +These docs are hosted on Read the Docs. The following will e

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-04 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8a19f935dd5bc037ef74e1820b73c1a38b421450 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1104/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-04 Thread Scott Moser
Diff comments: > diff --git a/doc/rtd/conf.py b/doc/rtd/conf.py > index 4174477..9b27484 100644 > --- a/doc/rtd/conf.py > +++ b/doc/rtd/conf.py > @@ -17,7 +17,8 @@ from cloudinit.config.schema import get_schema_doc > # ] > > # General information about the project. > -project = 'Cloud-Init'

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-04 Thread Joshua Powers
Thanks for the reviews. Fixed the commit message and responded to comments below. Diff comments: > diff --git a/doc/rtd/conf.py b/doc/rtd/conf.py > index 4174477..9b27484 100644 > --- a/doc/rtd/conf.py > +++ b/doc/rtd/conf.py > @@ -17,7 +17,8 @@ from cloudinit.config.schema import get_schema_doc

[Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-04 Thread Joshua Powers
The proposal to merge ~powersj/cloud-init:docs/config-tox into cloud-init:master has been updated. Commit message changed to: doc: document doc, create makefile and tox target * Create makefile and tox targets for documentation building and testing to better replicate the live web docs using th

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-04 Thread Scott Moser
I don't personally feel the need to have 'make doc' at all, but its not a problem to have it. In the commit message subject line you have 'create markefile' Diff comments: > diff --git a/doc/rtd/conf.py b/doc/rtd/conf.py > index 4174477..9b27484 100644 > --- a/doc/rtd/conf.py > +++ b/doc/rtd/co

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-09-04 Thread Dan Watkins
Diff comments: > diff --git a/doc/rtd/topics/docs.rst b/doc/rtd/topics/docs.rst > new file mode 100644 > index 000..af2a3fb > --- /dev/null > +++ b/doc/rtd/topics/docs.rst > @@ -0,0 +1,83 @@ > +.. _docs: > + > +Docs > + > + > +These docs are hosted on Read the Docs. The following will e

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:3366a331a27d601159604fa1a4531167a45da623 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1102/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-08-30 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:docs/config-tox into cloud-init:master. Commit message: doc: document doc, create markefile and tox target * Create makefile and tox targets for documentation building and testing to better replicate the live web docs using the same theme. *