Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:bug-lp-1709180-v2-params into cloud-init:master

2017-08-10 Thread Chad Smith
Approved with minor nits questions inline. +1! Validated and inspected netplan output with the following: PYTHONPATH=. ./tools/net-convert.py --network-data=net-config.yaml --kind=yaml --output-kind=netplan --directory=out.d --mac=eth0,52:54:00:12:34:00 --mac=ens4,52:54:00:12:34:02 Prior to t

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:bug-lp-1709180-v2-params into cloud-init:master

2017-08-09 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:09863394a2119a9e91d34abdfab7e2f14205d053 https://jenkins.ubuntu.com/server/job/cloud-init-ci/131/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~raharper/cloud-init:bug-lp-1709180-v2-params into cloud-init:master

2017-08-09 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:bug-lp-1709180-v2-params into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1709180 in cloud-init: "cloud-init v2 yaml doesn't preserve bond/bridge parameters when rendering" https://bugs