[Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-04-12 Thread Ryan Harper
The proposal to merge ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/342102 -- Your team cloud-init co

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-27 Thread Scott Moser
I filed a bug https://bugs.launchpad.net/cloud-init/+bug/1759324 to handle "make network rendering cleanup after itself." -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/342102 Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-27 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c79e5fc9bbfa5c4c2d75a7684ee812e62eb5135d https://jenkins.ubuntu.com/server/job/cloud-init-ci/934/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-27 Thread Ryan Harper
Thanks for the review, fixing up most. We do have some discussion to be had re: sysconfig capture and redeploy w.r.t what files cloud-init will leave around, also cloud-init clean for network related configuration files. Diff comments: > diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-27 Thread Scott Moser
one useful comment/question and some nits. Diff comments: > diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py > index 39d89c4..87fb96e 100644 > --- a/cloudinit/net/sysconfig.py > +++ b/cloudinit/net/sysconfig.py > @@ -550,6 +550,26 @@ class Renderer(renderer.Renderer): >

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-26 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8fe387770dda040419468007f5f279f502ad32c1 https://jenkins.ubuntu.com/server/job/cloud-init-ci/930/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-26 Thread Ryan Harper
Ryan Harper has proposed merging ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/342102 -- Your team cloud

[Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-26 Thread Ryan Harper
The proposal to merge ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master has been updated. Commit Message changed to: net/sysconfig: handle global static routes Cloud-init network-config V1 format allows configuration of "global" static routes which are not direc