Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-06 Thread Ryan Harper
After some further discussion I think it's OK to expect that an image that has cloud-init will regenerate and remove ssh keys (on new instance) this is default cloud-init behavior. I do think we should Conflict, but I also understand not wanting to change systems which have ssh-keygen which is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-03 Thread Ryan Harper
On Fri, Aug 3, 2018 at 3:24 PM Scott Moser wrote: > > I really don't know what you're expecting to hear. The distro put in ssh-keygen service and presumably has a reason for doing so. They may have some expected properties of the types of keys that it generates and cloud-init could generate diff

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-03 Thread Scott Moser
I really don't know what you're expecting to hear. cloud-init is guaranteed to run Before ssh-keygen. Worst case, a.) ssh-keygen creates keys that cloud-init didn't write (but since cloud-init deleted *all* keys on new-instance, this actually works pretty well). b.) ssh-kegen does nothing and w

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-03 Thread Ryan Harper
On Fri, Aug 3, 2018 at 1:44 PM Scott Moser wrote: > > I'd really rather not conflict and play a game of roulette with systemd. Can we get a RH/Fedora person to weigh in on this then? > > -- > https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/349359 > Your team cloud-init commi

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-03 Thread Scott Moser
I'd really rather not conflict and play a game of roulette with systemd. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/349359 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-02 Thread Ryan Harper
On Thu, Aug 2, 2018 at 11:25 AM Scott Moser wrote: > > > On Wed, Aug 1, 2018 at 12:09 PM Scott Moser > > wrote: > > > > > > if we left it as null, it would not generate any keys. > > > We need it to generate keys. > > > > Why? isn't ssh-keygen service generating keys? > > That is the bug. We/ce

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-02 Thread Scott Moser
> On Wed, Aug 1, 2018 at 12:09 PM Scott Moser wrote: > > > > if we left it as null, it would not generate any keys. > > We need it to generate keys. > > Why? isn't ssh-keygen service generating keys? That is the bug. We/centos/fedora *were* delegating generation of host keys to ssh-keygen. Th

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-01 Thread Ryan Harper
On Wed, Aug 1, 2018 at 12:09 PM Scott Moser wrote: > > I do not think we should leave this line in the file. > Thats confusing. No other distro's cloud.cfg would > have such a line. > > > Diff comments: > > > diff --git a/config/cloud.cfg.tmpl b/config/cloud.cfg.tmpl > > index 5619de3..1fef133 10

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-08-01 Thread Scott Moser
I do not think we should leave this line in the file. Thats confusing. No other distro's cloud.cfg would have such a line. Diff comments: > diff --git a/config/cloud.cfg.tmpl b/config/cloud.cfg.tmpl > index 5619de3..1fef133 100644 > --- a/config/cloud.cfg.tmpl > +++ b/config/cloud.cfg.tmpl > @@

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-07-23 Thread Ryan Harper
Is it worth leaving a reference to this LP: # in the both the systemd unit file and with the genkeytypes? ssh_genkeytypes: null # LP: # Diff comments: > diff --git a/config/cloud.cfg.tmpl b/config/cloud.cfg.tmpl > index 5619de3..1fef133 100644 > --- a/config/cloud.cfg.tmpl > +++ b/c

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-07-11 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:cfcd65906982f8df63bf64e182ec75ad94c75990 https://jenkins.ubuntu.com/server/job/cloud-init-ci/156/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-07-11 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master has been updated. Commit message changed to: redhat: remove ssh keys on new instance. This changes redhat's default behavior to remove the ssh keys on new instance (ssh_deletekeys will now be at its defau

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master

2018-07-11 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1781094-ssh-deletekeys into cloud-init:master. Commit message: redhat: remove ssh keys on new instance. This changes redhat's default behavior to remove the ssh keys on new instance (ssh_deletekeys will now be at its default true value). O