Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1836949-mtu-lost-in-translation into cloud-init:master

2019-07-17 Thread Scott Moser
Diff comments: > diff --git a/tests/unittests/test_net.py b/tests/unittests/test_net.py > index de4e7f4..e2bbb84 100644 > --- a/tests/unittests/test_net.py > +++ b/tests/unittests/test_net.py > @@ -2856,6 +2856,97 @@ USERCTL=no > self._compare_files_to_expected(entry['expected_sysconfi

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1836949-mtu-lost-in-translation into cloud-init:master

2019-07-17 Thread Ryan Harper
Thanks. I swear I just was working on a branch for this very issue but I can't find any duplicate bugs. Inline question on what to do if bond/vlan sets MTU > than underlying device? Diff comments: > diff --git a/tests/unittests/test_net.py b/tests/unittests/test_net.py > index de4e7f4..e2bbb84

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1836949-mtu-lost-in-translation into cloud-init:master

2019-07-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:9f683c0221a7f926b86292b49882b2fe36f6fabe https://jenkins.ubuntu.com/server/job/cloud-init-ci/796/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1836949-mtu-lost-in-translation into cloud-init:master

2019-07-17 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1836949-mtu-lost-in-translation into cloud-init:master. Commit message: Fix bug rendering MTU on bond or vlan when input was netplan. If input to network_state.parse_net_config_data was netplan (v2 yaml) then the network state would lose th