Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Approve continuous-integration -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/371546 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Needs Fixing continuous-integration Autolanding: FAILED Unapproved changes made after approval. https://jenkins.ubuntu.com/server/job/cloud-init-autoland-test/297/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu L

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Approve continuous-integration -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/371546 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Needs Fixing continuous-integration Autolanding: FAILED More details in the following jenkins job: https://jenkins.ubuntu.com/server/job/cloud-init-autoland-test/296/ Executed test runs: FAILED: Checkout -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/3715

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Needs Fixing continuous-integration Autolanding: FAILED More details in the following jenkins job: https://jenkins.ubuntu.com/server/job/cloud-init-autoland-test/295/ Executed test runs: FAILED: Checkout -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/3715

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Dan Watkins
Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_drivers.py > b/cloudinit/config/cc_ubuntu_drivers.py > index 4da34ee..ff56775 100644 > --- a/cloudinit/config/cc_ubuntu_drivers.py > +++ b/cloudinit/config/cc_ubuntu_drivers.py > @@ -90,17 +118,28 @@ def install_drivers(cfg, pkg_install_

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Needs Fixing continuous-integration Autolanding: FAILED More details in the following jenkins job: https://jenkins.ubuntu.com/server/job/cloud-init-autoland-test/294/ Executed test runs: FAILED: Checkout -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/3715

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:19dbf5e1449cfa59b9f8fbfb056d182516543eb1 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1066/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:8da37261c56c583b1631cbae9910a100c7894c6e https://jenkins.ubuntu.com/server/job/cloud-init-ci/1065/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jen

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-22 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:cdd846983dc8d3dca53d3c37d69c0c967787a7ae https://jenkins.ubuntu.com/server/job/cloud-init-ci/1064/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-21 Thread Ryan Harper
Implementation looks great. One suggestion on the template description. Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_drivers.py > b/cloudinit/config/cc_ubuntu_drivers.py > index 4da34ee..fa3a2c0 100644 > --- a/cloudinit/config/cc_ubuntu_drivers.py > +++ b/cloudinit/config/cc_ubuntu_

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-21 Thread Chad Smith
Just validated on Eoan that this package properly sets up linux/nvidia/latelink true via debconf-get-selections. The ubuntu-drivers-common package fixes has not yet published to Eoan. So, end-to-end validation will not be possible until an updated ubuntu-drivers-common and linux-modules-nvidia

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-21 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:cdd846983dc8d3dca53d3c37d69c0c967787a7ae https://jenkins.ubuntu.com/server/job/cloud-init-ci/1063/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED: Ub

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-20 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_drivers.py > b/cloudinit/config/cc_ubuntu_drivers.py > index 4da34ee..44a2bfe 100644 > --- a/cloudinit/config/cc_ubuntu_drivers.py > +++ b/cloudinit/config/cc_ubuntu_drivers.py > @@ -65,6 +65,39 @@ OLD_UBUNTU_DRIVERS_STDERR_NEEDLE = ( >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1840080-ubuntu-drivers-emit-latelink-v2 into cloud-init:master

2019-08-20 Thread Ryan Harper
some inline comments/suggestions. Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_drivers.py > b/cloudinit/config/cc_ubuntu_drivers.py > index 4da34ee..44a2bfe 100644 > --- a/cloudinit/config/cc_ubuntu_drivers.py > +++ b/cloudinit/config/cc_ubuntu_drivers.py > @@ -65,6 +65,39 @@ OLD_UBU