Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:15a75ea17652fe825cc365aa58f1a85135ec0dfe https://jenkins.ubuntu.com/server/job/cloud-init-ci/402/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:928dab8e3f7fdea3f7b6e233ee67d9e581c4a71c https://jenkins.ubuntu.com/server/job/cloud-init-ci/401/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index 39391d0..2a6d5b1 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++ b/cloudinit/sources/DataSourceAzure.py > @@ -619,7 +622,14 @@ class

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Chad Smith
> Minor comment, but it isn't Xenial-only, but rather, Xenial and older; While > we've not SRU'd to trusty I think it's worth updating to comment locations to > indicate that this is relevant for Ubuntu releases which include ifupdown. Thanks Ryan fixed. --

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index 39391d0..11b4ba5 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++ b/cloudinit/sources/DataSourceAzure.py > @@ -207,7 +207,9 @@ BUILTIN_DS_CONFIG = { > }, >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Ryan Harper
Minor comment, but it isn't Xenial-only, but rather, Xenial and older; While we've not SRU'd to trusty I think it's worth updating to comment locations to indicate that this is relevant for Ubuntu releases which include ifupdown. --

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c8efde583fa58b2b1d3f8f5e32d70110bc6df6d8 https://jenkins.ubuntu.com/server/job/cloud-init-ci/400/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/azure-disable-imds-networking into cloud-init:master

2018-10-17 Thread Scott Moser
inline comments. Diff comments: > diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index 39391d0..11b4ba5 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++ b/cloudinit/sources/DataSourceAzure.py > @@ -207,7 +207,9 @@ BUILTIN_DS_CONFIG = { >