Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:eef890ab7bc4022e807b7f01505bb78c03487b0c https://jenkins.ubuntu.com/server/job/cloud-init-ci/869/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-16 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:5a4cd9e4aa874445bad3ac0af69bc583eeef8f96 https://jenkins.ubuntu.com/server/job/cloud-init-ci/868/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-16 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:962f98fe12f4215e8d1efd11f4c18a02c238ac88 https://jenkins.ubuntu.com/server/job/cloud-init-ci/865/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-16 Thread Scott Moser
We can probably just ditch the squashfuse stuff now. that is slated to be fixed "real soon now" under bug 1756173. Its not our problem, and this all works as long as snapd works. -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366 Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-16 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:db4f161207d8b7cac4dc2a8337b7adcf625d27d9 https://jenkins.ubuntu.com/server/job/cloud-init-ci/864/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Simon Poirier
Review: Approve +1 LGTM -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:feature/snap-module into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:a158a134a000178b180e016ba3dafd0633d5789f https://jenkins.ubuntu.com/server/job/cloud-init-ci/861/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py > new file mode 100644 > index 000..3210d6d > --- /dev/null > +++ b/cloudinit/config/cc_snap.py > @@ -0,0 +1,272 @@ > +# Copyright (C) 2018 Canonical Ltd. > +# > +# This file is part of cloud-init. See

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:fd11c422178edb75572ba0258369af3a074f6b3a https://jenkins.ubuntu.com/server/job/cloud-init-ci/858/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Simon Poirier
Diff comments: > diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py > new file mode 100644 > index 000..3210d6d > --- /dev/null > +++ b/cloudinit/config/cc_snap.py > @@ -0,0 +1,272 @@ > +# Copyright (C) 2018 Canonical Ltd. > +# > +# This file is part of cloud-init. See

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:357e9a9919e45b7455259f55db157f50859b0b28 https://jenkins.ubuntu.com/server/job/cloud-init-ci/857/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:88980f346d0c926559ce2be207acc3da2f9c8e98 https://jenkins.ubuntu.com/server/job/cloud-init-ci/855/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-15 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:743df1cd81eb55d0fc2670fa480a44d9445b3f5a https://jenkins.ubuntu.com/server/job/cloud-init-ci/853/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-14 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:70537d8c5989b99c647d8ee9b2c9f85bd25ba53f https://jenkins.ubuntu.com/server/job/cloud-init-ci/848/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-14 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:532a608e5a466cf9aab6214d255a62e9a8a2ac9c https://jenkins.ubuntu.com/server/job/cloud-init-ci/846/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-14 Thread Scott Moser
Diff comments: > diff --git a/tests/cloud_tests/testcases/modules/snap.yaml > b/tests/cloud_tests/testcases/modules/snap.yaml > new file mode 100644 > index 000..e520415 > --- /dev/null > +++ b/tests/cloud_tests/testcases/modules/snap.yaml > @@ -0,0 +1,21 @@ > +# > +# Install snappy > +# >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-14 Thread Joshua Powers
I like the comparisons on versions, that helps a lot on future tests. In addition to the unit and style tests, the integration tests need fixing: https://paste.ubuntu.com/p/MWzFZjZYwS/ -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366 Your team cloud-init

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-14 Thread Chad Smith
Diff comments: > diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py > new file mode 100644 > index 000..edb21bb > --- /dev/null > +++ b/cloudinit/config/cc_snap.py > @@ -0,0 +1,272 @@ > +# Copyright (C) 2018 Canonical Ltd. > +# > +# This file is part of cloud-init. See

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-14 Thread Scott Moser
two small things, interested in your thoughts. Diff comments: > diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py > new file mode 100644 > index 000..edb21bb > --- /dev/null > +++ b/cloudinit/config/cc_snap.py > @@ -0,0 +1,272 @@ > +# Copyright (C) 2018 Canonical Ltd. >

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-12 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:9fbe196e746382391fd74e9d8fd3fa4fb40332c8 https://jenkins.ubuntu.com/server/job/cloud-init-ci/837/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-10 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:7ce2f80f60efdd9eedd63ee0672ac14bbc1dcc2b https://jenkins.ubuntu.com/server/job/cloud-init-ci/835/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-09 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:a59dc135625a7d41abd36564302ea4485bd6a7d6 https://jenkins.ubuntu.com/server/job/cloud-init-ci/833/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-08 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c54c5378e3a6174533fa58de1ce9de2a745daa6d https://jenkins.ubuntu.com/server/job/cloud-init-ci/831/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild:

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-07 Thread Scott Moser
My comments there is a lot here, as you said. * generally the test harness changes could be separated. * I think access to the platform and os info in the test cases is good. * I dont think the validation of /run/cloud-init/instance-data.json needs to be Snap specific at all, we should

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-07 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:d68942b90ac4c18e9763563c288d436deed18456 https://jenkins.ubuntu.com/server/job/cloud-init-ci/826/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-07 Thread Chad Smith
Diff comments: > diff --git a/tests/cloud_tests/testcases/modules/snap.py > b/tests/cloud_tests/testcases/modules/snap.py > new file mode 100644 > index 000..7120e3f > --- /dev/null > +++ b/tests/cloud_tests/testcases/modules/snap.py > @@ -0,0 +1,132 @@ > +# This file is part of

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-07 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:ac9bb942577352b6e42c0cfd2c9571955fd295a8 https://jenkins.ubuntu.com/server/job/cloud-init-ci/825/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-07 Thread Joshua Powers
See inline Diff comments: > diff --git a/tests/cloud_tests/testcases/modules/snap.py > b/tests/cloud_tests/testcases/modules/snap.py > new file mode 100644 > index 000..7120e3f > --- /dev/null > +++ b/tests/cloud_tests/testcases/modules/snap.py > @@ -0,0 +1,132 @@ > +# This file is part of

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-07 Thread Scott Moser
some comments Diff comments: > diff --git a/cloudinit/config/cc_snap.py b/cloudinit/config/cc_snap.py > new file mode 100644 > index 000..1f94079 > --- /dev/null > +++ b/cloudinit/config/cc_snap.py > @@ -0,0 +1,275 @@ > +# Copyright (C) 2018 Canonical Ltd. > +# > +# This file is part of

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-06 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:9c782d4ef006225e40a0da8c375d9951c6a50ce7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/822/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-02-20 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:921fb06b0988d217d3e88f45db6b30e6e8acc5e6 https://jenkins.ubuntu.com/server/job/cloud-init-ci/776/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build FAILED: