Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-10-26 Thread Joshua Harlow
*thought -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into cloud-init:master. ___ Mailing list: ht

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-10-26 Thread Joshua Harlow
Will double check, though I fixed that recently. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-10-25 Thread Scott Moser
Josh, can you take another look here? -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into cloud-init:master. __

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-10-20 Thread Scott Moser
it looks like your test case is busted, flake8 fails which makes me wonder if its working correctly. tests/unittests/test_net.py:478:36: F821 undefined name 'name' tests/unittests/test_net.py:478:42: F821 undefined name 'field' that and a few other changes: http://paste.ubuntu.com/23354704

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-10-19 Thread Mike Dorman
Data point: We tried this patch out locally under RHEL7 and it's working like a champ. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into clou

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-09-30 Thread Joshua Harlow
Oh, lol. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into cloud-init:master. ___ Mailing list: ht

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-09-29 Thread Scott Moser
hm.. i had just inteded to say lets drop sys_netdev_info and instead make the callers use read_sys_net -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-09-21 Thread Joshua Harlow
Ya, that makes sense to me, I can adjust this one. -- https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/305882 Your team cloud init development team is requested to review the proposed merge of ~harlowja/cloud-init:sys-io-errors into cloud-init:master. __

Re: [Cloud-init-dev] [Merge] ~harlowja/cloud-init:sys-io-errors into cloud-init:master

2016-09-21 Thread Scott Moser
Josh, I had sort of done this as: http://paste.ubuntu.com/23207571/ The person who had reproduced this on arch said that the patch above it fixes it. Another option... it looks like callers of sys_netdev_info could use read_sys_net. And read_sys_net actually handles the IOError already. I thin