Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2017-03-08 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:7c480f71a2016f9a727479a54a002d03ec24453f https://jenkins.ubuntu.com/server/job/cloud-init-ci/94/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/94 SUCCESS: https

Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2017-03-06 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:312808680eb5484b112ef874bf13fe2fdac8515e https://jenkins.ubuntu.com/server/job/cloud-init-ci/87/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/87 FAILURE:

Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2017-01-11 Thread Maitreyee Saikia
Diff comments: > diff --git a/cloudinit/sources/helpers/vmware/imc/config.py > b/cloudinit/sources/helpers/vmware/imc/config.py > index d645c49..711dc0b 100644 > --- a/cloudinit/sources/helpers/vmware/imc/config.py > +++ b/cloudinit/sources/helpers/vmware/imc/config.py > @@ -28,11 +30,15 @@ cla

Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2017-01-11 Thread Maitreyee Saikia
> Please set a combined commit message ('Set commit message' above. > > Can you explain where you're going also? > I'm concerned about adding more "vmware" paths for configuring things that are > done elsewhere (or not elsewhere) in cloud-init. We'd like have consistent > paths for doing things a

Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2017-01-11 Thread Scott Moser
Please set a combined commit message ('Set commit message' above. Can you explain where you're going also? I'm concerned about adding more "vmware" paths for configuring things that are done elsewhere (or not elsewhere) in cloud-init. We'd like have consistent paths for doing things as much as

Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2016-11-21 Thread Maitreyee Saikia
Updated some formatting. -- https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427 Your team cloud init development team is requested to review the proposed merge of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master. ___

Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2016-10-25 Thread Maitreyee Saikia
Thanks for the comments Joshua. Updated the diff. -- https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427 Your team cloud init development team is requested to review the proposed merge of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master. __

Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master

2016-10-13 Thread Joshua Harlow
Diff comments: > diff --git a/cloudinit/sources/helpers/vmware/imc/config.py > b/cloudinit/sources/helpers/vmware/imc/config.py > index d645c49..a86233f 100644 > --- a/cloudinit/sources/helpers/vmware/imc/config.py > +++ b/cloudinit/sources/helpers/vmware/imc/config.py > @@ -93,3 +94,34 @@ clas