Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master
Review: Approve continuous-integration PASSED: Continuous integration, rev:7c480f71a2016f9a727479a54a002d03ec24453f https://jenkins.ubuntu.com/server/job/cloud-init-ci/94/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/94 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/94 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-ppc64el/94 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-s390x/94 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=vm-i386/94 Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/94/rebuild -- https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427 Your team cloud init development team is requested to review the proposed merge of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:312808680eb5484b112ef874bf13fe2fdac8515e https://jenkins.ubuntu.com/server/job/cloud-init-ci/87/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-arm64/87 FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-ppc64el/87/console SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-s390x/87 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=vm-amd64/87 SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=vm-i386/87 Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/87/rebuild -- https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427 Your team cloud init development team is requested to review the proposed merge of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master
Diff comments:
> diff --git a/cloudinit/sources/helpers/vmware/imc/config.py
> b/cloudinit/sources/helpers/vmware/imc/config.py
> index d645c49..711dc0b 100644
> --- a/cloudinit/sources/helpers/vmware/imc/config.py
> +++ b/cloudinit/sources/helpers/vmware/imc/config.py
> @@ -28,11 +30,15 @@ class Config(object):
>
> DNS = 'DNS|NAMESERVER|'
> SUFFIX = 'DNS|SUFFIX|'
> -PASS = 'PASSWORD|-PASS'
> TIMEZONE = 'DATETIME|TIMEZONE'
> UTC = 'DATETIME|UTC'
> HOSTNAME = 'NETWORK|HOSTNAME'
> DOMAINNAME = 'NETWORK|DOMAINNAME'
> +CUSTOM_SCRIPT = 'CUSTOM-SCRIPT|SCRIPT-NAME'
> +PASS = 'PASSWORD|-PASS'
> +RESETPASS = 'PASSWORD|RESET'
> +MARKERID = 'MISC|MARKER-ID'
> +POST_GC = 'MISC|POST-GC-STATUS'
Thanks. I just wanted to keep functions related to a certain product together.
But sorted sounds good too.
>
> def __init__(self, configFile):
> self._configFile = configFile
> @@ -93,3 +94,34 @@ class Config(object):
> res.append(Nic(nic, self._configFile))
>
> return res
> +
> +@property
> +def admin_password(self):
> +"""Return the root password to be set."""
> +return self._configFile.get(Config.PASS, None)
The reason i moved this was just to keep all the methods associated to a
particular product together. But it is nothing critical. So I can move it back
to where it was.
> +
> +@property
> +def reset_password(self):
> +"""Retreives if the root password needs to be reset."""
> +resetPass = self._configFile.get(Config.RESETPASS, None)
> +if resetPass and not re.match('yes$|no$', resetPass.lower()):
> +raise ValueError('ResetPassword value should be yes/no')
> +return resetPass
> +
> +@property
> +def marker_id(self):
> +"""Returns marker id."""
> +return self._configFile.get(Config.MARKERID, None)
> +
> +@property
> +def post_gc_status(self):
> +"""Retreives if customization status needs to be posted."""
> +postGcStatus = self._configFile.get(Config.POST_GC, None)
> +if postGcStatus and not re.match('yes$|no$', postGcStatus.lower()):
> +raise ValueError('GC status value should be yes/no')
> +return postGcStatus
> +
> +@property
> +def custom_script_name(self):
> +"""Return the name of custom (pre/post) script."""
> +return self._configFile.get(Config.CUSTOM_SCRIPT, None)
--
https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427
Your team cloud init development team is requested to review the proposed merge
of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master.
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master
> Please set a combined commit message ('Set commit message' above.
>
> Can you explain where you're going also?
> I'm concerned about adding more "vmware" paths for configuring things that are
> done elsewhere (or not elsewhere) in cloud-init. We'd like have consistent
> paths for doing things as much as possible.
>
> I understand that you're trying to have cloud-init take over another more
> solution, and I'm not entirely opposed to that, but I want to integrate as
> much as possible rather than having specific paths and function on vmware.
Thanks for your input Scott. I have updated the commit message.
This changeset is just to retrieve data from customization spec, for
implementing some other customization functionalities like setting password,
running post customization scripts etc. I shall post another changeset with the
password configurator, which manipulates the values retrieved from these
methods to be used by cloud-init's cc_set_password. We will be using as much
cloud-init code as possible. For other functionalities like running pre and
post customization specs that will be uploaded by the user, I dont think there
is existing support. Please let me know if that sounds ok. Also for functions
that are "vmware" specific, shall we still keep it in the helper path that we
have created for vmware, or do we want to move them to some common code area?
Thanks
Maitreyee
--
https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427
Your team cloud init development team is requested to review the proposed merge
of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master.
___
Mailing list: https://launchpad.net/~cloud-init-dev
Post to : cloud-init-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~cloud-init-dev
More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master
Updated some formatting. -- https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427 Your team cloud init development team is requested to review the proposed merge of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master
Thanks for the comments Joshua. Updated the diff. -- https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/305427 Your team cloud init development team is requested to review the proposed merge of ~msaikia/cloud-init:topic-msaikia-vmware into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
