Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master
Review: Approve continuous-integration PASSED: Continuous integration, rev:aaf0c0e11ed07b65d15f8759d907483561c40334 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1207/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu LTS: Integration IN_PROGRESS: Declarative: Post Actions Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/1207//rebuild -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master
Review: Approve Right. In the usual failure mode retrying should work even without sleeping, but it's way better to add a sleep(1) there. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c6bdca59c2b7afdf19b9bc7a4df8367584016627 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1206/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenkins.ubuntu.com/server/job/cloud-init-ci/1206//rebuild -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master
I need to add a sleep after the failure -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master
Review: Approve LGTM -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/374043 Your team cloud-init Commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/cloud-tests-lxd-retry-delete into cloud-init:master. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
